Contributing to Go

Motivation and How-to for contributing to Go.

Transcript

1. ! Contributing to Go @nathany
2. Motivation even better tools
3. go.tools/cover
4. Naming things func validateFlags() error “notice that the purpose of this is to set up state; the validation is secondary. it's misnamed.” - r
5. Error messages "phrasing: say what's wrong, not how to fix it.” ! return fmt.Errorf("unexpected argument provided”) “this isn't quite right. "extra argument"? "too many arguments"?” - r
7. Code style pathsToRemove := make([]string, 0) ! “Just write: ! var pathsToRemove []string” - iant! https://code.google.com/p/go-wiki/wiki/CodeReviewComments
8. Effective use of the standard library ! atomic.AddInt32(&c.val, 1) ! “use ioutil.TempDir to create a unique root for this test run” - dfc!
9. – rsc “The goal here should be to expose the minimal necessary functionality that lets people build useful things…” API design
10. – rsc “The problem with callbacks is that you now have to worry about user code blocking (or panicking) a library goroutine. ! A channel is a much better separation.” I hadn’t considered…
11. – rsc “There is no testing benefit here to the interface over a simple struct with only public fields.” Keep it simple
12. –Chad Fowler “Pick an open source project that you admire and whose developers appear to be at that "next level" you’re looking to reach.” Motivation
13. Go source # Mac
 xcode-select --install
 brew install hg
 
 hg clone https://code.google.com/p/go
 cd go/src
 ./all.bash golang.org/doc/install/source
14. CLA # .bashrc/.zshrc
 export GOPATH=$HOME/project
 export PATH=$PATH:$HOME/go/bin:$HOME/project/bin
 Contributor License Agreement golang.org/doc/contribute.html#copyright GOPATH
15. go.tools • godoc • vet • cover • oracle • goimports go get code.google.com/p/go.tools/cmd/godoc
16. CDPATH # .bashrc
 export CDPATH=.:$HOME/go/src/pkg:$GOPATH/ src/code.google.com/p
 
 # .zshrc
 setopt auto_cd
 cdpath=($HOME/go/src/pkg $GOPATH/src/ code.google.com/p) cd net/http
17. hg pull
 hg update
 
 hg update release hg update default
18. rietveld “not the same as using standard Mercurial” # .hg/hgrc
 [extensions]
 codereview = ~/go/lib/codereview/codereview.py
 
 [ui]
 username = Your Name <you@server.dom> tip.golang.org/doc/contribute.html
19. rietveld hg help codereview
 hg code-login ! # code, code, code hg add myfile.go
20. review hg ksdiff
 ./all.bash ! godoc -http=:8080 ! hg change www.kaleidoscopeapp.com
21. CL
22. PTAL hg sync
 
 hg mail 999999 ! hg upload 999999
23. LGTM Submitted