Upgrade to Pro — share decks privately, control downloads, hide ads and more …

CakePHP プロジェクトにプルリクを送り続けた僕は

CakePHP プロジェクトにプルリクを送り続けた僕は

CakePHP プロジェクトに半年の間に送ったプルリクエストの振り返りです。
(第112回PHP勉強会@東京)

tenkoma (Koji Tanaka)

March 29, 2017
Tweet

More Decks by tenkoma (Koji Tanaka)

Other Decks in Programming

Transcript

  1. $BLF1)1
    ϓϩδΣΫτʹ
    ϓϧϦΫΤετΛૹΓଓ͚ͨ
    ๻͸
    !UFOLPNB,PKJ5BOBLB

    View full-size slide

  2. ࣗݾ঺հ
    w ,PKJ5BOBLB!UFOLPNB
    w ۈ຿ઌגࣜձࣾγʔϒϨΠϯ
    w ۈ຿ઌϒϩά
    w ԻָήʔϜ޷͖ 3C 4%79

    w ࠷ۙ༡ΜͰΔ΋ͷ(JU-BC$* (JU-BC1BHFT
    ޷͖ͳπʔϧ

    View full-size slide

  3. ࣭໰
    w $BLF1)1ฉ͍ͨ͜ͱ͕͋Δʁ
    w ࢖ͬͨ͜ͱ͕͋Δʁ
    w *TTVFPS13Λૹͬͨ͜ͱ͕͋
    Δʁ

    View full-size slide

  4. 1VMM3FRVFTUͱ͸
    ίʔυͷվળ఺ͱ

    View full-size slide

  5. Կ͕໰୊ͰɺͲ͏վળ͔ͨ͠
    ͷઆ໌Ληοτʹͨ͠΋ͷ

    View full-size slide

  6. ࠓ೔ͷωλ
    w $BLF1)1ϓϩδΣΫτ
    ʹ൒೥લ͔Β13Λͦͦ͜
    ͜ૹΔΑ͏ʹͳͬͨ࿩

    View full-size slide

  7. 1)1Ϣʔβʔͱͯ͠
    w 1)1ྺ೥ Λ࢖ͬͨ͜ͱ͋Δ

    w $BLF1)1ྺʙ೥ ͔Β

    w Y Y࢖͖ͬͯͨ

    View full-size slide

  8. ۈ຿ઌͷϒϩάͰ΋ॻ͍͖ͯͨ

    View full-size slide

  9. ೥લ ೥
    ·Ͱ͸ϓϧϦΫΛ
    ૹΖ͏ͱ͔ࢥͬͯ΋ख͕ग़ͳ͔ͬͨ
    യવͱ͕ͨ͋͜͠Ε͸͋ͬͨ

    View full-size slide







  10. 13 *TTVF
    ˞ผϒϥϯν΁ͷશ͘ಉ͡มߋͷ13͸আ͘

    View full-size slide

  11. ϓϩδΣΫτผ
    w $BLF1)1 ίΞ
    ݅
    w EPDT υΩϡϝϯτ
    ݅
    w BQQ ϓϩδΣΫτςϯϓϨʔτ
    ݅
    w BQJEPDT "1*υΩϡϝϯτ
    ݅
    w DBLFQIQPSH 8FCαΠτ
    ݅
    ˞ผϒϥϯν΁ͷશ͘ಉ͡มߋͷ13ؚΉ

    View full-size slide

  12. ͳΜͰ࠷ۙૹΔΑ͏ʹ
    ͳͬͨͷʁ

    View full-size slide

  13. ݅໨
    w ҠߦυΩϡϝϯ
    τͷޡ༁
    w -BSBWFMϛʔτΞο
    ϓͰձͬͨ຋༁ऀʹ
    ૬ஊ
    w 'BDFCPPLϝοηʔ
    δͰ΍ΓͱΓޙ13

    View full-size slide

  14. ೥ϲ݄ͷۭന

    View full-size slide

  15. ݅໨
    ݅໨J1BEͰબ୒Ͱ͖ͳ͍

    View full-size slide

  16. +4ϥΠϒϥϦΛ࡟আͯ͠$44ʹ

    View full-size slide

  17. ͕͢͞ʹෆ҆ʹͳͬͯ
    4MBDL೔ຊޠνϟϯωϧͰ૬ஊ

    View full-size slide

  18. 4MBDLͰײँͷݴ༿Λ
    ΋Βͬͨ

    View full-size slide

  19. ͨʔͷ͠ʔʂ

    View full-size slide

  20. ϓϧϦΫͷྫ
    w 5ZQPमਖ਼
    w υΩϡϝϯτͷz8FMDPNFzΛ຋༁
    w υΩϡϝϯτ಺ͷδϣʔΫΛ࡟আ
    w ݕࡧػೳվળ
    w ৗʹ࠷৽ͷ"1*υΩϡϝϯτʹϦϯΫͰ͖ΔΑ͏
    ʹ͢Δ
    ຋༁ʹ΋ؔΘ͍͖͍ͬͯͨ

    View full-size slide

  21. ԿͰૹΔΑ͏ʹͳͬͨͷʁ
    w Ϛʔδ͞ΕΔͱࣗ৴ʹͭͳ͕Δ
    w Ϛʔδ͞Εͳͯ͘΋ɺίΞϝϯόʔ͔Β
    ϨϏϡʔͯ͠΋Β͑Δ
    w ৽ػೳΛ͍ͪૣ͘஌Δ͜ͱ͕Ͱ͖Δ
    w ӳจνϣοτζπϤϝϧϤ΢χφϧ

    View full-size slide

  22. Θ͔ͬͨ͜ͱ
    w $BLF1)1͸೥ͷϓϩδΣΫτͰɺυΩϡ
    ϝϯτͳͲ΋੔උ͞Ε͍ͯΔΑ͏ʹΈ͑Δ͔΋
    ͠Εͳ͍͕ɺվળͰ͖Δ͜ͱ͸ͨ͘͞Μ͋ͬͨ
    w ޡࣈ୤ࣈɺߦ13େ׻ܴʂ
    w 13ΛૹΔͷ͸ָ͍͠ ݸਓͷײ૝Ͱ͢

    View full-size slide