Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Peer Code Reviews

A298fade27a9c2ebe7bea8f93997b5c6?s=47 Emma Jane Hogbin Westby
February 20, 2015
Technology
2
420

Peer Code Reviews

Nearly all open source projects have some form of peer review system. In this session you will learn the pros (and cons) of adopting a peer review system in-house. To illustrate how this unfolded in the real world, a case study will be used. We'll talk about the overall setup, the impact on the team, and give you tips on how to conduct a good peer review.

A298fade27a9c2ebe7bea8f93997b5c6?s=128

Emma Jane Hogbin Westby

February 20, 2015
Tweet

More Decks by Emma Jane Hogbin Westby

See All by Emma Jane Hogbin Westby
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
61
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
62
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
1
160
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
5
410
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
74
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
150
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
120
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
95
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
260

Other Decks in Technology

See All in Technology
40301c0affdf359eaca771713e22b71a?s=48 harshbothra
0
120
F3c727195d975cf7a4b300e4f5c2c0d1?s=48 am7cinnamon
2
2.7k
0e20ab5db11ca70d818a4f10bfea9c9c?s=48 ymas0315
0
160
Dd23bc768f5ebe8a01126aaa8f0c86cf?s=48 neo_analytics
1
1k
1896b034326abb4bc429d6718dc6a42e?s=48 shomaekawa
3
1.2k
53850955f15249a1a9dc49df6113e400?s=48 line_developers
PRO
0
2k
510ec964f5d26c2724c883fd7b671e3d?s=48 cygames
1
370
0d29d155ce5c5a93ed46363626da3ea7?s=48 ocise
1
940
A64ac825509279a770c13c6fc517f11a?s=48 kawaguti
0
120
9e7a653ed313b3da4b263a772bfc5026?s=48 clustervr
0
190
A8f0494d61f79b35ff8a4902c7decb73?s=48 iqbocchi
0
530
19fc8f6113c5c3d86e6176362ff29479?s=48 kanaugust
PRO
0
230

Featured

See All Featured
44b54d2ffcb7857004071cc6795dde11?s=48 cassininazir
347
20k
C620790ae5bf5b50c245b2e0ef95f338?s=48 deanohume
295
27k
78b475797a14c84799063c7cd073962f?s=48 holman
288
130k
A415db3ac9e9668acbc1fb36eead84ac?s=48 mthomps
39
2.3k
D36d2c1821af9249b69ff7f5ed60529b?s=48 tammielis
237
23k
245cee81a9c424266e5e401d844ea881?s=48 lara
590
61k
E13c31390e0369fcd5972292ce0e7b92?s=48 jnunemaker
PRO
40
4.5k
053e75a5b48b44d6dd0612795dfb326d?s=48 notwaldorf
13
1.5k
E195ae45320d9202eaa01c9f1d31a416?s=48 marktimemedia
6
330
06f8b41980eb4c577fa40c41d5030c19?s=48 keathley
17
640
Fde6c3a50ca518a909ef35c22c0ee0e4?s=48 destraynor
146
19k
027d1ebf66cc039a0bd3b55eeadbe75d?s=48 sachag
446
36k

Transcript

  1. Peer Code Reviews Emma Jane Hogbin Westby - Trillium Consultancy

    Ltd. www.gitforteams.com @emmajanehw

  2. “in a culture of optimism good honest criticism seems to

    be dying out” Tim Brown Tim Brown

  3. None

  4. Overview • Storytime! • Types of reviewers and types of

    reviews • Structuring the review process • Providing excellent feedback

  5. Storytime!

  6. Be intentional about your reviews.

  7. Not all reviews are the same. • Design crit •

    Technical architecture review • Automated self-check
 (coding standards; test suites) • Ticket-based peer code review • Quality Assurance / User Acceptance Testing

  8. Not all reviewers are the same. • Disinterested Reviewer •

    Peer Reviewer • Automated Gatekeeper • Consensus Shepherd • Benevolent Dictator

  9. Peer reviews are for everyone. Junior Coder Senior Coder Junior

    Reviewer • find bugs • compliance with coding standards • learn to read good code • suggest simplifications • exposure Senior Reviewer • suggest new techniques • improve architecture • improve architecture • cross-functional team (exposure)

  10. Use templates 
 and checklists.

  11. Use templates to structure the process. LaunchPad - http://lb.cm/tmplt-launchpad Drupal

    - http://lb.cm/tmplt-drupal Symfony - http://lb.cm/tmplt-symfony

  12. Use Checklists to Ensure You’re Meeting Standards http://drupal.org/core-gates

  13. Internal Checklists http://gitforteams.com/resources/review-process.html

  14. Provide excellent feedback.

  15. Good Feedback is Usable • Limit it to the scope

    of the work. • Make it actionable. • Make it specific. • Do it as soon as possible. • Acknowledge effort and give thanks.

  16. Bad Feedback
 is Destructive

  17. Summary • Implementing code reviews at work can initially cause

    more tension. • Code reviews will improve the skills of everyone on the team — communication and coding. • Consider the types of review, and work towards implementing the right feedback at the right time. • Co-create checklists for the review process. • Provide excellent, actionable feedback.

  18. Peer Code Review Resources http://lb.cm/ala-code-reviews http://lb.cm/review-process www.gitforteams.com @emmajanehw