Peer Code Reviews

A298fade27a9c2ebe7bea8f93997b5c6?s=47 Emma Jane Hogbin Westby
February 20, 2015
Technology
2
400

Peer Code Reviews

Nearly all open source projects have some form of peer review system. In this session you will learn the pros (and cons) of adopting a peer review system in-house. To illustrate how this unfolded in the real world, a case study will be used. We'll talk about the overall setup, the impact on the team, and give you tips on how to conduct a good peer review.

A298fade27a9c2ebe7bea8f93997b5c6?s=128

Emma Jane Hogbin Westby

February 20, 2015
Tweet

More Decks by Emma Jane Hogbin Westby

See All by Emma Jane Hogbin Westby
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
58
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
58
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
1
160
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
5
400
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
73
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
150
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
110
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
89
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
250

Other Decks in Technology

See All in Technology
18f1e3993e9ead63e7a0f70d9eb996bb?s=48 wkm2
1
210
Cd823abda454a7a2065fe6fe273ae84b?s=48 viva_tweet_x
2
230
9e7a653ed313b3da4b263a772bfc5026?s=48 clustervr
0
190
93cee2893801a424aab6ce248d88b515?s=48 shimizukaz
0
190
53850955f15249a1a9dc49df6113e400?s=48 line_developers
0
140
3d6ace9554821d552146413bcdf874f6?s=48 trishagee
5
340
Cb88f765dd38cd942c39aacb5abbea06?s=48 ufoo68
1
210
1f745ff900e1be51aedae18cae76593c?s=48 kurochan
0
1.6k
B51ca7a51ae1fd06bc536fe83e6113e2?s=48 kaz29
6
4.3k
88f4e84b94fe07cddbd9e6479d689192?s=48 soudai
0
250
30d97c8383a531c459ac210540b4eace?s=48 ry
1
200
A38e9ebe0e62fd6753f555c005ea6551?s=48 tarukosu
0
480

Featured

See All Featured
4262b9cfacfb6b2c77f23e1d0310cd3e?s=48 myddelton
104
10k
7fa6101cd43067653cf4ac6c7ca54305?s=48 akmur
252
19k
Aebc2d07a50011e2a30d38435fde564a?s=48 jrom
113
6.8k
Ef32e0b1ac5082450dc8c1fca3a26b5c?s=48 cherdarchuk
64
250k
F68cb25ae3e5c2106997454b13b7737d?s=48 brad_frost
154
6.1k
9375a9529679f1b42b567a640d775e7d?s=48 schacon
144
6.4k
282d599b414022eba5096510f675b6e2?s=48 chrislema
169
13k
6bb82b13cda86d3b821fa44100335ddf?s=48 thoeni
2
290
Dafc4723e9a1c067796c0fec6f509774?s=48 lemiorhan
620
39k
06f8b41980eb4c577fa40c41d5030c19?s=48 keathley
12
420
4394ceb8b277f35ee3da7030384efb5d?s=48 davidbonilla
68
3.4k
E14f55d3f939977cecbf51b64ff6f861?s=48 keithpitt
398
20k

Transcript

  1. Peer Code Reviews Emma Jane Hogbin Westby - Trillium Consultancy

    Ltd. www.gitforteams.com @emmajanehw

  2. “in a culture of optimism good honest criticism seems to

    be dying out” Tim Brown Tim Brown

  3. None

  4. Overview • Storytime! • Types of reviewers and types of

    reviews • Structuring the review process • Providing excellent feedback

  5. Storytime!

  6. Be intentional about your reviews.

  7. Not all reviews are the same. • Design crit •

    Technical architecture review • Automated self-check
 (coding standards; test suites) • Ticket-based peer code review • Quality Assurance / User Acceptance Testing

  8. Not all reviewers are the same. • Disinterested Reviewer •

    Peer Reviewer • Automated Gatekeeper • Consensus Shepherd • Benevolent Dictator

  9. Peer reviews are for everyone. Junior Coder Senior Coder Junior

    Reviewer • find bugs • compliance with coding standards • learn to read good code • suggest simplifications • exposure Senior Reviewer • suggest new techniques • improve architecture • improve architecture • cross-functional team (exposure)

  10. Use templates 
 and checklists.

  11. Use templates to structure the process. LaunchPad - http://lb.cm/tmplt-launchpad Drupal

    - http://lb.cm/tmplt-drupal Symfony - http://lb.cm/tmplt-symfony

  12. Use Checklists to Ensure You’re Meeting Standards http://drupal.org/core-gates

  13. Internal Checklists http://gitforteams.com/resources/review-process.html

  14. Provide excellent feedback.

  15. Good Feedback is Usable • Limit it to the scope

    of the work. • Make it actionable. • Make it specific. • Do it as soon as possible. • Acknowledge effort and give thanks.

  16. Bad Feedback
 is Destructive

  17. Summary • Implementing code reviews at work can initially cause

    more tension. • Code reviews will improve the skills of everyone on the team — communication and coding. • Consider the types of review, and work towards implementing the right feedback at the right time. • Co-create checklists for the review process. • Provide excellent, actionable feedback.

  18. Peer Code Review Resources http://lb.cm/ala-code-reviews http://lb.cm/review-process www.gitforteams.com @emmajanehw