Peer Code Reviews

A298fade27a9c2ebe7bea8f93997b5c6?s=47 Emma Jane Hogbin Westby
February 20, 2015
Technology
2
410

Peer Code Reviews

Nearly all open source projects have some form of peer review system. In this session you will learn the pros (and cons) of adopting a peer review system in-house. To illustrate how this unfolded in the real world, a case study will be used. We'll talk about the overall setup, the impact on the team, and give you tips on how to conduct a good peer review.

A298fade27a9c2ebe7bea8f93997b5c6?s=128

Emma Jane Hogbin Westby

February 20, 2015
Tweet

More Decks by Emma Jane Hogbin Westby

See All by Emma Jane Hogbin Westby
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
59
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
61
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
1
160
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
5
400
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
73
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
150
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
110
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
92
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
250

Other Decks in Technology

See All in Technology
Cc8a208e174943d1da814783841abd50?s=48 shinodogg
2
210
553784f5490e80cde79ef80ee70b5ed2?s=48 takamii228
1
120
0aa238a274c2397214b20d6eed58939b?s=48 moomooya
0
350
D2bcabeeb1ddff142fb8988b412cb4d3?s=48 yanzm
5
1.1k
6eafc285d1d95416f55822cb17032af7?s=48 toshi_piro
0
130
C82711d1ecc5cc7a4474dd9314736f33?s=48 macole
0
150
4681d7bd0f8c32b6e3e582891938e577?s=48 iktakahiro
3
1.5k
9e7a653ed313b3da4b263a772bfc5026?s=48 clustervr
0
150
Eeedbe91225c0207014a46f09eea1d30?s=48 nearmugi
1
130
1d8947ec45ce78c83251f4d076abe329?s=48 rpabank
0
170
457ada693e168bd1102fec3914040b5d?s=48 uipath_friends
0
130
1e8c5eaf563f965d3ba48b0054b1d955?s=48 shoichiron
8
3k

Featured

See All Featured
Bfd6b681ec6e8c9bef82ff0521c364f7?s=48 kastner
52
1.8k
Af6a12710770ad9a7cfd08c97efd40d3?s=48 pedronauck
649
110k
6804f1775cb4babfcc3851298566fbce?s=48 tanoku
85
8.4k
3d6ace9554821d552146413bcdf874f6?s=48 trishagee
15
1k
B6a8f005f39d23ffc930508ac9da68b9?s=48 vanstee
115
4.7k
3d4519fd34b76fb265fc0237f3792bd4?s=48 danielanewman
1
340
7fa6101cd43067653cf4ac6c7ca54305?s=48 akmur
252
19k
282d599b414022eba5096510f675b6e2?s=48 chrislema
171
14k
C157b16234f1e75e8eac3698c1d4414a?s=48 ddemaree
273
31k
465724d73fe3a92c0879fdfb43a3a6f3?s=48 philhawksworth
190
17k
433acaea1012b25d97ae66da9b998dad?s=48 malarkey
392
60k
E76911cbe088e5b850d966de3fc7435b?s=48 robhawkes
52
2.7k

Transcript

  1. Peer Code Reviews Emma Jane Hogbin Westby - Trillium Consultancy

    Ltd. www.gitforteams.com @emmajanehw

  2. “in a culture of optimism good honest criticism seems to

    be dying out” Tim Brown Tim Brown

  3. None

  4. Overview • Storytime! • Types of reviewers and types of

    reviews • Structuring the review process • Providing excellent feedback

  5. Storytime!

  6. Be intentional about your reviews.

  7. Not all reviews are the same. • Design crit •

    Technical architecture review • Automated self-check
 (coding standards; test suites) • Ticket-based peer code review • Quality Assurance / User Acceptance Testing

  8. Not all reviewers are the same. • Disinterested Reviewer •

    Peer Reviewer • Automated Gatekeeper • Consensus Shepherd • Benevolent Dictator

  9. Peer reviews are for everyone. Junior Coder Senior Coder Junior

    Reviewer • find bugs • compliance with coding standards • learn to read good code • suggest simplifications • exposure Senior Reviewer • suggest new techniques • improve architecture • improve architecture • cross-functional team (exposure)

  10. Use templates 
 and checklists.

  11. Use templates to structure the process. LaunchPad - http://lb.cm/tmplt-launchpad Drupal

    - http://lb.cm/tmplt-drupal Symfony - http://lb.cm/tmplt-symfony

  12. Use Checklists to Ensure You’re Meeting Standards http://drupal.org/core-gates

  13. Internal Checklists http://gitforteams.com/resources/review-process.html

  14. Provide excellent feedback.

  15. Good Feedback is Usable • Limit it to the scope

    of the work. • Make it actionable. • Make it specific. • Do it as soon as possible. • Acknowledge effort and give thanks.

  16. Bad Feedback
 is Destructive

  17. Summary • Implementing code reviews at work can initially cause

    more tension. • Code reviews will improve the skills of everyone on the team — communication and coding. • Consider the types of review, and work towards implementing the right feedback at the right time. • Co-create checklists for the review process. • Provide excellent, actionable feedback.

  18. Peer Code Review Resources http://lb.cm/ala-code-reviews http://lb.cm/review-process www.gitforteams.com @emmajanehw