Save 37% off PRO during our Black Friday Sale! »

Peer Code Reviews

A298fade27a9c2ebe7bea8f93997b5c6?s=47 Emma Jane Hogbin Westby
February 20, 2015
Technology
2
490

Peer Code Reviews

Nearly all open source projects have some form of peer review system. In this session you will learn the pros (and cons) of adopting a peer review system in-house. To illustrate how this unfolded in the real world, a case study will be used. We'll talk about the overall setup, the impact on the team, and give you tips on how to conduct a good peer review.

A298fade27a9c2ebe7bea8f93997b5c6?s=128

Emma Jane Hogbin Westby

February 20, 2015
Tweet

More Decks by Emma Jane Hogbin Westby

See All by Emma Jane Hogbin Westby
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
68
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
70
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
1
170
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
5
440
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
80
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
160
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
130
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
110
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
290

Other Decks in Technology

See All in Technology
C422cc033079e005fd1aa1b845b099da?s=48 meow_noisy
0
130
97a7f7899e0df28c3636b8d44bbe6578?s=48 korodroid
0
280
7a29c02251394fc05ebd88c631c562dc?s=48 takufujii
0
330
0b238801605070def81a98cfe8061aee?s=48 shonansurvivors
5
420
208eaad444edf8029cba3bbd1c0cc864?s=48 takumiogawa
6
3.2k
665dd8a044d0e509e730a20ba9612d37?s=48 alexdaubois
1
130
23f4d5d797a91b6d17d627b90b5a42d9?s=48 kentaro
0
360
Dd228ece3eac622c0b1b5f71f54b29ea?s=48 chisaton
0
210
88f4e84b94fe07cddbd9e6479d689192?s=48 soudai
31
17k
Ca6281fff64797dc419b78f51f25c0a5?s=48 fujiwara3
PRO
4
710
60d4494f2321b322b050ea78acb7b0b1?s=48 matyuda
1
110
73c9d1065e0075a9da6e404e08fe77fb?s=48 siroitori0413
0
130

Featured

See All Featured
B3d6434763caa0ef5dc4b792662c49f7?s=48 smashingmag
289
47k
Ba530e786553390f3fb271848485681c?s=48 3n
169
23k
20bfe76b3d6105641f879fe45cfc9272?s=48 bkeepers
PRO
324
54k
2bb923c57a1fdc3a2eb484bb8d565fd2?s=48 ufuk
61
7.3k
027d1ebf66cc039a0bd3b55eeadbe75d?s=48 sachag
270
17k
C86443373fbfe92996aa882d0d7a59f8?s=48 imathis
484
150k
719435d98d452de7ac367c828266cf01?s=48 erikaheidi
29
5.2k
4262b9cfacfb6b2c77f23e1d0310cd3e?s=48 myddelton
110
11k
761be20b5ebd271008bcee1244fc5b52?s=48 matthewcrist
73
7.7k
Fde6c3a50ca518a909ef35c22c0ee0e4?s=48 destraynor
148
20k
864a009ac73600c7c02e1f26629dd989?s=48 paigeccino
7
330
462dad0dd24c568a32dcdb0ae895ae1b?s=48 rasmusluckow
318
19k

Transcript

  1. Peer Code Reviews Emma Jane Hogbin Westby - Trillium Consultancy

    Ltd. www.gitforteams.com @emmajanehw

  2. “in a culture of optimism good honest criticism seems to

    be dying out” Tim Brown Tim Brown

  3. None

  4. Overview • Storytime! • Types of reviewers and types of

    reviews • Structuring the review process • Providing excellent feedback

  5. Storytime!

  6. Be intentional about your reviews.

  7. Not all reviews are the same. • Design crit •

    Technical architecture review • Automated self-check
 (coding standards; test suites) • Ticket-based peer code review • Quality Assurance / User Acceptance Testing

  8. Not all reviewers are the same. • Disinterested Reviewer •

    Peer Reviewer • Automated Gatekeeper • Consensus Shepherd • Benevolent Dictator

  9. Peer reviews are for everyone. Junior Coder Senior Coder Junior

    Reviewer • find bugs • compliance with coding standards • learn to read good code • suggest simplifications • exposure Senior Reviewer • suggest new techniques • improve architecture • improve architecture • cross-functional team (exposure)

  10. Use templates 
 and checklists.

  11. Use templates to structure the process. LaunchPad - http://lb.cm/tmplt-launchpad Drupal

    - http://lb.cm/tmplt-drupal Symfony - http://lb.cm/tmplt-symfony

  12. Use Checklists to Ensure You’re Meeting Standards http://drupal.org/core-gates

  13. Internal Checklists http://gitforteams.com/resources/review-process.html

  14. Provide excellent feedback.

  15. Good Feedback is Usable • Limit it to the scope

    of the work. • Make it actionable. • Make it specific. • Do it as soon as possible. • Acknowledge effort and give thanks.

  16. Bad Feedback
 is Destructive

  17. Summary • Implementing code reviews at work can initially cause

    more tension. • Code reviews will improve the skills of everyone on the team — communication and coding. • Consider the types of review, and work towards implementing the right feedback at the right time. • Co-create checklists for the review process. • Provide excellent, actionable feedback.

  18. Peer Code Review Resources http://lb.cm/ala-code-reviews http://lb.cm/review-process www.gitforteams.com @emmajanehw