Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Peer Code Reviews

A298fade27a9c2ebe7bea8f93997b5c6?s=47 Emma Jane Hogbin Westby
February 20, 2015
Technology
2
440

Peer Code Reviews

Nearly all open source projects have some form of peer review system. In this session you will learn the pros (and cons) of adopting a peer review system in-house. To illustrate how this unfolded in the real world, a case study will be used. We'll talk about the overall setup, the impact on the team, and give you tips on how to conduct a good peer review.

A298fade27a9c2ebe7bea8f93997b5c6?s=128

Emma Jane Hogbin Westby

February 20, 2015
Tweet

More Decks by Emma Jane Hogbin Westby

See All by Emma Jane Hogbin Westby
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
65
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
68
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
1
170
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
5
420
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
77
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
150
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
130
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
100
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
260

Other Decks in Technology

See All in Technology
140494d272a4d89883a94fdfdb29dea2?s=48 oracle4engineer
PRO
0
230
8d6c54ebb889a5fe3f77b763d563fd9f?s=48 serinuntius
0
620
Ecad9d801d79f6c6e5df93094690685e?s=48 sinsoku
6
1.7k
49844569246a6d183a5551bb74895e2a?s=48 kolinz
0
120
2016ba6b977a2e6691811fa66d5f4336?s=48 cyberagentdevelopers
PRO
0
200
7e20183342a040a32924a41343603286?s=48 konabuta
0
310
Cdf97a1b1b132c56582773c3ba09a3a6?s=48 rakus_dev
0
310
285cc95c4c9fe056b03afca581533266?s=48 fkubota
1
790
88964b936e864ca7d326272eaa70fa9a?s=48 hgsgtk
2
1.6k
Cd891a89dfec6ca7bd278b5f5bd87c90?s=48 tzkoba
9
2.7k
00851927294532e0742c2c174730dff0?s=48 ido_kara_deru
2
190
17d762ae166e66cab39e9b2e3df7d198?s=48 ysakashita
7
3.7k

Featured

See All Featured
D47656e20ff5e42f125fc5ea0fd636c6?s=48 tmm1
63
9.9k
F29327647a9cff5c69618bae420792ea?s=48 tenderlove
55
3.6k
E4f5d494ebdc9e7cce1aecf3ce3e8bc1?s=48 shpigford
371
43k
A60068bce2e73de3a37ca9d2dbe36092?s=48 bryan
33
3.6k
E14f55d3f939977cecbf51b64ff6f861?s=48 keithpitt
401
20k
5f2da528927a2ec9ba4fec2069cbc958?s=48 kneath
220
15k
E837d2996f52008ace055a08fbfff992?s=48 frogandcode
129
20k
91cefdf141106fa10674aae74ce05890?s=48 yeseniaperezcruz
303
32k
7fa6101cd43067653cf4ac6c7ca54305?s=48 akmur
253
19k
5f2da528927a2ec9ba4fec2069cbc958?s=48 kneath
294
39k
C9b18d9dff88a9dd2393364c2b3b21bd?s=48 colly
66
3.1k
C157b16234f1e75e8eac3698c1d4414a?s=48 ddemaree
273
32k

Transcript

  1. Peer Code Reviews Emma Jane Hogbin Westby - Trillium Consultancy

    Ltd. www.gitforteams.com @emmajanehw

  2. “in a culture of optimism good honest criticism seems to

    be dying out” Tim Brown Tim Brown

  3. None

  4. Overview • Storytime! • Types of reviewers and types of

    reviews • Structuring the review process • Providing excellent feedback

  5. Storytime!

  6. Be intentional about your reviews.

  7. Not all reviews are the same. • Design crit •

    Technical architecture review • Automated self-check
 (coding standards; test suites) • Ticket-based peer code review • Quality Assurance / User Acceptance Testing

  8. Not all reviewers are the same. • Disinterested Reviewer •

    Peer Reviewer • Automated Gatekeeper • Consensus Shepherd • Benevolent Dictator

  9. Peer reviews are for everyone. Junior Coder Senior Coder Junior

    Reviewer • find bugs • compliance with coding standards • learn to read good code • suggest simplifications • exposure Senior Reviewer • suggest new techniques • improve architecture • improve architecture • cross-functional team (exposure)

  10. Use templates 
 and checklists.

  11. Use templates to structure the process. LaunchPad - http://lb.cm/tmplt-launchpad Drupal

    - http://lb.cm/tmplt-drupal Symfony - http://lb.cm/tmplt-symfony

  12. Use Checklists to Ensure You’re Meeting Standards http://drupal.org/core-gates

  13. Internal Checklists http://gitforteams.com/resources/review-process.html

  14. Provide excellent feedback.

  15. Good Feedback is Usable • Limit it to the scope

    of the work. • Make it actionable. • Make it specific. • Do it as soon as possible. • Acknowledge effort and give thanks.

  16. Bad Feedback
 is Destructive

  17. Summary • Implementing code reviews at work can initially cause

    more tension. • Code reviews will improve the skills of everyone on the team — communication and coding. • Consider the types of review, and work towards implementing the right feedback at the right time. • Co-create checklists for the review process. • Provide excellent, actionable feedback.

  18. Peer Code Review Resources http://lb.cm/ala-code-reviews http://lb.cm/review-process www.gitforteams.com @emmajanehw