Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Peer Code Reviews

A298fade27a9c2ebe7bea8f93997b5c6?s=47 Emma Jane Hogbin Westby
February 20, 2015
Technology
2
430

Peer Code Reviews

Nearly all open source projects have some form of peer review system. In this session you will learn the pros (and cons) of adopting a peer review system in-house. To illustrate how this unfolded in the real world, a case study will be used. We'll talk about the overall setup, the impact on the team, and give you tips on how to conduct a good peer review.

A298fade27a9c2ebe7bea8f93997b5c6?s=128

Emma Jane Hogbin Westby

February 20, 2015
Tweet

More Decks by Emma Jane Hogbin Westby

See All by Emma Jane Hogbin Westby
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
63
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
66
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
1
170
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
5
410
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
76
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
150
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
130
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
99
A298fade27a9c2ebe7bea8f93997b5c6?s=48 emmajane
0
260

Other Decks in Technology

See All in Technology
8065fe5a0d33908c6f71c5ae28939dcd?s=48 ayatokura
0
240
872c040ebc1db6c2090d99dde729a8d4?s=48 supership
0
150
3115a782126be714b5f94d24073c957d?s=48 oracle4engineer
2
450
73dfdf58c8072916f1b4c62c93279fd7?s=48 yuzoiwasaki
0
160
439d941a6e41920af9bf4d5bd5f97e3a?s=48 nghialv
2
250
652359244199b2b5108a5e09c027e0da?s=48 ykanazawa
0
330
7b3e0dbc0d712ad5df602d9f9e5e4209?s=48 sei88888
5
400
7fb9a8ddaea2ddc368f12a5d08cea86a?s=48 yuu26
1
1k
525442fc70ca92f82ae503f826956137?s=48 finengine
0
300
2c76cf0e15f1410310b08e2ffa94db93?s=48 hanasuke
0
220
00101a1274d1f92977f4e442ef73be86?s=48 ahana
0
340
96de66872f54da75c05c881c7a3713ce?s=48 kenya888
1
100

Featured

See All Featured
91cefdf141106fa10674aae74ce05890?s=48 yeseniaperezcruz
302
31k
C0390e8b11079f8761c0cd3274ed61cb?s=48 productmarketing
6
770
Fe6b81005d1553accd6b2a28f6a2bef1?s=48 phodgson
88
4k
2f5463832ccb768ccb4a1ca3607c27ef?s=48 jacobian
257
20k
15f2b8221f247985a27a627d2ece72f0?s=48 pauljervisheath
195
15k
E43f8dfd01057f8304f5f8fb9a294d7d?s=48 jeffersonlam
330
15k
5b6a2bd86ef643786a381a212e0ef2f1?s=48 geoffreycrofte
25
1k
24fc194843a71f10949be18d5a692682?s=48 gr2m
83
11k
D09fad3e36ae6841f54820be0e907f7a?s=48 rocio
155
11k
C0b42577cfc2b321be3474618107e933?s=48 samanthasiow
57
6.4k
B3ace07412a5178ea778e7eec161fc0a?s=48 jcasabona
8
590
96270e4c3e5e9806cf7245475c00b275?s=48 addyosmani
1346
200k

Transcript

  1. Peer Code Reviews Emma Jane Hogbin Westby - Trillium Consultancy

    Ltd. www.gitforteams.com @emmajanehw

  2. “in a culture of optimism good honest criticism seems to

    be dying out” Tim Brown Tim Brown

  3. None

  4. Overview • Storytime! • Types of reviewers and types of

    reviews • Structuring the review process • Providing excellent feedback

  5. Storytime!

  6. Be intentional about your reviews.

  7. Not all reviews are the same. • Design crit •

    Technical architecture review • Automated self-check
 (coding standards; test suites) • Ticket-based peer code review • Quality Assurance / User Acceptance Testing

  8. Not all reviewers are the same. • Disinterested Reviewer •

    Peer Reviewer • Automated Gatekeeper • Consensus Shepherd • Benevolent Dictator

  9. Peer reviews are for everyone. Junior Coder Senior Coder Junior

    Reviewer • find bugs • compliance with coding standards • learn to read good code • suggest simplifications • exposure Senior Reviewer • suggest new techniques • improve architecture • improve architecture • cross-functional team (exposure)

  10. Use templates 
 and checklists.

  11. Use templates to structure the process. LaunchPad - http://lb.cm/tmplt-launchpad Drupal

    - http://lb.cm/tmplt-drupal Symfony - http://lb.cm/tmplt-symfony

  12. Use Checklists to Ensure You’re Meeting Standards http://drupal.org/core-gates

  13. Internal Checklists http://gitforteams.com/resources/review-process.html

  14. Provide excellent feedback.

  15. Good Feedback is Usable • Limit it to the scope

    of the work. • Make it actionable. • Make it specific. • Do it as soon as possible. • Acknowledge effort and give thanks.

  16. Bad Feedback
 is Destructive

  17. Summary • Implementing code reviews at work can initially cause

    more tension. • Code reviews will improve the skills of everyone on the team — communication and coding. • Consider the types of review, and work towards implementing the right feedback at the right time. • Co-create checklists for the review process. • Provide excellent, actionable feedback.

  18. Peer Code Review Resources http://lb.cm/ala-code-reviews http://lb.cm/review-process www.gitforteams.com @emmajanehw