初めてrails/railsにバグレポートを出してみた

初めてrails/rails にバグレポートを出したのでその流れをまとめました。

https://github.com/rails/rails/issues/49457

Transcript

1. גࣜձࣾλΠϛʔɹShintani Teppei ॳΊͯrails/railsʹ όάϨϙʔτΛग़ͯ͠Έͨ @euglena1215 Reject on Rails2023 @Gotanda
2. ࣗݾ঺հ ৽୩ ఩ฏʢ@euglena1215ʣ • גࣜձࣾλΠϛʔ • όοΫΤϯυΤϯδχΞ • ϦδΣΫτ͞Εͨϓϩϙʔβϧ ◦ ࠶ݱੑ͋Δ Rails ΞοϓάϨʔυ΁ͷಓ • εΠΧήʔϜ ϋΠείΞɿ3099 εΠΧΛ2ݸ࡞Δํ๏஌ͬͯΔํ͍ͨΒ
 #rejectonrailsΛ͚ͭͯڭ͍͑ͯͩ͘͞
4. એ఻ λΠϛʔ͸ Kaigi on Rails ΛԠԉ͍ͯ͠·͢ 🥈🥈🥈
5. גࣜձࣾλΠϛʔɹShintani Teppei ॳΊͯrails/railsʹ όάϨϙʔτΛग़ͯ͠Έͨ @euglena1215 Reject on Rails2023 @Gotanda
6. ൃදͷഎܠ • Rails͕ݪҼͬΆ͍όάʹૺ۰ͯ͠ॳΊͯrails/railsʹόάϨϙʔτΛग़ͨ͠ɻ • ͲΜͳྲྀΕͰૺ۰͠ɺௐࠪͯ͠όάϨϙʔτΛग़ͨ͠ͷ͔Λ
 ڞ༗͢Δ͜ͱͰrails/railsʹόάϨϙʔτΛग़͢͜ͱ΁ͷ
 ৺ཧతϋʔυϧΛԼ͍͛ͨɻ • rails/rails΁όάϨϙʔτΛग़ͨ͜͠ͱ͕ͳ͍ਓ޲͚ͷൃදͰ͢ɻ
7. ൃදΛฉ͘લ rails/rails΁ͷόάϨϙʔτ͸ ؤுͬͯ΋ग़͢ͷ೉ͦ͠͏...
8. ൃදΛฉ͍ͨޙ rails/rails΁ͷόάϨϙʔτ͸ ؤுͬͨΒग़ͤͦ͏ʂ
9. ໨࣍ 1. όάͱͷૺ۰ 2. ࠷খͷ࠶ݱํ๏ͷཱ֬ 3. όάϨϙʔτΛग़͢
10. 1 όάͱͷૺ۰
11. όάͱͷૺ۰ ʲલఏʳλΠϛʔͰ͸Railsͷmain branch Λ࢖ͬͨςετΛCIͰ࣮ߦ ͍ͯ͠·͢ɻ ઃఆํ๏͸ʮrails edgeʯͰݕࡧ 🔍
12. όάͱͷૺ۰ Rails 7.1.0.rc1 ͕ϦϦʔε͞ΕΔલ͸CI͕௨͍ͬͯͨ΋ͷͷɺϦϦʔε͞Ε͔ͯ Β͸શͯͷςετ͕ࣦഊ͢ΔΑ͏ʹɻ
 ͓΍ʁͱࢥ͍ௐࠪΛ։࢝ɻ
13. όάͷௐࠪ ελοΫτϨʔεΛோΊ͍ͯΔͱActiveAdminͷϖʔδΛ؅ཧ͢ΔσΟϨΫτϦͷ app/admin/* ͰΤϥʔʹͳ͍ͬͯΔ͜ͱ͕෼͔ͬͨɻ 
 ActiveAdmin ͸ϧʔςΟϯάΛࣗಈੜ੒͢ΔͨΊʹ app/admin/* ΛಡΈࠐΈ࣌ʹධՁ ͍ͯ͠ΔɻධՁ࣌ʹಛఆϞσϧΛಡΈࠐΜͩλΠϛϯάͰΤϥʔʹͳ͍ͬͯΔ͜ͱ͕ ൑໌ɻ
14. όάͷௐࠪ ελοΫτϨʔεΛோΊ͍ͯΔͱ app/admin/* (ActiveAdminͷϖʔδ Λ؅ཧ͢ΔσΟϨΫτϦ) ͰΤϥʔʹͳ͍ͬͯΔ͜ͱ͕෼͔ͬͨɻ
 ActiveAdmin ͸ϧʔςΟϯάΛࣗಈੜ੒͢ΔͨΊʹ app/admin/* Λಡ ΈࠐΈ࣌ʹධՁ͍ͯ͠ΔɻධՁ࣌ʹಛఆΛϞσϧΛಡΈࠐΜͩλΠϛ ϯάͰΤϥʔʹͳ͍ͬͯΔ͜ͱ͕൑໌ɻ ActiveRecordͷvalidateϝιουʹpresenceΦϓγϣϯΛ౉ͯ͠Δͱ ղऍ͞Εͯͦ͏🤔 ͦΜͳ࣮૷͸Ͳ͜ʹ΋ͳ͍͸ͣ...ʁ
15. 2 ࠷খͷ࠶ݱํ๏ͷཱ֬
16. 1. ActiveAdminͱ੾Γ཭͢ ݱঢ়͸ಡΈࠐΈ࣌ʹࣦഊ͢ΔͷͰ rails c ΋ىಈ͠ͳ͍ঢ়ଶɻ ActiveAdmin ͕ѱ͍ͷ͔ɺActiveAdmin ͸ಡΈࠐΜͰΔ͚ͩͰͦͷଞ͕ ѱ͍ͷ͔۠ผͰ͖ͳ͔ͬͨͷͰ੾Γ཭͢ํ๏Λߟ͑ͨɻ
17. 1. ActiveAdminͱ੾Γ཭͢ ݱঢ়͸ಡΈࠐΈ࣌ʹࣦഊ͢ΔͷͰ rails c ΋ىಈ͠ͳ͍ঢ়ଶɻ ActiveAdmin ͕ѱ͍ͷ͔ɺActiveAdmin ͸ಡΈࠐΜͰΔ͚ͩͰͦͷଞ͕ ѱ͍ͷ͔۠ผͰ͖ͳ͔ͬͨͷͰ੾Γ཭͢ํ๏Λߟ͑ͨɻ ରॲɿapp/admin/* Λશ෦࡟আ͢Δ ✂
18. 1. ActiveAdminͱ੾Γ཭͢ ݱঢ়͸ಡΈࠐΈ࣌ʹࣦഊ͢ΔͷͰ rails c ΋ىಈ͠ͳ͍ঢ়ଶɻ ActiveAdmin ͕ѱ͍ͷ͔ɺActiveAdmin ͸ಡΈࠐΜͰΔ͚ͩͰͦͷଞ͕ ѱ͍ͷ͔۠ผͰ͖ͳ͔ͬͨͷͰ੾Γ཭͢ํ๏Λߟ͑ͨɻ ରॲɿapp/admin/* Λશ෦࡟আ͢Δ ✂ ݁Ռɿ
 ಡΈࠐΈ࣌ʹࣦഊ͢Δ͜ͱ͸ͳ͘ͳͬͯ rails c ͸ىಈ͢ΔΑ͏ʹ 🎉
19. 1. ActiveAdminͱ੾Γ཭͢ rails c Ͱ֘౰ϞσϧΛධՁ͢Δ͜ͱͰΤϥʔΛىͤ͜ΔΑ͏ʹɻ
 ActiveAdmin͸ແ࣮ͩͬͨ͜ͱ͕෼͔ͬͨɻ
20. 2. ໰୊͕ى͖͍ͯΔΫϥεΛখ͘͢͞Δ ໰୊͕ى͖͍ͯΔϞσϧͱ֘౰ߦ͸ಛఆͰ͖ͨ΋ͷͷɺ໰୊͕ى͖ͯ ͍ͨΫϥε͸࣮૷͕ଟ͘Կ͕ݪҼͳͷ͔൑அͰ͖ͣɻ
21. 2. ໰୊͕ى͖͍ͯΔΫϥεΛখ͘͢͞Δ ໰୊͕ى͖͍ͯΔϞσϧͱ֘౰ߦ͸ಛఆͰ͖ͨ΋ͷͷɺ໰୊͕ى͖ͯ ͍ͨΫϥε͸࣮૷͕ଟ͘Կ͕ݪҼͳͷ͔൑அͰ͖ͣɻ ରॲɿ֘౰Ϟσϧͷ࣮૷Λยͬ୺͔Β࡟আ͢Δ ✂
22. 2. ໰୊͕ى͖͍ͯΔΫϥεΛখ͘͢͞Δ ໰୊͕ى͖͍ͯΔϞσϧͱ֘౰ߦ͸ಛఆͰ͖ͨ΋ͷͷɺ໰୊͕ى͖ͯ ͍ͨΫϥε͸࣮૷͕ଟ͘Կ͕ݪҼͳͷ͔൑அͰ͖ͣɻ ରॲɿ֘౰Ϟσϧͷ࣮૷Λยͬ୺͔Β࡟আ͢Δ ✂ ݁Ռɿ
 ໰୊͕ى͖͍ͯͨߦΛғΉ with_options ϒϩοΫҎ֎શͯͷ࣮૷Λ
 ফͯ͠΋໰୊͸࠶ݱͨ͠ͷͰ with_options ͕ո͍͜͠ͱ͕෼͔ͬͨ 🎉
23. 2. ໰୊͕ى͖͍ͯΔΫϥεΛখ͘͢͞Δ ໰୊͕ى͖͍ͯΔϞσϧͱ֘౰ߦ͸ಛఆͰ͖ͨ΋ͷͷɺ໰୊͕ى͖ͯ ͍ͨΫϥε͸࣮૷͕ଟ͘Կ͕ݪҼͳͷ͔൑அͰ͖ͣɻ ରॲɿ֘౰Ϟσϧͷ࣮૷Λยͬ୺͔Β࡟আ͢Δ ✂ ݁Ռɿ
 ໰୊͕ى͖͍ͯͨߦΛғΉ with_options Ҏ֎શͯͷ࣮૷Λফͯ͠΋໰୊͸࠶ݱͨ͠ ͷͰ with_options ͕ո͍͜͠ͱ͕෼͔ͬͨ 🎉
24. 2. ໰୊͕ى͖͍ͯΔΫϥεΛখ͘͢͞Δ ໰୊͕ى͖͍ͯΔϞσϧͱ֘౰ߦ͸ಛఆͰ͖ͨ΋ͷͷɺ໰୊͕ى͖ͯ ͍ͨΫϥε͸࣮૷͕ଟ͘Կ͕ݪҼͳͷ͔൑அͰ͖ͣɻ ରॲɿ֘౰Ϟσϧͷ࣮૷Λยͬ୺͔Β࡟আ͢Δ ✂ ݁Ռɿ
 ໰୊͕ى͖͍ͯͨߦΛғΉ with_options Ҏ֎શͯͷ࣮૷Λফͯ͠΋໰୊͸࠶ݱͨ͠ ͷͰ with_options ͕ո͍͜͠ͱ͕෼͔ͬͨ 🎉 ͖ͪΜͱ validates ϝιουʹ presence ΦϓγϣϯΛ౉͍ͯ͠Δͷʹ validate ϝιουʹ౉ͨ͜͠ͱʹͳ͍ͬͯΔɻԿ͕ى͖͍ͯΔΜͩ...
25. 3. 1ϑΝΠϧͷ࠶ݱεΫϦϓτͰ࠶ݱ͢Δ͔Λ֬ೝ with_options ͷϒϩοΫҎ֎ͷϞσϧͷ࣮૷Λશͯ࡟আͯ͠΋
 Τϥʔ͸ܧଓͯ͠ൃੜ͍ͯ͠Δɻ ͜Εͩͱશͯͷ Rails ΞϓϦέʔγϣϯͰൃੜ͢ΔՄೳੑ͋ΔͷͰ ͸ʁͱࢥ͍ɺ࠷΋γϯϓϧͳܗͰ໰୊͕࠶ݱ͢Δ͔֬ೝ͢Δ͜ͱʹɻ
26. 3. 1ϑΝΠϧͷ࠶ݱεΫϦϓτͰ࠶ݱ͢Δ͔Λ֬ೝ rails/railsʹ͸ActiveRecordͷόάΛใࠂ͢ΔͨΊʹ1ϑΝΠϧͰ ActiveRecordͷςετΛ࣮ߦ͢ΔςϯϓϨʔτ͕͋Δɻ https://github.com/rails/rails/blob/main/guides/bug_report_templates/ active_record_main.rb
28. 1. Gemfile
29. 2. DBεΩʔϚ
30. 3. Ϟσϧ
31. 4. ςετ
32. 3. 1ϑΝΠϧͷ࠶ݱεΫϦϓτͰ࠶ݱ͢Δ͔Λ֬ೝ ରॲɿςϯϓϨʔτͷϞσϧͷఆٛʹ with_options Λ௥Ճ͠ɺRails όʔδϣϯΛ 7.1.0.rc1 ʹࢦఆͯ͠Τϥʔ͕ൃੜ͢Δ͔Λ֬ೝɻ
33. with_options Λ௥Ճ͢Δɿมߋલ
34. with_options Λ௥Ճ͢Δɿมߋޙ
35. 3. 1ϑΝΠϧͷ࠶ݱεΫϦϓτͰ࠶ݱ͢Δ͔Λ֬ೝ ରॲɿςϯϓϨʔτͷϞσϧͷఆٛʹ with_options Λ௥Ճ͠ɺRails όʔδϣϯΛ 7.1.0.rc1 ʹࢦఆͯ͠Τϥʔ͕ൃੜ͢Δ͔Λ֬ೝɻ ݁ՌɿಡΈࠐΈ࣌ʹΤϥʔ͸ൃੜͤͣ 😢
36. 3. 1ϑΝΠϧͷ࠶ݱεΫϦϓτͰ࠶ݱ͢Δ͔Λ֬ೝ ରॲɿςϯϓϨʔτͷϞσϧͷఆٛʹ with_options Λ௥Ճ͠ɺRails όʔδϣϯΛ 7.1.0.rc1 ʹࢦఆͯ͠Τϥʔ͕ൃੜ͢Δ͔Λ֬ೝɻ ݁ՌɿಡΈࠐΈ࣌ʹΤϥʔ͸ൃੜͤͣ 😢 ଞʹԿ͔ݟམͱͯ͠ΔཁҼ͕͋Γͦ͏ 🤔
37. 4. ݟམͱ͍ͯ͠ΔཁҼΛߟ͑Δ
38. 4. ݟམͱ͍ͯ͠ΔཁҼΛߟ͑Δ Ұݟ͢ΔͱӨڹΛ༩͑ͯͳͦ͞͏͚ͩͲɺڍಈʹӨڹΛ༩͑ͦ͏ͳ
 ΋ͷͬͯͳΜͩΖ͏ʁ
39. 4. ݟམͱ͍ͯ͠ΔཁҼΛߟ͑Δ Ұݟ͢ΔͱӨڹΛ༩͑ͯͳͦ͞͏͚ͩͲɺڍಈʹӨڹΛ༩͑ͦ͏ͳ
 ΋ͷͬͯͳΜͩΖ͏ʁ ܦݧ্ͦ͏͍ͬͨ͜ͱΛ͢Δͷ͸͍͍ͩͨGemɻ
40. 4. ݟམͱ͍ͯ͠ΔཁҼΛߟ͑Δ Ұݟ͢ΔͱӨڹΛ༩͑ͯͳͦ͞͏͚ͩͲɺڍಈʹӨڹΛ༩͑ͦ͏ͳ
 ΋ͷͬͯͳΜͩΖ͏ʁ ܦݧ্ͦ͏͍ͬͨ͜ͱΛ͢Δͷ͸͍͍ͩͨGemɻ ରॲɿGemfileʹએݴ͞Ε͍ͯΔGemΛยͬ୺͔Βফ͍ͯ͘͠ ✂
41. 4. ݟམͱ͍ͯ͠ΔཁҼΛߟ͑Δ Ұݟ͢ΔͱӨڹΛ༩͑ͯͳͦ͞͏͚ͩͲɺڍಈʹӨڹΛ༩͑ͦ͏ͳ
 ΋ͷͬͯͳΜͩΖ͏ʁ ܦݧ্ͦ͏͍ͬͨ͜ͱΛ͢Δͷ͸͍͍ͩͨGemɻ ରॲɿGemfileʹએݴ͞Ε͍ͯΔGemΛยͬ୺͔Βফ͍ͯ͘͠ ✂ ݁Ռɿ
 ੎͍Α͘ফ͍ͯ͠Δͱ໰୊͕࠶ݱ͠ͳ͘ͳΔλΠϛϯάʹૺ۰ 🎉🎉
42. 4. ݟམͱ͍ͯ͠ΔཁҼΛߟ͑Δ Ұݟ͢ΔͱӨڹΛ༩͑ͯͳͦ͞͏͚ͩͲɺڍಈʹӨڹΛ༩͑ͦ͏ͳ
 ΋ͷͬͯͳΜͩΖ͏ʁ ܦݧ্ͦ͏͍ͬͨ͜ͱΛ͢Δͷ͸͍͍ͩͨGemɻ ରॲɿGemfileʹએݴ͞Ε͍ͯΔGemΛยͬ୺͔Βফ͍ͯ͘͠ ✂ ݁Ռɿ
 ੎͍Α͘ফ͍ͯ͠Δͱ໰୊͕࠶ݱ͠ͳ͘ͳΔλΠϛϯάʹૺ۰ 🎉🎉 → config gemΛফ͢ͱ໰୊͕࠶ݱ͠ͳ͘ͳΔ͜ͱ͕෼͔ͬͨ 💯
43. 5. ࠶ݱεΫϦϓτͰ࠶ݱ͢Δ͔νΣοΫ͢Δ config gemͷ༗ແͰ໰୊͕ى͖Δ͜ͱ͕෼͔ͬͨͷͰ3.Ͱ༻ҙͨ͠࠶ ݱεΫϦϓτΛ࢖ͬͯ໰୊͕࠶ݱ͢Δ͔ͷνΣοΫ͢Δɻ
44. config gemΛ௥Ճ͢Δɿมߋલ
45. config gemΛ௥Ճ͢Δɿมߋޙ
46. config gemΛ௥Ճ͢Δɿมߋޙ ແࣄΤϥʔ͕ൃੜ 💥 ࠷খͷ࠶ݱํ๏ͷཱ֬ʹ੒ޭʂ
47. 3 όάϨϙʔτΛग़͢
48. όάϨϙʔτΛग़͢ config gemͷґଘʹΑΔ໰୊Ͱ͋Δ͜ͱ͸෼͔ͬͨ΋ͷͷɺRailsͷ໰ ୊ͳͷ͔config gemͷ໰୊ͳͷ͔ͷ੾Γ෼͚͕Ͱ͖ͳ͔ͬͨɻ
 ͳͷͰRailsʹৄ͍͠ਓʹฉ͚͹൑அͰ͖ΔͩΖ͏ͱࢥ͍ɺrails/rails ʹόάϨϙʔτΛग़͢͜ͱʹɻ
49. όάϨϙʔτΛग़͢ rails/railsͷόάϨϙʔτʹඞཁͳ߲໨ • ࠶ݱεΫϦϓτ • ظ଴͢Δڍಈ • ࣮ࡍͷڍಈ • Ruby/Railsͷόʔδϣϯ
50. όάϨϙʔτΛग़͢ rails/railsͷόάϨϙʔτʹඞཁͳ߲໨ • ࠶ݱεΫϦϓτ • ظ଴͢Δڍಈ • ࣮ࡍͷڍಈ • Ruby/Railsͷόʔδϣϯ ࠶ݱεΫϦϓτ͑͋͞Ε͹͋ͱ͸͙͢ʹຒΊΒΕΔɻ
 ӳޠͰڍಈΛ఻͑ͳ͍͍ͯ͘ͷ͕خ͍͠ϙΠϯτ 🤝
51. όάϨϙʔτΛग़͢ ग़ͯ͠Έͨ https://github.com/rails/rails/issues/49457
52. όάϨϙʔτ΁ͷ൓Ԡ issueΛ࡞੒ޙ30෼΄ͲͰݪҼΛಛఆͨ͠ࢫͷίϝϯτΛ΋Β͍ config gemଆͷमਖ਼͕ඞཁͳ͜ͱ͕൑໌ɻ 4࣌ؒ΄ͲͰconfig gemʹमਖ਼Pull RequestΛ࡞੒ͯ͠΋Βͬͨ 🎉
53. όάϨϙʔτ΁ͷ൓Ԡ ॾࣄ৘ʹΑΓमਖ਼Pull Request͸·ͩmerge͞Ε͍ͯͳ͍ͷͰɺ
 config gemΛRails 7.1Ͱಈ͔͍ͨ͠ํ͸࠙਌ձͰํ਑Λ૬ஊͤͯ͘͞ ͍ͩ͞ 🙏
54. ·ͱΊ 1. Rails EdgeͰͷςετΛCIͰ࣮ߦ͍ͯͨ͜͠ͱʹΑΓɺյΕ͍ͯ Δ͜ͱʹؾ෇͘ɻ 2. ৭ΜͳϑΝΠϧΛফ͠ͳ͕Β࠷খͰͷ࠶ݱํ๏Λཱ֬͠ɺݪҼͱ ͳΔGemΛಛఆɻ 3. όάϨϙʔτΛग़ͯ͠30෼ޙʹ͸ݪҼ͕ಛఆ͞Ε4࣌ؒޙʹ͸मਖ਼ PR͕࡞ΒΕεϐʔυղܾ 🚀ʢະϚʔδʣ
55. ͓ΘΓ rails/rails΁ͷόάϨϙʔτ͸ ؤுͬͨΒग़ͤͦ͏ʂ