自作PHPライブラリをリファクタリングした / Refactoring library

社内勉強会で発表したスライドです。

ライブラリ: https://github.com/howyi/conv

Transcript

1. ࣗ࡞1)1ϥΠϒϥϦΛϦϑΝΫλϦϯάͨ͠
   
   IPXZJ
   
2. ԿͷϥΠϒϥϦΛϦϑΝΫλϦϯά͔ͨ͠ https://github.com/howyi/conv ϚΠάϨʔγϣϯΫΤϦࣗಈੜ੒ϥΠϒϥϦ
3. ԿނϦϑΝΫλ͔ͨ͠ • MySQL5.7ʹରԠ͢Δ͜ͱʹͳͬͨ • MySQL5.6લఏͷΫΤϦੜ੒ͩͬͨͨΊɺ5.7ݻ༗ػೳ͕ೖΕΒΕͳ͔ͬͨ • मਖ਼͠Α͏ͱࢥͬͨΒࠜຊ͔Β௚͞ͳ͍ͱ͍͚ͳ͔ͬͨ ͍ͭͰ͔ͩΒ৭ʑ௚ͦ͏
4. ΍ͬͨ͜ͱ
5. namespaceͷมߋ • ϕϯμ໊ΛؚΊΔΑ͏ʹͨ͠ Conv/Hoge -> Howyi/Conv/Hoge • composer.jsonͰͷΦʔτϩʔμن໿͕PSR-0ͩͬͨͷͰɺPSR-4ʹͨ͠
6. phpcsͷಋೖ • PSR12 • ద౰ʹॻ͖͗ͯͨ͢ͷͰमਖ਼͕େมͩͬͨ
7. makefileΛফͨ͠ composer scriptʹมߋʢ͔ͤͬ͘composerଆʹػೳ͕͋ΔͷͰʣ test: @vendor/bin/phpunit stan: @vendor/bin/phpstan analyse -l 7 -c phpstan.neon src "scripts": { "test": "phpunit", "stan": "phpstan analyse -l 7 src", } Makefile $ make test $ make stan composer.json $ composer test $ composer stan
8. ςετ༻SQLΛผϦϙδτϦʹ੾Γग़͠ • ৭ʑͳύλʔϯͷSQLΛ༻ҙ͢Δඞཁ͕͋ΔͨΊɺςετ༻SQL͕ଟ͍ • composer require ~ Ͱ͜ͷςετ༻SQL·ͰΞϓϦʹ૊Έࠐ·ΕΔͷ͸ͳΜͱͳ͘ؾ࣋ͪѱ͍ • packagistʹ͸্͛ͣɺcomposer.jsonͰผϦϙδτϦΛࢦఆ͠ɺrequire-dev͍ͯ͠Δ "repositories": [ { "type": "vcs", "url": "https://github.com/howyi/conv-test-suite.git", "no-api": true } ],
9. ෳ਺όʔδϣϯDBʹରԠͰ͖ΔΑ͏ߏ଄ͷมߋ ۩ମతʹ͸ Structure͕ʮσʔλϕʔεͷදݱʯʮΫΤϦൃߦʯ ͷ2ͭͷ໾໨Λ͍࣋ͬͯͨͷͰ ɺ ʮΫΤϦൃߦʯΛDriverΫϥεʢ৽نʣͷ໾໨ʹมߋͨ͠ DriverΫϥε͸DBͷόʔδϣϯʹΑͬͯ੾Γସ͑ΒΕΔ
10. ෳ਺όʔδϣϯDBʹରԠͨ͠ςετ؀ڥ • docker-composeͰରԠόʔδϣϯͷ ίϯςφΛཱͯΔ • phpunitͰɺෳ਺DBʹରͯ͠ಉ͡ςε τΛ࣮ߦͰ͖ΔΑ͏ʹ • docker-compose upͰDBߏங+ςετ ࣮ߦ·Ͱߦ͏
11. ෳ਺όʔδϣϯDBʹରԠͨ͠CI؀ڥ ରԠલͱେ͖ͳҧ͍͸ͳ͘ɺมΘͬͨ෦෼͸ ʮTravisCI͕docker-composeͰςετΛ࣮ߦ͢Δ༻ʹͳͬͨʯͷΈ TravisCIͰಈ͘ίϯςφ಺෦͔Βcoverallsʹ௚઀ΧόϨοδΛ౤͍͛ͯΔ
12. ͓ΘΓ Photo by 1.Shane Stagner on Unsplash 12.Viviana Rishe on Unsplash