RuboCop in 2021: Stable and Beyond

3VCP$PQJO 4UBCMFBOE#FZPOE ,PJDIJ*50&4. *OD 3VCZ,BJHJ5BLFPVU Next step toward RuboCop 2.0
5IV

!LPJD w 044QSPHSBNNFS w 3VCP$PQDPSFUFBN w )FBENBJOUBJOFSPG3VCP$PQ3BJMT 3VCP$PQ1FSGPSNBODF BOE
3VCP$PQ.JOJUFTU w &OHJOFFSJOH.BOBHFSBOE %JTUJOHVJTIFE&OHJOFFSPG&4. *OD

3VCP$PQDPSFEFWFMPQFST +0900 UTC+0200 +0300 +0800 -0400 .PSFUIBODPOUSJCVUPSTJOZFBST

3VCP$PQDPSFEFWFMPQFST +0900 UTC+0200 +0300 +0800 -0400 .PSFUIBODPOUSJCVUPSTJOZFBST "VUIPS

3VCP$PQDPSFEFWFMPQFST +0900 UTC+0200 +0300 +0800 -0400 .PSFUIBODPOUSJCVUPSTJOZFBST .F

.BJOUBJO3VCP$PQ)2&WFSZ%BZ IUUQTHJUIVCDPNLPJD PSHSVCPDPQ

(JU)VC4QPOTPST

&4. *OD

%BZ SVCZLBJHJ# %BZ SVCZLBJHJ# 4QFBLFSTGSPN&4. *OD

-BTUSFMFBTFCFGPSF 🤔

/VNCFSPGEPXOMPBET

#FOFpUTPGVQHSBEJOHUP UIF3VCP$PQW

3VCP$PQJO 4UBCMFBOE#FZPOE ,PJDIJ*50&4. *OD 3VCZ,BJHJ5BLFPVU Next step toward RuboCop 2.0
5IV

4UBCMF #FZPOE

4UBCMF

5IFXPSMEBGUFS3VCP$PQ 1BSU

w WYDBVTFECSFBLJOHDIBOHFTBOE VOLOPXOXBSOJOHTEVFUPTVEEFO SFOBNJOHDPQOBNFTBOEOFXSVMFT w WYEPFTOPUDIBOHFDPQOBNFT w "MMPGOFXDPQTBSFQFOEJOHCZ EFGBVMU WIBTJOUFSGBDFDPNQBUJCJMJUZ
CFUXFFOSFMFBTFT

w %POUBEEOFXDPEJOHSVMFTBT 3VCP$PQEPFTOULOPXXIFUIFS OFXDPQTXJMMNBUDIZPVSUBTUF w /FXDPQTPDDBTJPOBMMZIBWFCVHT💦 3FEVDFVQHSBEFQBJO

w %POUBEEOFXDPEJOHSVMFTBT 3VCP$PQEPFTOULOPXXIFUIFS OFXDPQTXJMMNBUDIZPVSUBTUF w /FXDPQTPDDBTJPOBMMZIBWFCVHT💦 3FEVDFVQHSBEFQBJO 👉:PVDBODIPPTFXIFUIFSFOBCMFEPS EJTBCMFEGPSWNJOPSWFSTJPOVQHSBEF

/FXDPQTBSFQFOEJOHCZEFGBVMUVOUJM gem 'rubocop', '~> 1.19', require: false gem 'rubocop', '~>
0.78.0', require: false w/POFFEUPTQFDJGZUIFQBUDI WFSTJPOJO(FNpMFXIFOVTJOH~> WY WY

*GZPVBSFFBSMZBEPQUFS ZPVDBOFOBCMFQFOEJOHDPQT &OBCMFOFXDPQT % bundle exec rubocop The following cops
were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file. Please also note that you can opt-in to new cops by default by adding this to your config: AllCops: NewCops: enable Gemspec/DateAssignment: # (new in 1.10) Enabled: true Layout/LineEndStringConcatenationIndentation: # (new in 1.18) Enabled: true Layout/SpaceBeforeBrackets: # (new in 1.7) Enabled: true Lint/AmbiguousAssignment: # (new in 1.7) Enabled: true

w 4FUEnabledUPFJUIFStruePSfalseJOZPVS SVCPDPQZNM w :PVDBODIPPTFFOBCMFOFXDPQTCZ EFGBVMUJGZPVXBOUJUNewCops: enable UPSVCPDPQZNM w 0S
EJTBCMFOFXDPQTCZEFGBVMUJGZPV EPOUXBOUJUNewCops: disable &OBCMFOFXDPQT

w /FXGFBUVSFTXJUICBDLXBSE DPNQBUJCJMJUZ w 3VCZOFXTZOUBYTVQQPSU w #FUUFSQFSGPSNBODF w #VHpYFT 8IBUZPVDBOHFUXJUIVQHSBEF💎

w"EEFE DPQBVUP DPSSFDUJPOTTJODF w'PSFYBNQMF NPTUPGlayout EFQBSUNFOUDPQTDBOOPX BVUPDPSSFDUPGGFOTFT .PSFBVUPDPSSFDUJPOT

)PXUPJOWFTUJHBUF % cd path/to/rubocop % bin/console RuboCop::Cop::Registry.global. with_department(:Layout). reject(&:support_autocorrect?)

)PXUPJOWFTUJHBUF % cd path/to/rubocop % bin/console RuboCop::Cop::Registry.global. with_department(:Layout). reject(&:support_autocorrect?) =>
[RuboCop::Cop::Layout::EndOfLine]

8IZOPUTVQQPSUFE % cd path/to/rubocop % bin/console RuboCop::Cop::Registry.global. with_department(:Layout). reject(&:support_autocorrect?) =>
[RuboCop::Cop::Layout::EndOfLine] *EPOUIBWF8JOEPXT🤦

w4BGFBVUPDPSSFDUJPOUIBUEPOPUDIBOHF TFNBOUJDT FHLayoutEFQBSUNFOU w6OTBGFBVUPDPSSFDUJPOUIBUNBZDIBOHF TFNBOUJDTPSMPHJD FHUZQFPGSFUVSOWBMVF w$BOOPUCFBVUPDPSSFDUJPO WBSJBCMFOBNF
EPDVNFOU BOEFUD 5ZQFPGBVUPDPSSFDUJPOT

w-APQUJPOBQQMJFTTBGFBOEVOTBGFBVUP DPSSFDUJPO FHStyle/FrozenStringLiteralComment w5IJTPQUJPOJTUIFTBNF-aCFIBWJPSPG 3VCP$PQBOEMPXFS w-JLFgit branch -dWT-D <'"2>-A,
--auto-correct-all

3VCZOFXTZOUBY w1BUUFSONBUDIJOH /VNCFSFEQBSBNFUFST &OEMFTT NFUIPEEFpOJUJPO BOEFUD w"TBUSJWJBGPSDPQEFWFMPQFST UIFPOFMJOFQBUUFSO NBUDIJOHTZOUBY"45EJGGFSTCFUXFFOBOE In
Ruby 2.7(Parser::Ruby27) SVCZQBSTFFJOGPP NBUDIQBUUFSO JOU NBUDIWBSGPP SVCZQBSTFFGPP NBUDIQBUUFSO JOU NBUDIWBSGPP SVCZQBSTFFJOGPP NBUDIQBUUFSOQ JOU NBUDIWBSGPP In Ruby 3.0(Parser::Ruby30) ruby-parseDPNNBOEJTQSPWJEFECZ1BSTFSHFN

w--parallelPQUJPOGPSQBSBMMFM QSPDFTTJOHVTJOH1BSBMMFMHFN w.PEFSO1$TIBWFCFUUFS1$SFTPVSDFT NVMUJDPSFT IVHFNFNPSZ BOEFUD w#ZEFGBVMU QBSBMMFMQSPDFTTJOHJT FOBCMFEFYDFQUGPS8JOEPXTBOE+3VCZ
1FSGPSNBODF

SVCPDPQSVCPDPQ 1BSBMMFMTUBUJDBOBMZTJTCZEFGBVMU

DPSF$16T )ZQFS5ISFBEJOH TFD OPQBSBMMFM QBSBMMFM
w8IFO3VCP$PQ JOTQFDUTBMPUPG pMFT JUXJMMCF FGGFDUJWF wFHTFDTFD BCPVUpMFT

3BOLJOHDPQTCZQFSGPSNBODF NFNPSZ@QSPpMFS BOE4UBDL1SPG DPOUSJCVUFUP SFNBSLBCMZTMPX DPQTQFSGPSNBODF JNQSPWFNFOU

w3VCZTUBUJDBOBMZTJTXJUIPVUTUBUJDUZQJOH TUSVHHMJOHBHBJOTUGBMTFQPTJUJWFTBOE GBMTFOFHBUJWFT w"VUPDPSSFDUFEDPEFNBZUSJHHFS VOFYQFDUFECFIBWJPST TPJGZPVDPNF BDSPTTBDBTFUIBUZPVUIJOLJTTUSBOHF TUPQBOESFWJFXJUBHBJO #VHpYFT

SVCPDPQSVCPDPQ $IBOHFFOGPSDFETUZMFUPDPOEJUJPOBMTGPS4UZMF"OE0S

#VHpYFT w*OUIFQBTU 3VCP$PQTVHHFTUFEUPDIBOHF expr and returnUPexpr && returnCZEFGBVMU w*UMPPLFEXFJSE TP*DIBOHFEUIFDPOpHVSBUJPO
UPBDDFQUexpr and returnCZEFGBVMU 6TF `and return` % ruby -e \ 'p false || true and return' # => true # p(false || true) and return % ruby -e \ 'p false || true && return' # noop # p(false || (true && return)) 6TF `&& return`

w /FXGFBUVSFTXJUICBDLXBSE DPNQBUJCJMJUZ w 3VCZOFXTZOUBYTVQQPSU w #FUUFSQFSGPSNBODF w #VHpYFT 8IBUZPVDBOHFUXJUIVQHSBEF💎<BHBJO>

3VCP$PQJTBTUBUJDBOBMZTJT UPPM*GZPVXBOUUPXSJUFB QBUDIJO3VCP$PQ ZPVTIPVME LFFQJONJOEUIBUEZOBNJD BOBMZTJTJTOPUBWBJMBCMF

3FTUSJDUJPOPGTUBUJDBOBMZTJT XJUIPVUTUBUJDUZQJOH 1BSU

w 3VCZIBTOPTUBUJDUZQJOH w /PUZQFJOGPSNBUJPOGPSWBSJBCMFT BSHVNFOUT SFUVSOWBMVFT XJUIPVU3#4 w
Safe: falseJTTFUJODBTFTXIFSFGBMTF QPTJUJWFTDBOOPUCFQSFWFOUFE w "WPJESafe: falseBTNVDIBTQPTTJCMF BOE EFTJHODPQTDBSFGVMMZOPUUPDBVTFGBMTF QPTJUJWFT 3VCP$PQJTBTUBUJDBOBMZ[FS

SBJMTSBJMT 5XFBLVOSFBDIBCMFBTTFSUJPOUFTUTJOUIFCMPDLPGABTTFSU@SBJTFTA

SVCPDPQSVCPDPQNJOJUFTU <'JY>"EEOFX.JOJUFTU6OSFBDIBCMF"TTFSUJPODPQ

&YBNQMF IUUQTEPDTSVCPDPQPSHSVCPDPQNJOJUFTUDPQT@NJOJUFTUIUNMNJOJUFTUVOSFBDIBCMFBTTFSUJPO

)PXEJE*SFTPMWFUIFJTTVF UIBU3VCP$PQJTOPUBCMFUP EFUFDUUIFMPDBUJPOXIFSF FYDFQUJPOTPDDVSSFE 🤔

w "TTFSUJPONFUIPEOPUVTFEJO assert_raises w *OPUIFSXPSET HPPEDBTF 5SVFOFHBUJWF EFpOJUFMZ assert_raises FooError
do do_something('foo', obj.bar) end "TTFSUJPONFUIPEOPUVTFE

assert_raises FooError do obj.foo assert_equal('foo', obj.bar) end w "OBTTFSUJPONFUIPE FHassert_equal
JT DBMMFEBUUIFCPUUPNPGassert_raisesCMPDL w 5IFSFGPSF OPUBTTFSUFEJUCFDBVTFBO FYDFQUJPOTIPVMEIBWFPDDVSSFE TPNFXIFSFCFGPSF 5SVFQPTJUJWF EFpOJUFMZ assert_equalJTOFWFSDBMMFE assert_raises FooError do obj.foo assert_equal('foo', obj.bar) end %PFTfooSBJTFBOFYDFQUJPO 0S EPFTbarSBJTFBOFYDFQUJPO assert_equalJTOFWFSDBMMFECFDBVTFUIFNFUIPEJTFWBMVBUFEMBTU

w GBMTFQPTJUJWFJGOPFYDFQUJPO PDDVSTJOobj.foo w USVFQPTJUJWFJGBOFYDFQUJPO PDDVSTJOobj.foo $POTFSWBUJWFEFTJHO assert_raises FooError do
assert_equal('foo', obj.foo) obj.bar end *GJUEPFTOUSBJTFTIFSF JUTBGBMTFQPTJUJWF *GJUSBJTFTIFSF JUTBUSVFQPTJUJWF RuboCop don't know if it's a false positive or not

w *GUIFMBTUNFUIPEDBMMFEJTBOBTTFSUJPO NFUIPE UIFSFTIPVMECFBOFYDFQUJPOJO UIFQSFWJPVTNFUIPEDBMM /FWFSSFBDIFE w 'BMTFOFHBUJWFTBDDFQUFE w
1SFWFOUCSFBLJOHDPEFCZGBMTFQPTJUJWFT w /PUFTUDPEFQSPUFDUTUIFUFTUDPEF %FTJHOUPBWPJEGBMTFQPTJUJWFT

w *UTJNQPSUBOUUPSVO3VCP$PQUIBUBDUVBMMZVTFT .JOJUFTU w *SBOJUJOUIFSBJMTSBJMTSFQPTJUPSZBOEGPVOE GBMTFQPTJUJWFT w "EESVCPDPQNJOJUFTUUPSBJMTSBJMT(FNpMFBOE TQFDJGZpathPSgithubPQUJPO w
3VOrubocop --only Minitest/UnreachableAssertion %PHGPPEJOHXJUISFBMXPSMEDPEF

Support OSS community

4UBCMF #FZPOE

#FZPOE

#SFBLJOHDIBOHFTQMBOOFE GPS3VCP$PQ 1BSU

w 6TFBaseDMBTTJOTUFBEPGCopDMBTT w .PTUPGHFNTNBJOUBJOFECZSVCPDPQPSH TVDIBT3VCP$PQ1FSGPSNBODF 3BJMT 34QFD .JOJUFTU 3BLFIBWFCFFONJHSBUFE
w "EFQSFDBUFEXBSOJOHNBZCFEJTQMBZFE BGUFS3VCP$PQDPSFJUTFMGIBTCFFOBMM NJHSBUFE W"1*GPSDPQEFWFMPQFST

< Base FYUFOE"VUP$PSSFDUPS EPcDPSSFDUPSc

w $POTJEFSEFpOJOH RESTRICT_ON_SENDDPOTUBOUXIFO EFpOJOHon_sendIBOEMFS <5JQ>1FSGPSNBODFJNQSPWFNFOU # `on_send` is called only
when `foo` was called class ExampleCop < Base RESTRICT_ON_SEND = %i[foo].freeze def on_send(node) = add_offense(node) end

w $PQOBNFTBOEDPOpHVSBUJPO PQUJPOOBNFTJOSVCPDPQZNMBOE UIFDPNNBOEMJOFPQUJPOTDBOOPU CFDIBOHFEFBTJMZJOW w 5IPTFOBNFTXJMMCFDIBOHFEJO 7 /BNJOHNBUUFST

w $VSSFOUMZOPXBSOJOHJTEJTQMBZFE TPGUEFQSFDBUJPO w 8JMMEJTQMBZBXBSOJOHBUTPNF QPJOUJOW w 5IPTF"1*XJMMCFDIBOHFE PSSFNPWFE
JOW %FQSFDBUFE"1*GPSSEQBSUZHFNT

w TargetRailsVersionBOETJNJMBS"1* SFNBJOTJO3VCP$PQDPSFBGUFS3BJMT EFQBSUNFOUFYUSBDUFE w 3FNPWJOHTargetRailsVersion BOE TJNJMBS"1*SFGFSFODFECZ3VCP$PQ 3BJMTJTBCSFBLJOHDIBOHF TP*XJMM
UBLFJUDBSFGVMMZ 3FNPWF3BJMTEFQFOEFODJFTGSPNDPSF

w $PQTXIPBSFOPUEJTBCMFEJOZPVS SVCPDPQZNMXJMMCFFOBCMFECZ EFGBVMUTJODF3VCP$PQ w 5IFSFBSFBCPVUOFXDPQTJO 3VCP$PQ w *UXJMMJODSFBTFJOUIFGVUVSF 1FOEJOHDPQTXJMMCFFOBCMFECZEFGBVMU

IUUQTHJUIVCDPNSVCPDPQSVCPDPQQVMMJTTVFDPNNFOU 8IFOSFMFBTF 5#) OPQMBOT😅

*EFBTGPSGVUVSFPG3VCP$PQ 1BSU

"Default rules are too strict, but customization is hard..." 'FFECBDLGSPNVTFST

"Default rules are too strict, but customization is hard..." 'FFECBDLGSPNVTFST
*EPOUIBWFUIFCFTUBOTXFS CVU*MMUBMLJEFBTIFSF

w4UBSUXJUIUIFEFGBVMUEJTBCMFE BOEFOBCMFDPQTUFQCZTUFQ w6TFSVCPDPQ@UPEPZNM w3JEFPOSEQBSUZQSFTFU w$PNCJOFUIFN 0QUJPOTBWBJMBCMF

"QQMJDBUJPOTUSBUFHZ %JTBCMFE#Z%FGBVMUUSVF &OBCMFE#Z%FGBVMUUSVF %FGBVMUDPOpHVSBUJPO 5IJSEQBSUZQSFTFU 3VMFTUSFOHUIBOEDPNQMFYJUZ 5JNFUPBQQMZ3VCP$PQ $VTUPNDPOpHVSBUJPO 8IFUIFSUPDPOpHVSFPSOPU 8IFUIFSUPDPOpHVSFPSOPU
1SPCBCMZPOMZGPS3VCP$PQUFTUJOH $POpHVSFMBUFS 5IFDPOpHVSBUJPOZPVMJLF ⭐ ⭐ ⭐ ⭐)PXUPHFUTUBSUFE .BZCFUIFSFJTBQSFTFUUIBU JTDMPTFUPZPVSUBTUF 3VMFTFUUPBQQMZ

"QQMJDBUJPOTUSBUFHZ %JTBCMFE#Z%FGBVMUUSVF &OBCMFE#Z%FGBVMUUSVF %FGBVMUDPOpHVSBUJPO 5IJSEQBSUZQSFTFU Today's topic 3VMFTUSFOHUIBOEDPNQMFYJUZ 5JNFUPBQQMZ3VCP$PQ $VTUPNDPOpHVSBUJPO
8IFUIFSUPDPOpHVSFPSOPU 8IFUIFSUPDPOpHVSFPSOPU 1SPCBCMZPOMZGPS3VCP$PQUFTUJOH $POpHVSFMBUFS 5IFDPOpHVSBUJPOZPVMJLF ⭐ ⭐ ⭐ ⭐)PXUPHFUTUBSUFE .BZCFUIFSFJTBQSFTFUUIBU JTDMPTFUPZPVSUBTUF 3VMFTFUUPBQQMZ

w"QQMZSVMFTFBDIUJNFZPV FODPVOUFSBOPGGFOTF %3: %JTBCMFE#Z%FGBVMUUSVF

3JEFPO5IJSEQBSUZQSFTFU

3VOUJNFFOHJOFBOE DPSFDPQT $POpHVSBUJPO $POpHVSBUJPO 3VCP$PQDPSF SVCPDPQZNM SBJMTSBJMTSFQP &YUFOEBCMFDPOpHVSBUJPO $POpHVSBUJPO SVCPDPQSBJMT@DPOpH
HFN SVCPDPQZNM BQQMJDBUJPO 4UBOEBSEHFN UFTUEPVCMFTUBOEBSE You can use existing 3rd party configurations Configurable No configuration

3VOUJNFFOHJOFBOE DPSFDPQT $POpHVSBUJPO 1SFTFUDPOpHVSBUJPO 3VCP$PQDPSF SVCPDPQZNM SBJMTSBJMTSFQP 3JEFPOSEQBSUZQSFTFUXBZ $POpHVSBUJPO SVCPDPQSBJMT@DPOpH
HFN SVCPDPQZNM BQQMJDBUJPO 4UBOEBSEHFN UFTUEPVCMFTUBOEBSE You can use existing 3rd party preset or your config Configurable No configuration

IUUQTEPDTSVCPDPQPSHSVCPDPQFYUFOTJPOTIUNMDPQFYUFOTJPOT

IUUQTHJUIVCDPNHJUIVCSVCPDPQHJUIVC

0OFPGJEFBTGPS GVUVSF3VCP$PQ

.JOJNVNQSFTFU %JTBCMFE#Z%FGBVMUUSVF &OBCMFE#Z%FGBVMUUSVF %FGBVMUDPOpHVSBUJPO 5IJSEQBSUZQSFTFU 3VMFTUSFOHUI CVUDPNQMFY 5JNFUPJOUSPEVDFBQSPKFDU $VTUPNDPOpHVSBUJPO 8IFUIFSUPDPOpHVSFPSOPU
8IFUIFSUPDPOpHVSFPSOPU 1SPCBCMZPOMZGPS3VCP$PQUFTUJOH $POpHVSFMBUFS 5IFDPOpHVSBUJPOZPVMJLF ⭐ ⭐ ⭐ ⭐)PXUPHFUTUBSUFE .BZCFUIFSFJTBQSFTFUUIBU JTDMPTFUPZPVSUBTUF 3VMFTFUUPBQQMZ JEFB .JOJNVNQSFTFUGSPNP⒏DJBM

SVCPDPQSVCPDPQ 1SPQPTBMUPEJTDVTT4VHHFTUJPONPEFDPQT

IUUQTHJUIVCDPNSVCPDPQSVCPDPQJTTVFTJTTVFDPNNFOU

w&WFSZ3VCZQSPHSBNNFSTIBWF QSFGFSFODFT EJWFSTJUZJTHPPE w*O3VCZ TUZMFQSFGFSFODFTUFOEUP WBSZGSPNQFSTPOUPQFSTPO w"QQBSFOUMZFWFO3VCZDPNNJUUFST IBWFEJGGFSFOUUBTUFT😅 3VCZJTBUSVMZFYQSFTTJWFMBOHVBHF

'JYJOHUIFQSFTFUTFFNT EJGpDVMU 🤔 To be continued…

5IF3VCZDPODFQU 4NBSUFS 'BTUFS

QPDLFSVCPDPQUZQFE $PQJEFBT

w SVCPDPQUZQFEJTB1P$UIBU DPNCJOFT4UFFQTTUBUJDUZQFDIFDLFS w 6TJOHUZQFJOGPSNBUJPOXJMMTPMWF TPNFGBMTFQPTJUJWFT w 3VCP$PQXJMMCFBCMFUPQFSGPSN TNBSUFSTUBUJDBOBMZTJT $BOUZQFJOGPSNBUJPOCFBHBNFDIBOHFS

SVCPDPQSVCPDPQ 1FSGPSNBODFJNQSPWFNFOUTGPSCFUUFSFEJUPSJOUFHSBUJPO

w #PPUTOBQXBTQSPQPTFEJOUIFQBTU CVUXPSUISFWJTJUFE w *OUFHSBUFEBFNPOTMJLFSVCPDPQ EBFNPO
BOEDPMMBCPSBUFXJUI-41 4PMBSHSBQI w *UTIPVMEDPOUSJCVUFUPUIF3VCZ DPODFQU4NBSUFS 'BTUFS 1FSGPSNBODFJNQSPWFNFOUJEFBT

.BOZPGZPVVTFT3VCP$PQ JUTBHSFBUUPPM CVUXFDBO JNQSPWFJUBMPUJOUIFGVUVSF .BU[TBJE &VSVLP,FZOPUF #FZPOE3VCZ

-41 3#* 3#4 3VCP$PQ 4PMBSHSBQI 4PSCFU 4UFFQ 5ZQF1SPG &MFNFOUTPG&P% 💨
BOENPSF

3VCZTUBUJDBOBMZTJTUPPMT XJMMDPOUJOVFUPJNQSPWF rubocop.org

RuboCop in 2021: Stable and Beyond

RuboCop in 2021: Stable and Beyond

Transcript

More Decks by Koichi ITO

Other Decks in Programming

Featured