よりよいレビュー環境を求めて / A code review odyssey

よりよいレビュー環境を求めて / A code review odyssey

Minami Aoyama Night #6の発表資料です
https://techplay.jp/event/675288

詳細はこちら:
https://masawada.hatenablog.jp/entry/2018/07/02/120000

E35ded9f4d9da564ecf85ad527f11639?s=128

masawada

July 02, 2018
Tweet

Transcript

  1. ࿨ాকٛid:masawada 2018.06.29Minami Aoyama Night #6 ΑΓΑ͍
 ϨϏϡʔ؀ڥΛٻΊͯ !1

  2. ձ৔ͷΈͳ͞·ʹ࣭໰ !2

  3. ձ৔ͷΈͳ͞·ʹ࣭໰ ͝ڠྗ͋Γ͕ͱ͏͍͟͝·͢ !3

  4. ͍·͙͢ొ࿥ https://blog.hatena.ne.jp/register !4

  5. ࣗݾ঺հ ࿨ాকٛid:masawada גࣜձࣾ͸ͯͳWebΞϓϦέʔγϣϯΤϯδχΞ ͸ͯͳϒϩάνʔϜ !5

  6. ࿨ాকٛid:masawada 2018.06.29Minami Aoyama Night #6 ΑΓΑ͍
 ϨϏϡʔ؀ڥΛٻΊͯ !6

  7. ͳͥϨϏϡʔ͢Δͷ͔ !7 ͳͥϨϏϡʔ͢Δͷ͔

  8. ͳͥϨϏϡʔ͢Δͷ͔ !8 ͳͥϨϏϡʔ͢Δͷ͔  ιϑτ΢ΣΞͷ࣭Λ୲อ͢ΔͨΊ  ϓϩμΫτʹؔ͢Δ஌ݟΛڞ༗͢ΔͨΊ

  9. ͳͥϨϏϡʔ͢Δͷ͔ !9 ͳͥϨϏϡʔ͢Δͷ͔  ιϑτ΢ΣΞͷ࣭Λ୲อ͢ΔͨΊ  ϓϩμΫτʹؔ͢Δ஌ݟΛڞ༗͢ΔͨΊ

  10. ͳͥϨϏϡʔ͢Δͷ͔ !10 ͳͥϨϏϡʔ͢Δͷ͔ ϨϏϡʔͷ࣭˺ιϑτ΢ΣΞͷ࣭

  11. ͳͥϨϏϡʔ͢Δͷ͔ !11 ͳͥϨϏϡʔ͢Δͷ͔ ϨϏϡΞʔͷෛ୲Λ࣭ܰͯ͘͠Λอ͍ͪͨ

  12. ͸ͯͳϒϩάνʔϜͷ͝঺հ !12 ͸ͯͳϒϩάνʔϜͷ͝঺հ

  13. ͸ͯͳϒϩάνʔϜͷ͝঺հ !13 ژ౎ ౦ژ ϓϥϯφʔ σΟϨΫλʔ ΤϯδχΞ σβΠφ ϓϩσϡʔαʔ ৬छ৬৔

  14. ͸ͯͳϒϩάνʔϜͷ͝঺հ !14 ίϛϡχέʔγϣϯπʔϧ Google Hangouts GitHub Enterprise Slack ʜͱɺ͸ͯͳάϧʔϓ

  15. ͸ͯͳϒϩάνʔϜͷ͝঺հ ͸ͯͳϒϩάνʔϜͷ͝঺հ  ຖ೔ϦϦʔε  ຖ೔2ճϨϏϡʔλΠϜ  σβΠφ΋HTML/CSSΛॻ͘ !15

  16. લఏͷ࿩ !16 લఏͷ࿩͓ΘΓ ͜͜·Ͱ5෼

  17. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !17 ආ͚͍ͨPull Requestͷύλʔϯͱ
 ͦΕΛճආ͢ΔͨΊͷઓུ

  18. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ ආ͚͍ͨPull Requestͷύλʔϯ  Ұൃೖࠢύλʔϯ  େձ৔ύλʔϯ  ਺चܨ͗ύλʔϯ

     όβʔϧύλʔϯ !18
  19. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !19 Ұൃೖࠢύλʔϯ

  20. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !20

  21. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ Ұൃೖࠢύλʔϯͷ໰୊఺  ϨϏϡʔ͢Δίʔυྔ͕ଟ͍  ໰୊఺ͷ਺͕ଟ͘ͳΓ͕ͪ  ίϯϑϦΫτ͠΍͘͢ͳΔ !21

  22. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !22 େձ৔ύλʔϯ

  23. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !23

  24. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ େձ৔ύλʔϯͷ໰୊఺  masterʹϚʔδͨ͠ͱ͖ʹಈ͘อূ͕ബ͍  ϒϩοΧʔͱͳΔλεΫ͕ൃੜ͢Δ !24

  25. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !25 ਺चܨ͗ύλʔϯ

  26. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !26

  27. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ ਺चܨ͗ύλʔϯͷ໰୊఺  ਌ϒϥϯνͰίϛοτ͕௥Ճ͞ΕΔͱͭΒ͍  ϚʔδॱংʹؾΛ͚ͭΔඞཁ͕͋Δ !27

  28. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !28 όβʔϧύλʔϯ

  29. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !29

  30. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ όβʔϧύλʔϯͷ໰୊఺  ϨϏϡʔ͢΂͖ൣғ͕ෆ໌ྎ  Pull Requestͷίϝϯτཝ͕௥͍ͮΒ͘ͳΔ !30

  31. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !31 ϨϏϡʔ͠΍͍͢Pull RequestΛ࡞Δઓུ

  32. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ ϨϏϡʔ͠΍͍͢Pull Request  ϨϏϡʔ͢΂͖ίʔυͷྔ͕গͳ͍  ϨϏϡΞʔͷෛ͏΂͖੹຿͕͸͖ͬΓ͍ͯ͠Δ !32

  33. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ ϨϏϡʔ͠΍͍͢Pull Request  λεΫΛࣄલʹࡉ͔͘෼ׂ͢Δ  Pull RequestΛࡉ͔͘masterʹϚʔδ͢Δ !33

  34. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ λεΫΛࣄલʹࡉ͔͘෼ׂ͢Δ  λεΫؒͷؔ܎Λ೺Ѳ͢Δ͜ͱ͕Ͱ͖Δ  ࢒λεΫ΍ؔ࿈λεΫ͕໌ࣔతʹͳΔ !34

  35. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ λεΫΛࣄલʹࡉ͔͘෼ׂ͢Δίπ  ͙͢͞·Issueʹམͱ͠ࠐ·ͳ͍  ࡞ۀ͕࣌ؒͳΔ΂͘ҰఆʹͳΔΑ͏ʹ  1λεΫ1ਓΛ৺͕͚Δ !35

  36. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ λεΫΛࣄલʹࡉ͔͘෼ׂ͢Δίπ !36

  37. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ λεΫΛࣄલʹࡉ͔͘෼ׂ͢Δίπ  ͙͢͞·Issueʹམͱ͠ࠐ·ͳ͍  ࡞ۀ͕࣌ؒͳΔ΂͘ҰఆʹͳΔΑ͏ʹ  1λεΫ1ਓΛ৺͕͚Δ !37

  38. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ Pull RequestΛࡉ͔͘masterʹϚʔδ͢Δ  ςʔϒϧΛ࡞੒͢Δ  ϞσϧΫϥεΛ࡞Δ  पลͷखଓ͖Λந৅Խͨ͠ϝιουΛ࡞੒͢Δ

     6*ϞοΫΛ࡞Δ  6*ͱϩδοΫΛ݁߹͢Δ !38
  39. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !39 <ࡉ͔͘merge͍ͯ͘͠ઓུ><ݕࡧ>

  40. ආ͚͍ͨPull RequestͷύλʔϯͱͦΕΛճආ͢ΔͨΊͷઓུ !40 ආ͚͍ͨPull Requestͷύλʔϯͱ
 ͦΕΛճආ͢ΔͨΊͷઓུ͓ΘΓ ͜͜·Ͱ17෼

  41. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ !41 ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ

  42. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ  ϨϏϡΞʔͷภΓΛՄࢹԽ͢Δ  ΞϧόΠτʹ΋ϨϏϡʔΛͯ͠΋Β͏ !42

  43. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ ϨϏϡΞʔͷภΓΛՄࢹԽ͢Δ !43

  44. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ github.com/aereal/go-github-reviewer-stats !44

  45. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ !45

  46. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ !46

  47. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ ΞϧόΠτελοϑʹ΋ϨϏϡʔΛͯ͠΋Β͏ !47

  48. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ ΞϧόΠτελοϑʹ΋ϨϏϡʔΛͯ͠΋Β͏  ϓϩμΫτʹؔ͢Δ஌ݟΛਂΊΔ͜ͱ͕Ͱ͖Δ  ద౓ͳ1VMM3FRVFTUͷཻ౓ΛֶͿ͜ͱ͕Ͱ͖Δ !48

  49. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ ΞϧόΠτελοϑʹ΋ϨϏϡʔΛͯ͠΋Β͏  ϨϏϡʔλΠϜ͸1࣌ؒ  approveͯ͠΋masterʹϚʔδ͸Ͱ͖ͳ͍ !49

  50. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ ΞϧόΠτελοϑʹ΋ϨϏϡʔΛͯ͠΋Β͏ !50

  51. ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ !51 ϨϏϡʔΛऔΓר͘؀ڥΛ޻෉͢Δ࿩͓ΘΓ ͜͜·Ͱ22෼

  52. ·ͱΊ !52 ·ͱΊ

  53. ·ͱΊ !53 ࿩ͨ͜͠ͱ ϨϏϡʔ͸ιϑτ΢ΣΞͷ࣭Λ୲อ͢ΔॏཁͳϑΝΫλʔ Pull Requestͷ࡞ΓํΛ޻෉ͯ͠
 ϨϏϡΞʔͷෛ୲ΛݮΒͦ͏ ࡉ͔͘վળΛॏͶͯΑΓΑ͍ϨϏϡʔͷ؀ڥ࡞ΓΛ͠Α͏

  54. ͋Γ͕ͱ͏͍͟͝·ͨ͠ ࣭ٙԠ౴ !54