Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Review is DEAD
Search
Tatsuya Sato
November 05, 2014
Technology
20
710
Review is DEAD
社内で開催されたコードレビューの勉強会のLTで使った資料
Tatsuya Sato
November 05, 2014
Tweet
Share
More Decks by Tatsuya Sato
See All by Tatsuya Sato
受託開発受注のためのちょっとしたコツ 〜「何でもかんでもやります」じゃなく、まずはデモ〜 / demonstation first
satoryu
0
1.5k
これが私のXP 〜 eXtreme Punning 〜 変化をウケろ / this is my XP
satoryu
1
1.9k
音のような言葉 〜ちゃちゃっとチャットで楽しむちょっとしたコツ〜 / words like sounds
satoryu
1
3.6k
ふらっと立ち寄れる 廊下のある風景 - フラットでオープンネスがもたらす魅力 / The Corridor
satoryu
1
2.8k
Make it fun
satoryu
1
4.1k
なぜ私はチームにい続けるのか。あるいは、エンジニアとしての成長のためのチームの活用について。 / Why I continue to be in the team #RSGT2021
satoryu
0
6.3k
リモート時代のソロプログラミング - soloprogramming for work from home
satoryu
0
1.4k
Why do you fear contributing OSS? #xpjug
satoryu
5
12k
あるOSSの死と再生、それとこれから先 / How an OSS also arises
satoryu
0
310
Other Decks in Technology
See All in Technology
ZOZOTOWNの大規模マーケティングメール配信を支えるアーキテクチャ
zozotech
PRO
0
550
ロールが細分化された組織でSREと協働するインフラエンジニアは何をするか? / SRE Lounge #18
kossykinto
0
230
ファッションコーディネートアプリ「WEAR」における、Vertex AI Vector Searchを利用したレコメンド機能の開発・運用で得られたノウハウの紹介
zozotech
PRO
0
550
Agent Development Kitで始める生成 AI エージェント実践開発
danishi
0
160
MCP認可の現在地と自律型エージェント対応に向けた課題 / MCP Authorization Today and Challenges to Support Autonomous Agents
yokawasa
5
2.5k
AWS DDoS攻撃防御の最前線
ryutakondo
1
170
メルカリIBIS:AIが拓く次世代インシデント対応
0gm
2
330
データモデリング通り #2オンライン勉強会 ~方法論の話をしよう~
datayokocho
0
180
AIに目を奪われすぎて、周りの困っている人間が見えなくなっていませんか?
cap120
1
690
JAWS-UG のイベントで使うハンズオンシナリオを Amazon Q Developer for CLI で作ってみた話
kazzpapa3
0
110
Jamf Connect ZTNAとMDMで実現! 金融ベンチャーにおける「デバイストラスト」実例と軌跡 / Kyash Device Trust
rela1470
1
200
AIと描く、未来のBacklog 〜プロジェクト管理の次の10年を想像し、創造するセッション〜
hrm_o25
0
110
Featured
See All Featured
Responsive Adventures: Dirty Tricks From The Dark Corners of Front-End
smashingmag
251
21k
VelocityConf: Rendering Performance Case Studies
addyosmani
332
24k
Producing Creativity
orderedlist
PRO
347
40k
Chrome DevTools: State of the Union 2024 - Debugging React & Beyond
addyosmani
7
810
BBQ
matthewcrist
89
9.8k
A better future with KSS
kneath
239
17k
Let's Do A Bunch of Simple Stuff to Make Websites Faster
chriscoyier
507
140k
Fashionably flexible responsive web design (full day workshop)
malarkey
407
66k
Improving Core Web Vitals using Speculation Rules API
sergeychernyshev
18
1.1k
For a Future-Friendly Web
brad_frost
179
9.9k
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
358
30k
How GitHub (no longer) Works
holman
314
140k
Transcript
Review is DEAD Tatsuya “Botcher” Sato
Who I am • Tatsuya “Botcher” Sato • @sato_ryu •
Rubyist & Scrum Master
Botcher? ʲ໊ʳ ʪӳʫ΅৬ਓɺमཧͷԼखͳਓ
NO
ʲ໊ʳ΅ͬͪͳਓ
Review is Evil ϨϏϡʔѱ
Evil Reviews
Evil Reviews Code Review Specification Review Design Review
Review as a Gate
When the evils appear Specification Design Code
When the evils appear Specification Design Code Review Review Review
When the evils appear Specification Design Code Review Review Review
• Each Review stops the progress. • Each Review makes us go back to the beginning.
“The GateKeeper” Reviewer
“The GateKeeper” Reviewer • “Reviewer” vs “Reviewee” • Reviewer believes
s/he SHOULD point out anything as possible. • Review makes UNWISHED WARS.
Diversity of Background
Diversity of Background • Pros • Diversity of view points
• Cons • Need communications for CONSENSUS.
All Reviews Should be Passed
Wastes much time…
–Wikipedia http://en.wikipedia.org/wiki/Development_hell “development hell is a state during which a
film or other project remains in development without progressing to production.”
Review is Evil ϨϏϡʔѱ
ॾ܅ɺ ඞཁͳ͜ͱ Կ͔ʁ
Consensus
Consensus • σϓϩΠͯ͠ྑ͍ͱ͍͏߹ҙ • ίʔυʹࣗ৴Λ࣋ͯΔͱ͍͏߹ҙ
Review is DEAD?
Review is still Alive ϨϏϡʔੜ͖͍ͯΔɻ
Code Review is alive
Discovery increases over phases Specification Design Code Discovery
Code Review is still alive • Two passback do NOT
make sense. • But pass back from Code Review has emergency but valuable Specification Design Code Review Review Review
How? Ͳ͏Δͷ͔ʁ
Backlog Refinement
Backlog Refinement • The process through which product backlog items
are reviewed by the Scrum team and revised, providing more detail and ensuring that there is greater clarity in the requirements for that item.
Collaborative or Not? Specification Design Code
Discuss all members not only developers, involve a product owner.
–ɹBABYMETAL “ΠδϝɺμϝɺθολΠ” ΑΓ “ΠδϝɺμϝɺθολΠ”