Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Review is DEAD
Search
Tatsuya Sato
November 05, 2014
Technology
20
710
Review is DEAD
社内で開催されたコードレビューの勉強会のLTで使った資料
Tatsuya Sato
November 05, 2014
Tweet
Share
More Decks by Tatsuya Sato
See All by Tatsuya Sato
受託開発受注のためのちょっとしたコツ 〜「何でもかんでもやります」じゃなく、まずはデモ〜 / demonstation first
satoryu
0
1.5k
これが私のXP 〜 eXtreme Punning 〜 変化をウケろ / this is my XP
satoryu
1
1.9k
音のような言葉 〜ちゃちゃっとチャットで楽しむちょっとしたコツ〜 / words like sounds
satoryu
1
3.7k
ふらっと立ち寄れる 廊下のある風景 - フラットでオープンネスがもたらす魅力 / The Corridor
satoryu
1
2.9k
Make it fun
satoryu
1
4.1k
なぜ私はチームにい続けるのか。あるいは、エンジニアとしての成長のためのチームの活用について。 / Why I continue to be in the team #RSGT2021
satoryu
0
6.3k
リモート時代のソロプログラミング - soloprogramming for work from home
satoryu
0
1.4k
Why do you fear contributing OSS? #xpjug
satoryu
5
12k
あるOSSの死と再生、それとこれから先 / How an OSS also arises
satoryu
0
310
Other Decks in Technology
See All in Technology
研究開発と製品開発、両利きのロボティクス
youtalk
1
530
JTCにおける内製×スクラム開発への挑戦〜内製化率95%達成の舞台裏/JTC's challenge of in-house development with Scrum
aeonpeople
0
240
COVESA VSSによる車両データモデルの標準化とAWS IoT FleetWiseの活用
osawa
1
310
5分でカオスエンジニアリングを分かった気になろう
pandayumi
0
250
なぜテストマネージャの視点が 必要なのか? 〜 一歩先へ進むために 〜
moritamasami
0
230
品質視点から考える組織デザイン/Organizational Design from Quality
mii3king
0
210
これでもう迷わない!Jetpack Composeの書き方実践ガイド
zozotech
PRO
0
990
実践!カスタムインストラクション&スラッシュコマンド
puku0x
0
470
AI開発ツールCreateがAnythingになったよ
tendasato
0
130
Snowflake Intelligenceにはこうやって立ち向かう!クラシルが考えるAI Readyなデータ基盤と活用のためのDataOps
gappy50
0
270
人工衛星のファームウェアをRustで書く理由
koba789
15
8.1k
Webアプリケーションにオブザーバビリティを実装するRust入門ガイド
nwiizo
7
860
Featured
See All Featured
Bash Introduction
62gerente
615
210k
BBQ
matthewcrist
89
9.8k
10 Git Anti Patterns You Should be Aware of
lemiorhan
PRO
656
61k
The World Runs on Bad Software
bkeepers
PRO
70
11k
How to Think Like a Performance Engineer
csswizardry
26
1.9k
The Art of Programming - Codeland 2020
erikaheidi
56
13k
Facilitating Awesome Meetings
lara
55
6.5k
Site-Speed That Sticks
csswizardry
10
820
Building Applications with DynamoDB
mza
96
6.6k
The Pragmatic Product Professional
lauravandoore
36
6.9k
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
162
15k
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
eileencodes
36
2.5k
Transcript
Review is DEAD Tatsuya “Botcher” Sato
Who I am • Tatsuya “Botcher” Sato • @sato_ryu •
Rubyist & Scrum Master
Botcher? ʲ໊ʳ ʪӳʫ΅৬ਓɺमཧͷԼखͳਓ
NO
ʲ໊ʳ΅ͬͪͳਓ
Review is Evil ϨϏϡʔѱ
Evil Reviews
Evil Reviews Code Review Specification Review Design Review
Review as a Gate
When the evils appear Specification Design Code
When the evils appear Specification Design Code Review Review Review
When the evils appear Specification Design Code Review Review Review
• Each Review stops the progress. • Each Review makes us go back to the beginning.
“The GateKeeper” Reviewer
“The GateKeeper” Reviewer • “Reviewer” vs “Reviewee” • Reviewer believes
s/he SHOULD point out anything as possible. • Review makes UNWISHED WARS.
Diversity of Background
Diversity of Background • Pros • Diversity of view points
• Cons • Need communications for CONSENSUS.
All Reviews Should be Passed
Wastes much time…
–Wikipedia http://en.wikipedia.org/wiki/Development_hell “development hell is a state during which a
film or other project remains in development without progressing to production.”
Review is Evil ϨϏϡʔѱ
ॾ܅ɺ ඞཁͳ͜ͱ Կ͔ʁ
Consensus
Consensus • σϓϩΠͯ͠ྑ͍ͱ͍͏߹ҙ • ίʔυʹࣗ৴Λ࣋ͯΔͱ͍͏߹ҙ
Review is DEAD?
Review is still Alive ϨϏϡʔੜ͖͍ͯΔɻ
Code Review is alive
Discovery increases over phases Specification Design Code Discovery
Code Review is still alive • Two passback do NOT
make sense. • But pass back from Code Review has emergency but valuable Specification Design Code Review Review Review
How? Ͳ͏Δͷ͔ʁ
Backlog Refinement
Backlog Refinement • The process through which product backlog items
are reviewed by the Scrum team and revised, providing more detail and ensuring that there is greater clarity in the requirements for that item.
Collaborative or Not? Specification Design Code
Discuss all members not only developers, involve a product owner.
–ɹBABYMETAL “ΠδϝɺμϝɺθολΠ” ΑΓ “ΠδϝɺμϝɺθολΠ”