Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Review is DEAD
Search
Tatsuya Sato
November 05, 2014
Technology
19
710
Review is DEAD
社内で開催されたコードレビューの勉強会のLTで使った資料
Tatsuya Sato
November 05, 2014
Tweet
Share
More Decks by Tatsuya Sato
See All by Tatsuya Sato
受託開発受注のためのちょっとしたコツ 〜「何でもかんでもやります」じゃなく、まずはデモ〜 / demonstation first
satoryu
0
1.5k
これが私のXP 〜 eXtreme Punning 〜 変化をウケろ / this is my XP
satoryu
1
1.9k
音のような言葉 〜ちゃちゃっとチャットで楽しむちょっとしたコツ〜 / words like sounds
satoryu
1
3.6k
ふらっと立ち寄れる 廊下のある風景 - フラットでオープンネスがもたらす魅力 / The Corridor
satoryu
1
2.8k
Make it fun
satoryu
1
4k
なぜ私はチームにい続けるのか。あるいは、エンジニアとしての成長のためのチームの活用について。 / Why I continue to be in the team #RSGT2021
satoryu
0
6.3k
リモート時代のソロプログラミング - soloprogramming for work from home
satoryu
0
1.3k
Why do you fear contributing OSS? #xpjug
satoryu
5
12k
あるOSSの死と再生、それとこれから先 / How an OSS also arises
satoryu
0
310
Other Decks in Technology
See All in Technology
強化されたAmazon Location Serviceによる新機能と開発者体験
dayjournal
2
200
Model Mondays S2E02: Model Context Protocol
nitya
0
220
Кто отправит outbox? Валентин Удальцов, автор канала Пых
lamodatech
0
330
あなたの声を届けよう! 女性エンジニア登壇の意義とアウトプット実践ガイド #wttjp / Call for Your Voice
kondoyuko
4
410
Agentic DevOps時代の生存戦略
kkamegawa
1
1.3k
VISITS_AIIoTビジネス共創ラボ登壇資料.pdf
iotcomjpadmin
0
160
製造業からパッケージ製品まで、あらゆる領域をカバー!生成AIを利用したテストシナリオ生成 / 20250627 Suguru Ishii
shift_evolve
PRO
1
130
ローカルLLMでファインチューニング
knishioka
0
150
UIテスト自動化サポート- Testbed for XCUIAutomation practice
notoroid
0
130
Fabric + Databricks 2025.6 の最新情報ピックアップ
ryomaru0825
1
130
GeminiとNotebookLMによる金融実務の業務革新
abenben
0
220
Navigation3でViewModelにデータを渡す方法
mikanichinose
0
220
Featured
See All Featured
Build The Right Thing And Hit Your Dates
maggiecrowley
36
2.8k
Site-Speed That Sticks
csswizardry
10
660
Scaling GitHub
holman
459
140k
Documentation Writing (for coders)
carmenintech
71
4.9k
Building a Modern Day E-commerce SEO Strategy
aleyda
41
7.3k
Designing Dashboards & Data Visualisations in Web Apps
destraynor
231
53k
Agile that works and the tools we love
rasmusluckow
329
21k
4 Signs Your Business is Dying
shpigford
184
22k
Building Applications with DynamoDB
mza
95
6.5k
How To Stay Up To Date on Web Technology
chriscoyier
790
250k
StorybookのUI Testing Handbookを読んだ
zakiyama
30
5.8k
ピンチをチャンスに:未来をつくるプロダクトロードマップ #pmconf2020
aki_iinuma
124
52k
Transcript
Review is DEAD Tatsuya “Botcher” Sato
Who I am • Tatsuya “Botcher” Sato • @sato_ryu •
Rubyist & Scrum Master
Botcher? ʲ໊ʳ ʪӳʫ΅৬ਓɺमཧͷԼखͳਓ
NO
ʲ໊ʳ΅ͬͪͳਓ
Review is Evil ϨϏϡʔѱ
Evil Reviews
Evil Reviews Code Review Specification Review Design Review
Review as a Gate
When the evils appear Specification Design Code
When the evils appear Specification Design Code Review Review Review
When the evils appear Specification Design Code Review Review Review
• Each Review stops the progress. • Each Review makes us go back to the beginning.
“The GateKeeper” Reviewer
“The GateKeeper” Reviewer • “Reviewer” vs “Reviewee” • Reviewer believes
s/he SHOULD point out anything as possible. • Review makes UNWISHED WARS.
Diversity of Background
Diversity of Background • Pros • Diversity of view points
• Cons • Need communications for CONSENSUS.
All Reviews Should be Passed
Wastes much time…
–Wikipedia http://en.wikipedia.org/wiki/Development_hell “development hell is a state during which a
film or other project remains in development without progressing to production.”
Review is Evil ϨϏϡʔѱ
ॾ܅ɺ ඞཁͳ͜ͱ Կ͔ʁ
Consensus
Consensus • σϓϩΠͯ͠ྑ͍ͱ͍͏߹ҙ • ίʔυʹࣗ৴Λ࣋ͯΔͱ͍͏߹ҙ
Review is DEAD?
Review is still Alive ϨϏϡʔੜ͖͍ͯΔɻ
Code Review is alive
Discovery increases over phases Specification Design Code Discovery
Code Review is still alive • Two passback do NOT
make sense. • But pass back from Code Review has emergency but valuable Specification Design Code Review Review Review
How? Ͳ͏Δͷ͔ʁ
Backlog Refinement
Backlog Refinement • The process through which product backlog items
are reviewed by the Scrum team and revised, providing more detail and ensuring that there is greater clarity in the requirements for that item.
Collaborative or Not? Specification Design Code
Discuss all members not only developers, involve a product owner.
–ɹBABYMETAL “ΠδϝɺμϝɺθολΠ” ΑΓ “ΠδϝɺμϝɺθολΠ”