Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Review is DEAD
Search
Tatsuya Sato
November 05, 2014
Technology
20
710
Review is DEAD
社内で開催されたコードレビューの勉強会のLTで使った資料
Tatsuya Sato
November 05, 2014
Tweet
Share
More Decks by Tatsuya Sato
See All by Tatsuya Sato
受託開発受注のためのちょっとしたコツ 〜「何でもかんでもやります」じゃなく、まずはデモ〜 / demonstation first
satoryu
0
1.6k
これが私のXP 〜 eXtreme Punning 〜 変化をウケろ / this is my XP
satoryu
1
1.9k
音のような言葉 〜ちゃちゃっとチャットで楽しむちょっとしたコツ〜 / words like sounds
satoryu
1
3.7k
ふらっと立ち寄れる 廊下のある風景 - フラットでオープンネスがもたらす魅力 / The Corridor
satoryu
1
2.9k
Make it fun
satoryu
1
4.1k
なぜ私はチームにい続けるのか。あるいは、エンジニアとしての成長のためのチームの活用について。 / Why I continue to be in the team #RSGT2021
satoryu
0
6.3k
リモート時代のソロプログラミング - soloprogramming for work from home
satoryu
0
1.4k
Why do you fear contributing OSS? #xpjug
satoryu
5
12k
あるOSSの死と再生、それとこれから先 / How an OSS also arises
satoryu
0
310
Other Decks in Technology
See All in Technology
組織観点からIAM Identity CenterとIAMの設計を考える
nrinetcom
PRO
1
160
Railsアプリケーション開発者のためのブックガイド
takahashim
14
6.1k
SOC2取得の全体像
shonansurvivors
1
360
自作LLM Native GORM Pluginで実現する AI Agentバックテスト基盤構築
po3rin
2
240
GC25 Recap+: Advancing Go Garbage Collection with Green Tea
logica0419
1
370
GA technologiesでのAI-Readyの取り組み@DataOps Night
yuto16
0
260
pprof vs runtime/trace (FlightRecorder)
task4233
0
150
Azure Well-Architected Framework入門
tomokusaba
0
270
SREとソフトウェア開発者の合同チームはどのようにS3のコストを削減したか?
muziyoshiz
1
100
How to achieve interoperable digital identity across Asian countries
fujie
0
110
業務自動化プラットフォーム Google Agentspace に入門してみる #devio2025
maroon1st
0
180
Why Governance Matters: The Key to Reducing Risk Without Slowing Down
sarahjwells
0
100
Featured
See All Featured
ReactJS: Keep Simple. Everything can be a component!
pedronauck
667
120k
Music & Morning Musume
bryan
46
6.8k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
26
3.1k
For a Future-Friendly Web
brad_frost
180
9.9k
The Art of Programming - Codeland 2020
erikaheidi
56
14k
Making the Leap to Tech Lead
cromwellryan
135
9.5k
VelocityConf: Rendering Performance Case Studies
addyosmani
332
24k
Site-Speed That Sticks
csswizardry
11
880
XXLCSS - How to scale CSS and keep your sanity
sugarenia
248
1.3M
[RailsConf 2023 Opening Keynote] The Magic of Rails
eileencodes
31
9.7k
Fight the Zombie Pattern Library - RWD Summit 2016
marcelosomers
234
17k
Large-scale JavaScript Application Architecture
addyosmani
514
110k
Transcript
Review is DEAD Tatsuya “Botcher” Sato
Who I am • Tatsuya “Botcher” Sato • @sato_ryu •
Rubyist & Scrum Master
Botcher? ʲ໊ʳ ʪӳʫ΅৬ਓɺमཧͷԼखͳਓ
NO
ʲ໊ʳ΅ͬͪͳਓ
Review is Evil ϨϏϡʔѱ
Evil Reviews
Evil Reviews Code Review Specification Review Design Review
Review as a Gate
When the evils appear Specification Design Code
When the evils appear Specification Design Code Review Review Review
When the evils appear Specification Design Code Review Review Review
• Each Review stops the progress. • Each Review makes us go back to the beginning.
“The GateKeeper” Reviewer
“The GateKeeper” Reviewer • “Reviewer” vs “Reviewee” • Reviewer believes
s/he SHOULD point out anything as possible. • Review makes UNWISHED WARS.
Diversity of Background
Diversity of Background • Pros • Diversity of view points
• Cons • Need communications for CONSENSUS.
All Reviews Should be Passed
Wastes much time…
–Wikipedia http://en.wikipedia.org/wiki/Development_hell “development hell is a state during which a
film or other project remains in development without progressing to production.”
Review is Evil ϨϏϡʔѱ
ॾ܅ɺ ඞཁͳ͜ͱ Կ͔ʁ
Consensus
Consensus • σϓϩΠͯ͠ྑ͍ͱ͍͏߹ҙ • ίʔυʹࣗ৴Λ࣋ͯΔͱ͍͏߹ҙ
Review is DEAD?
Review is still Alive ϨϏϡʔੜ͖͍ͯΔɻ
Code Review is alive
Discovery increases over phases Specification Design Code Discovery
Code Review is still alive • Two passback do NOT
make sense. • But pass back from Code Review has emergency but valuable Specification Design Code Review Review Review
How? Ͳ͏Δͷ͔ʁ
Backlog Refinement
Backlog Refinement • The process through which product backlog items
are reviewed by the Scrum team and revised, providing more detail and ensuring that there is greater clarity in the requirements for that item.
Collaborative or Not? Specification Design Code
Discuss all members not only developers, involve a product owner.
–ɹBABYMETAL “ΠδϝɺμϝɺθολΠ” ΑΓ “ΠδϝɺμϝɺθολΠ”