Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
OFN's Spree upgrade catch up
Search
Coopdevs
May 09, 2018
Programming
0
41
OFN's Spree upgrade catch up
These are the slides used to drive the meeting of OFN's dev team about the Spree upgrade
Coopdevs
May 09, 2018
Tweet
Share
More Decks by Coopdevs
See All by Coopdevs
Models de negoci a projectes amb codi obert
coopdevs
2
29
PostgreSQL in real life
coopdevs
1
100
PostgreSQL Workshop
coopdevs
1
66
Katuma i Open Food Network, Gestió de Sistemes d'Informació
coopdevs
0
21
OFN Sobtec 2019
coopdevs
0
43
Open Food Network FOSDEM 2019
coopdevs
0
74
Assemblea de Katuma
coopdevs
1
20
FESC 2018 sostenibilitat projectes tech
coopdevs
1
67
Viability and Open Source
coopdevs
0
52
Other Decks in Programming
See All in Programming
Rubyでたのしむクリエイティブコーディング/Enjoy Creative coding with Ruby
chobishiba
1
180
エンターテイメント業界で利用されるAWS
demuyan
0
210
Scalable Customer Journey Orchestration (CJO)
lewuathe
0
300
"config" ってなんだ? / What is "config"?
okashoi
0
240
MetricKitで予期せぬ終了を検知する話 / Detect unexpected termination with MetricKit
nekowen
1
190
educure_カリキュラム生操作マニュアル.pdf
linew_official
0
790
[技育CAMPアカデミア]アイディアを形に!【超入門】スマホアプリ開発〜リリースまでの流れをご紹介
teamlab
PRO
0
370
『Railsオワコン』と言われる時代に、なぜブルーモ証券はRailsを選ぶのか
free_world21
0
190
Snowflakeで眠ったデータを起こそう!
estie
0
120
Git Rebase
bkuhlmann
11
1.6k
TCAとKMPを用いた新規動画配信アプリ 「ABEMA Live」の設計
tomu28
1
100
Let's learn code review
riofujimon
1
270
Featured
See All Featured
Helping Users Find Their Own Way: Creating Modern Search Experiences
danielanewman
20
1.9k
Automating Front-end Workflow
addyosmani
1356
200k
Web development in the modern age
philhawksworth
202
10k
Why Our Code Smells
bkeepers
PRO
331
56k
Optimising Largest Contentful Paint
csswizardry
8
2.4k
Happy Clients
brianwarren
92
6.4k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
34
8.9k
Documentation Writing (for coders)
carmenintech
60
3.9k
Intergalactic Javascript Robots from Outer Space
tanoku
266
26k
The Language of Interfaces
destraynor
151
23k
The MySQL Ecosystem @ GitHub 2015
samlambert
243
12k
Unsuck your backbone
ammeep
663
57k
Transcript
Spree upgrade catch up
So far
Spree fork
Fixes from newer Sprees and OFN folks
Approach
gem 'spree', github: 'openfoodfoundation/spree', branch: 'step-6a', ref: '86bf...'
Moving ahead of master in batches of 100 commits
⾠ Upgrading to unknown states
At the very best, the tests were passing...
Proposal
2-0-stable branch
None
! the fork
Let's go for gem 'spree', ~> 2.0 !
that is 1656 commits and > 40 migrations ahead of
us
Smallest upgrade as possible
truth: the app fails fails until 2.0.8...
! we can backport the patch
Maintain the fork
own it and consider it part of the product
Just to give Spree the extensibility it didn't have in
2.0
Use best practices: CI, PRs, Code review
Stay away from it otherwise* *we might need to bring
in critical fixes, though
Enrico: Why not putting the hooks/abstraction in a separate gem?
Spree needs to be aware of them
Simpler to learn Spree than hacking it
APIs and tests vs Metaprogramming
Trade complexity for indirection
Check coopdevs/spree #6 and off/ofn #2256
Discuss