Getting Clean, Keeping Lean

Transcript

1. Getting clean. Keeping lean.

2. @hitherejoe hitherejoe joebirch.co Joe Birch - Android Engineer @ Buffer

3. @buffer buffer.com

4. Greenfield projects

5. None

6. - High-level of technical debt - Extremely tightly coupled concepts

   - No unit or UI tests - Difficult to know what is going on and where No longer lean

7. - YOU know what is what - YOU know where

   class X is - YOU know where logic for Y is - But what about along the line… No longer lean (for now) (for now) (for now)

8. 25 50 75 100 Output Debt

9. 25 50 75 100 Output Debt

10. For the sake of yours and future developers sanity -

    have empathy. Be mindful of the consequences and think before you craft.

11. Buffer for Android

12. None
13. None
14. None

15. - Lack of architecture - Bloated activities with multiple responsibilities

    - Difficult to test - Difficult to extend and maintain - Duplication of concepts == no reuse

16. Moving to MVP - Fear of changing too much -

    Helped separate presentation logic - DataManagers to house data operations - Increased test coverage
17. None
18. None

19. Not enough. - Bloated DataManager classes - Future changes, offline

    - where? - Presentation linked to specific data source - No clear line between responsibilites - Buffer is a big app. Data types, features, sources

20. Architecture “The art of planning, designing and constructing buildings”

21. Architecture “The art of planning, designing and constructing buildings concepts”

22. None
23. None
24. None
25. None
26. None

27. Think outside of your team.

28. Clean Architecture

29. None

30. Separation of Concerns

31. - Layers are independent of frameworks - Code becomes more

    testable - Inner layers independant of UI - Inner layers independant of external parties Separation of Concerns - Bugs more isolated
32. None

33. Layer Models - Each layer has own Model classes -

    Removes dependancy on external models - Easily map with Mapper classes

34. ModelA Mapper Model Mapper Model

35. Enterprise Business Rules - Application Business Objects (Entities) - Unaffected

    by operational change - Can create before touching any UI

36. public class TournamentModel {
 
 public String id;
 public String

    name;
 @SerializedName("full_name")
 public String status;
 @SerializedName("date_start")
 public String dateStart;
 @SerializedName("date_end")
 public String dateEnd;
 public int size;
 
 }

37. Application Business Rules - Application specific business rules - Uses

    Cases - Affected by operational change - Isolated from external concerns

38. public class GetSchedules extends UseCase<ProfileSchedules> {
 
 private final SchedulesRepository

    schedulesRepository;
 
 @Inject
 public GetSchedules(SchedulesRepository schedulesRepository) {
 this.schedulesRepository = schedulesRepository;
 }
 
 @Override
 public Single<ProfileSchedules> buildUseCaseObservable() {
 return schedulesRepository.getSchedules();
 }
 
 }
39. None

40. Use Case Interface Interface Impl Activity Application Business Rules Interface

    Adapters

41. Interface Adapters - Contains MVP architecture of our app -

    Presenters contain ‘callbacks’ - Views define contract for implementation - Mapper converts data from external form

42. public class UpdatesPresenter extends BasePresenter<UpdatesMvpView> implements SingleObserver<List<Update>> { @Override public

    void onSubscribe(Disposable d) { … } @Override public void onSuccess(List<Match> matches) { … } @Override public void onError(Throwable e) { … } }

43. Presenter Interface Interface Impl Activity Interface Adapters Frameworks & Drivers

44. Frameworks & Drivers - UI components (Activities, Fragments) - Networking

    actions (Retrofit) - Storage (Cache & DB) - Repository Pattern for interacting with these

45. Repository Interface Repository Impl DataStore Interface DataStore Impl DataStore Impl

    DataStore Factory
46. None

47. Layer Boundaries - Communication via abstractions (interfaces) - No direct

    name references in inner layers - Instead, inner layer provides this interface - aka, The Dependancy Inversion Principle

48. Not limited to these layers Layer 1 Layer 2 Layer

    3 Layer 4

49. Not limited to these layers Layer 1 Layer 2 Layer

    3

50. Not limited to these layers Layer 1 Layer 2 Layer

    3 Layer 4 Layer 5 Layer 6

51. Test Coverage

52. None

53. Learnings

54. Advantages. - High percentage of code coverage - Incredibly easy

    to navigate package structure - Easier to maintain - Allows us to move faster - Focused classes and test classes

55. - Seperation of concerns - Define, Test, Stabilise before UI

    - Futureproof implementations - Clear discipline, good practice - and more…

56. Disadvantages - Adds initial overhead - Takes time to get

    used to - Can feel overkill for some tasks - Difficult to make decisions - Conversion of models between layers

57. Winston Enterprise Business Rules Application Business Rules Interface Adapters Mobile

    UI TV UI Wear UI Frameworks & Drivers

58. Winston Enterprise Business Rules Application Business Rules Interface Adapters Mobile

    UI TV UI Wear UI Frameworks & Drivers @hitherejoe hitherejoe joebirch.co

59. Resources https://overflow.buffer.com/2016/12/22/rebuild- android-composer/ https://github.com/googlesamples/android- architecture Clean Architecture: A Craftsman's Guide

    to Software Structure and Design (Robert C. Martin)