Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Speaker Deck
PRO
Sign in
Sign up
for free
Surviving Code Reviews & Tech Interviews
Cecy C.
November 07, 2019
Technology
0
52
Surviving Code Reviews & Tech Interviews
Presented at The Lead Dev Austin Meetup, November 7th, 2019.
Cecy C.
November 07, 2019
Tweet
Share
More Decks by Cecy C.
See All by Cecy C.
cecyc
0
77
cecyc
0
86
cecyc
0
54
cecyc
0
9
cecyc
0
38
cecyc
3
1.1k
cecyc
1
260
cecyc
1
33
cecyc
0
81
Other Decks in Technology
See All in Technology
hmatsu47
0
120
y0hgi
1
400
ishiayaya
PRO
0
350
yasuakiomokawa
0
370
clustervr
0
200
kanaugust
PRO
0
240
ryusa
2
260
neo_analytics
1
1.1k
takapi86
0
150
ocise
1
970
hsano
0
130
ocise
0
160
Featured
See All Featured
holman
288
130k
addyosmani
494
110k
philhawksworth
192
8.8k
destraynor
223
47k
revolveconf
200
9.6k
jlugia
216
16k
lynnandtonic
271
16k
addyosmani
1348
190k
destraynor
146
19k
gr2m
83
11k
morganepeng
17
1.1k
jakevdp
775
200k
Transcript
Surviving Code Reviews & Tech Interviews Cecy Correa // @cecycorrea
// The Lead Dev Austin Meetup November 2019 1 Surviving Code Reviews & Tech Interviews {vulnerability: true}
Hi, I’m Cecy! @cecycorrea Surviving Code Reviews & Tech
Interviews 2
I want to talk about vulnerability & failure 3 Surviving
Code Reviews & Tech Interviews
code reviews & tech interviews Surviving Code Reviews & Tech
Interviews 4
Code Reviews Building bullet proof PRs 5 Surviving Code Reviews
& Tech Interviews
6 Surviving Code Reviews & Tech Interviews
Why does this happen?
How does it make you feel? 8 Surviving Code Reviews
& Tech Interviews
Find a way to get control back 9 Surviving Code
Reviews & Tech Interviews
Create a bullet-proof pull request 10 Surviving Code Reviews &
Tech Interviews
DISTRACTIONS 11 Surviving Code Reviews & Tech Interviews
Presentation theme goes here Bullet-proof PRs • Make your PR
as small as possible • Provide context • Provide visuals (where applicable) 12 Surviving Code Reviews & Tech Interviews
Small PRs aka Extreme Slicing EXTREME SLICING is the practice
of breaking down a task into its smallest possible sub-tasks 13 Surviving Code Reviews & Tech Interviews SMOL BOI
Presentation theme goes here Put your PR in Context •
Context is king • JIRA / Trello / ticket • Problem you’re solving • Solution 14 Surviving Code Reviews & Tech Interviews THE CONTEXT KING
Surviving Code Reviews & Tech Interviews 15
Bullet-proof PRs •Are small •Provide context 16 Surviving Code Reviews
& Tech Interviews
Presentation theme goes here What if that still doesn’t work?
17 Surviving Code Reviews & Tech Interviews
It’s part of a larger systemic issue Surviving Code Reviews
& Tech Interviews 18
Surviving Code Reviews & Tech Interviews 19
How do we collectively improve? Surviving Code Reviews & Tech
Interviews
Presentation theme goes here Define success as a team 21
Surviving Code Reviews & Tech Interviews
Establish a team Operating System Surviving Code Reviews & Tech
Interviews 22
“The ultimate goal is to improve the quality of the
code and the product, and any unpleasant tones of one-upmanship should be avoided. Remember that the code is not the author and the author is not the code. Do not take or make things personal.” 23 Surviving Code Reviews & Tech Interviews
Codify as a team how to provide feedback Surviving Code
Reviews & Tech Interviews 24
Feedback should be actionable Surviving Code Reviews & Tech Interviews
25
Feedback should be in context Surviving Code Reviews & Tech
Interviews 26
Feedback should not do the work for someone Surviving Code
Reviews & Tech Interviews 27
A note on “assume positive intent”
assume positive intent == burden on the receiver
assume people are smart competent here for a reason
Bullet-proof PRs •Are small •Provide context 31 Surviving Code Reviews
& Tech Interviews
Good feedback •Actionable •In context •Sets people on the right
path 32 Surviving Code Reviews & Tech Interviews
</code reviews>
Tech interviews Surviving Code Reviews & Tech Interviews 34
The rule about technical interview club is… Surviving Code Reviews
& Tech Interviews 35
Surviving Code Reviews & Tech Interviews 36
Surviving Code Reviews & Tech Interviews 37
Surviving Code Reviews & Tech Interviews
People perform inconsistently Surviving Code Reviews & Tech Interviews 39
Surviving Code Reviews & Tech Interviews 40
People suck at gauging their own performance Surviving Code Reviews
& Tech Interviews 41
Surviving Code Reviews & Tech Interviews
"When people think they did poorly, even if they actually
didn’t, they may be a lot less likely to want to work with you.” Surviving Code Reviews & Tech Interviews 43
Improving the tech interview experience
Hiring at Thinkful •Take home code challenge •Talk through solution
•Add a feature •Open ended architecture
Start the interview by establishing a baseline
Fix tech interview process? Prioritize hiring.
Thank you