Surviving Code Reviews & Tech Interviews

Transcript

1. Surviving Code Reviews & Tech Interviews Cecy Correa // @cecycorrea

   // The Lead Dev Austin Meetup November 2019 1 Surviving Code Reviews & Tech Interviews {vulnerability: true}

2. Hi, I’m Cecy! 
 @cecycorrea Surviving Code Reviews & Tech

   Interviews 2

3. I want to talk about vulnerability & failure 3 Surviving

   Code Reviews & Tech Interviews

4. code reviews & tech interviews Surviving Code Reviews & Tech

   Interviews 4

5. Code Reviews Building bullet proof PRs 5 Surviving Code Reviews

   & Tech Interviews

6. 6 Surviving Code Reviews & Tech Interviews

7. Why does this happen?

8. How does it make you feel? 8 Surviving Code Reviews

   & Tech Interviews

9. Find a way to get control back 9 Surviving Code

   Reviews & Tech Interviews

10. Create a bullet-proof pull request 10 Surviving Code Reviews &

    Tech Interviews

11. DISTRACTIONS 11 Surviving Code Reviews & Tech Interviews

12. Presentation theme goes here Bullet-proof PRs • Make your PR

    as small as possible • Provide context • Provide visuals
 (where applicable) 12 Surviving Code Reviews & Tech Interviews

13. Small PRs aka Extreme Slicing EXTREME SLICING is the practice

    of breaking down a task into its smallest possible sub-tasks 13 Surviving Code Reviews & Tech Interviews SMOL BOI

14. Presentation theme goes here Put your PR in Context •

    Context is king • JIRA / Trello / ticket • Problem you’re solving • Solution 14 Surviving Code Reviews & Tech Interviews THE CONTEXT KING

15. Surviving Code Reviews & Tech Interviews 15

16. Bullet-proof PRs •Are small •Provide context 16 Surviving Code Reviews

    & Tech Interviews

17. Presentation theme goes here What if that still doesn’t work?

    17 Surviving Code Reviews & Tech Interviews

18. It’s part of a larger systemic issue Surviving Code Reviews

    & Tech Interviews 18

19. Surviving Code Reviews & Tech Interviews 19

20. How do we collectively improve? Surviving Code Reviews & Tech

    Interviews

21. Presentation theme goes here Define success as a team 21

    Surviving Code Reviews & Tech Interviews

22. Establish a team Operating System Surviving Code Reviews & Tech

    Interviews 22

23. “The ultimate goal is to improve the quality of the

    code and the product, and any unpleasant tones of one-upmanship should be avoided. Remember that the code is not the author and the author is not the code. Do not take or make things personal.” 23 Surviving Code Reviews & Tech Interviews

24. Codify as a team how to provide feedback Surviving Code

    Reviews & Tech Interviews 24

25. Feedback should be actionable Surviving Code Reviews & Tech Interviews

    25

26. Feedback should be in context Surviving Code Reviews & Tech

    Interviews 26

27. Feedback should not do the work for someone Surviving Code

    Reviews & Tech Interviews 27

28. A note on “assume positive intent”

29. assume positive intent == burden on the receiver

30. assume people are 
 smart competent
 here for a reason

31. Bullet-proof PRs •Are small •Provide context 31 Surviving Code Reviews

    & Tech Interviews

32. Good feedback •Actionable •In context •Sets people on the right

    path 32 Surviving Code Reviews & Tech Interviews

33. </code reviews>

34. Tech interviews Surviving Code Reviews & Tech Interviews 34

35. The rule about technical interview club is… Surviving Code Reviews

    & Tech Interviews 35

36. Surviving Code Reviews & Tech Interviews 36

37. Surviving Code Reviews & Tech Interviews 37

38. Surviving Code Reviews & Tech Interviews

39. People perform inconsistently Surviving Code Reviews & Tech Interviews 39

40. Surviving Code Reviews & Tech Interviews 40

41. People suck at gauging their own performance Surviving Code Reviews

    & Tech Interviews 41

42. Surviving Code Reviews & Tech Interviews

43. "When people think they did poorly, even if they actually

    didn’t, they may be a lot less likely to want to work with you.” Surviving Code Reviews & Tech Interviews 43

44. Improving the tech interview experience

45. Hiring at Thinkful •Take home code challenge •Talk through solution

    •Add a feature •Open ended architecture

46. Start the interview by establishing a baseline

47. Fix tech interview process? Prioritize hiring.

48. Thank you