Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Surviving Code Reviews & Tech Interviews
Search
Cecy C.
November 07, 2019
Technology
0
86
Surviving Code Reviews & Tech Interviews
Presented at The Lead Dev Austin Meetup, November 7th, 2019.
Cecy C.
November 07, 2019
Tweet
Share
More Decks by Cecy C.
See All by Cecy C.
LinkedIn Data Breach 2012 Case Study
cecyc
0
4.9k
Vulnerability True: Surviving Brutal Code Reviews and Tech Interviews
cecyc
0
150
The Joy of CSS: RailsConf 2019
cecyc
0
160
RubyConf 2018 Psychology of Fake News
cecyc
0
82
A Retro of Retros: How Sprint Retrospectives Can Be Both Fun and Productive
cecyc
0
150
MONKTOBERFEST 2018: Psychology of Fake News
cecyc
0
80
From Monolith to Microservice: Building APIs with gRPC & golang
cecyc
3
1.7k
Building APIs with GRPC, PHP, and Golang
cecyc
1
540
The Psychology of Fake News (And What Tech Can Do About It)
cecyc
1
58
Other Decks in Technology
See All in Technology
Qiita Organizationを導入したら、アウトプッターが爆増して会社がちょっと有名になった件
minorun365
PRO
1
320
Snowflakeの開発・運用コストをApache Icebergで効率化しよう!~機能と活用例のご紹介~
sagara
1
530
Amazon Q Developerの無料利用枠を使い倒してHello worldを表示させよう!
nrinetcom
PRO
2
120
【Forkwell】「正しく」失敗できるチームを作る──現場のリーダーのための恐怖と不安を乗り越える技術 - FL#83 / A team that can fail correctly by forkwell
i35_267
1
100
マルチアカウント環境における組織ポリシーについて まとめてみる
nrinetcom
PRO
2
110
リクルートのエンジニア組織を下支えする 新卒の育成の仕組み
recruitengineers
PRO
2
180
職位にかかわらず全員がリーダーシップを発揮するチーム作り / Building a team where everyone can demonstrate leadership, regardless of position
madoxten
3
1.4k
AWSではじめる Web APIテスト実践ガイド / A practical guide to testing Web APIs on AWS
yokawasa
8
780
フォーイット_エンジニア向け会社紹介資料_Forit_Company_Profile.pdf
forit_tech
1
1.7k
EDRの検知の仕組みと検知回避について
chayakonanaika
12
5.3k
OCI Success Journey OCIの何が評価されてる?疑問に答える事例セミナー(2025年2月実施)
oracle4engineer
PRO
2
220
Log Analytics を使った実際の運用 - Sansan Data Hub での取り組み
sansantech
PRO
0
110
Featured
See All Featured
We Have a Design System, Now What?
morganepeng
51
7.4k
Code Reviewing Like a Champion
maltzj
521
39k
The Illustrated Children's Guide to Kubernetes
chrisshort
48
49k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.2k
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
irinanazarova
6
580
4 Signs Your Business is Dying
shpigford
183
22k
The Cult of Friendly URLs
andyhume
78
6.2k
Optimizing for Happiness
mojombo
377
70k
A Philosophy of Restraint
colly
203
16k
Fight the Zombie Pattern Library - RWD Summit 2016
marcelosomers
233
17k
Mobile First: as difficult as doing things right
swwweet
223
9.5k
jQuery: Nuts, Bolts and Bling
dougneiner
63
7.7k
Transcript
Surviving Code Reviews & Tech Interviews Cecy Correa // @cecycorrea
// The Lead Dev Austin Meetup November 2019 1 Surviving Code Reviews & Tech Interviews {vulnerability: true}
Hi, I’m Cecy! @cecycorrea Surviving Code Reviews & Tech
Interviews 2
I want to talk about vulnerability & failure 3 Surviving
Code Reviews & Tech Interviews
code reviews & tech interviews Surviving Code Reviews & Tech
Interviews 4
Code Reviews Building bullet proof PRs 5 Surviving Code Reviews
& Tech Interviews
6 Surviving Code Reviews & Tech Interviews
Why does this happen?
How does it make you feel? 8 Surviving Code Reviews
& Tech Interviews
Find a way to get control back 9 Surviving Code
Reviews & Tech Interviews
Create a bullet-proof pull request 10 Surviving Code Reviews &
Tech Interviews
DISTRACTIONS 11 Surviving Code Reviews & Tech Interviews
Presentation theme goes here Bullet-proof PRs • Make your PR
as small as possible • Provide context • Provide visuals (where applicable) 12 Surviving Code Reviews & Tech Interviews
Small PRs aka Extreme Slicing EXTREME SLICING is the practice
of breaking down a task into its smallest possible sub-tasks 13 Surviving Code Reviews & Tech Interviews SMOL BOI
Presentation theme goes here Put your PR in Context •
Context is king • JIRA / Trello / ticket • Problem you’re solving • Solution 14 Surviving Code Reviews & Tech Interviews THE CONTEXT KING
Surviving Code Reviews & Tech Interviews 15
Bullet-proof PRs •Are small •Provide context 16 Surviving Code Reviews
& Tech Interviews
Presentation theme goes here What if that still doesn’t work?
17 Surviving Code Reviews & Tech Interviews
It’s part of a larger systemic issue Surviving Code Reviews
& Tech Interviews 18
Surviving Code Reviews & Tech Interviews 19
How do we collectively improve? Surviving Code Reviews & Tech
Interviews
Presentation theme goes here Define success as a team 21
Surviving Code Reviews & Tech Interviews
Establish a team Operating System Surviving Code Reviews & Tech
Interviews 22
“The ultimate goal is to improve the quality of the
code and the product, and any unpleasant tones of one-upmanship should be avoided. Remember that the code is not the author and the author is not the code. Do not take or make things personal.” 23 Surviving Code Reviews & Tech Interviews
Codify as a team how to provide feedback Surviving Code
Reviews & Tech Interviews 24
Feedback should be actionable Surviving Code Reviews & Tech Interviews
25
Feedback should be in context Surviving Code Reviews & Tech
Interviews 26
Feedback should not do the work for someone Surviving Code
Reviews & Tech Interviews 27
A note on “assume positive intent”
assume positive intent == burden on the receiver
assume people are smart competent here for a reason
Bullet-proof PRs •Are small •Provide context 31 Surviving Code Reviews
& Tech Interviews
Good feedback •Actionable •In context •Sets people on the right
path 32 Surviving Code Reviews & Tech Interviews
</code reviews>
Tech interviews Surviving Code Reviews & Tech Interviews 34
The rule about technical interview club is… Surviving Code Reviews
& Tech Interviews 35
Surviving Code Reviews & Tech Interviews 36
Surviving Code Reviews & Tech Interviews 37
Surviving Code Reviews & Tech Interviews
People perform inconsistently Surviving Code Reviews & Tech Interviews 39
Surviving Code Reviews & Tech Interviews 40
People suck at gauging their own performance Surviving Code Reviews
& Tech Interviews 41
Surviving Code Reviews & Tech Interviews
"When people think they did poorly, even if they actually
didn’t, they may be a lot less likely to want to work with you.” Surviving Code Reviews & Tech Interviews 43
Improving the tech interview experience
Hiring at Thinkful •Take home code challenge •Talk through solution
•Add a feature •Open ended architecture
Start the interview by establishing a baseline
Fix tech interview process? Prioritize hiring.
Thank you