クソコードの測り方

PHPBLT#3 で話した内容です。

Transcript

1. Ϋιίʔυͷ

   ଌΓํ
   PHPBLT #3
   @Hiraku
   

   View Slide

2. ࣗݾ঺հ
   • த໺ ୓ (@Hiraku)
   • ޱบʮcomposer͕஗͍ʯʮޫ͕஗͍ʯˡNew!
   • ޫ஗͍໰୊Λࠀ෰ͯ͠composerΛ10ഒ଎ͨ͘͠࿩

   http://tech.mercari.com/entry/2016/02/01/164829
   

   View Slide

3. hirak/prestissimo 

   (composerߴ଎ԽϓϥάΠϯ)
   Πϯετʔϧ͢Δ͚ͩͰ10ഒ͙Β͍଎͘ͳΓ·͢
   

   View Slide

4. hirak/prestissimo
   • ͝੠ԉ͋Γ͕ͱ͏͍͟͝·͢
   

   View Slide

5. prestissimoΛൃද͔ͯ͠Β

   Ұϲ݄
   

   View Slide

6. ͜͜Ұϲ݄ͷ੒Ռ
   →
   1/24 2/28
   

   View Slide

7. Scrutinizer
   • ίʔυ඼࣭ʹ఺਺Λ͚ͭΔαʔϏε (OSSͳΒແྉʂ)
   • όάͬΆ͍ॴΛݟ͚ͭͯ͘ΕΔ
   • 10఺ຬ఺
   

   View Slide

8. ϝιουผͷ఺਺
   

   View Slide

9. ScrutinizerείΞͷ্͛ํ
   • ྘৭(AϥϯΫ)ͷϝιου͹͔ΓʹͳͬͨΒɺ
   10.00ʹͳΔ
   • ଌఆ݁Ռ͸৭ʑग़ͯ͘Δ͕ɺͲ͜Λमਖ਼͢Ε
   ͹͍͍ͷ͔ʁ
   

   View Slide

10. ͜͜ʹ஫໨
    

    View Slide

11. C.R.A.P.
    =Change Risk Anti-Patterns
    

    View Slide

12. ௚༁͢Δͱ

    Ϋι౓
    

    View Slide

13. CRAPͱ͸
    • Ϋιίʔυͷ౓߹͍Λఆྔతʹදͨ͠਺ࣈ
    • 1ʙແݶେ
    • If CRAP1(m) > 30, we consider the method
    to be CRAPpy.
    

    View Slide

14. Googleͷϒϩά͕ৄ͍͠
    http://googletesting.blogspot.jp/2011/02/this-code-is-crap.html
    

    View Slide

15. View Slide

16. comp(m) = ॥؀తෳࡶ౓
    cov(m) = ςετΧόϨοδ
    

    View Slide

17. comp(m)=॥؀తෳࡶ౓
    • ίʔυͷ෼ذΛ਺͑ͨ΋ͷ
    • if΍forΛ࢖͏ͱ1ͣͭ૿͑Δ(্ݶ͸ͳ͍)
    • ෼ذ͕ͳ͚Ε͹1
    

    View Slide

18. cov(m)=ςετΧόϨοδ
    • ϢχοτςετͰ࣮ߦ͞Εͨίʔυͷׂ߹
    • ͜͜Ͱݴ͏ΧόϨοδ͸C0ΧόϨοδͷ͜ͱ

    Ұ౓Ͱ΋શߦ࣮ߦ͍ͯ͠Ε͹100%
    • 0%ʙ100%ͷؒͷ਺ࣈ
    

    View Slide

19. cov(m)͕100%ͩͬͨΒ
    ͕͜͜0ʹͳΔΑͶ
    

    View Slide

20. comp(m)=1, cov(m)=0%
    ͕͜͜1ʹͳΔΑͶ
    ͜͜΋1ʹͳΔΑͶ
    

    View Slide

21. CRAPͱม਺ͷؔ܎
    • comp(m) ্͕͕Δͱ
    2৐ͷ੎͍Ͱ૿͑Δ
    • cov(m)্͕͕Δͱগ
    ͠؇࿨͞ΕΔ
    • ΧόϨοδ͕100%Ͱ
    ΋ɺෳࡶ౓͕30Λ௒
    ͍͑ͯͨΒμϝ
    

    View Slide

22. ྘৭͕CRAP<30
    

    View Slide

23. CRAPείΞͷԼ͛ํ
    

    View Slide

24. جຊతͳϧʔϧ
    • ෳࡶ౓͸ϝιουผͳͷͰɺࡉ͔͘෼ׂ͢Δ
    ͱݮΔ
    • ϢχοτςετΛॻ͚͹ݮΔ
    

    View Slide

25. ݱ࣮తͳ࿩
    • ෳࡶͳίʔυ͸Ϣχοτςετͮ͠Β͍
    • ςετ͠΍͘͢ॻ͖׵͑ͯΏ͘
    • →ࣗવͱίʔυ͕෼ׂ͞ΕΔʂ
    

    View Slide

26. ιʔεΛ୹͘͢Δ
    • ಉ͡ϩδοΫΛ୹͍ίʔυͰ࠶ݱ͢Δ
    • ϥΠϒϥϦؔ਺ͷ׆༻
    • ίϐϖΛݮΒͯؔ͠਺ڞ௨Խ
    • ࠶ؼʹॻ͖׵͑Δ
    

    View Slide

27. PHPUnitͰ΋CRAPܭଌ
    • ΧόϨοδϨϙʔτͰCRAPείΞಡΊ·͢
    

    View Slide

28. prestissimoͷي੻
    

    View Slide

29. View Slide

30. View Slide

31. View Slide

32. ࠓ೔ͷ·ͱΊ
    • ΫιίʔυΛఆྔతʹ൑ఆ͢Δํ๏͕͋Δ
    • ଌͬͯΈΔͱ໘ന͍ΑɺPHPUnitͰ΋Θ͔ΔΑ
    • Ғͦ͏ʹղઆ͚ͨ͠ͲScrutinizerείΞ10.00
    ·ͩ౸ୡͯ͠ͳ͍
    

    View Slide

33. ิ଍ɿ

    CRAP͕ڭ͑ͯ͘Εͳ͍΋ͷ
    • ιϑτ΢ΣΞ͕଎͍͔Ͳ͏͔
    • ໾ʹཱ͔ͭʢΧωΛੜΉ͔ʣ
    • ֦ுੑʹ༏Ε͍ͯΔ͔
    (͋͘·Ͱෳࡶ౓ͷ࿩Ͱ͋Δ͜ͱʹ஫ҙ)
    

    View Slide