DX Improvements

DX Improvements
Keishin Yokomaku (@KeithYokoma) / Merpay, Inc.

View Slide

Developer Experience
։ൃମݧ
merpay Android Engineers meetup

View Slide

DX Improvements
Why DX matters?
▸ ϓϩμΫτ͸೔ʑ੒௕Λଓ͚Δ
▸ ৽ػೳͷ௥Ճ
▸ طଘػೳͷվम
▸ όάमਖ਼
▸ ͳͲ
3

View Slide

DX Improvements
Why DX matters?
▸ ιʔείʔυ΋ຖ೔มԽΛ͠ଓ͚Δ
▸ ৽͍͠Ϋϥεɾϝιουͷ௥Ճ
▸ طଘΫϥεɾϝιουͷৼΔ෣͍ͷมߋ
▸ Ϣχοτςετͷ௥Ճɾߋ৽
▸ ͳͲ
4

View Slide

DX Improvements
Why DX matters?
▸ ୹ظؒͷΠςϨʔγϣϯΛܧଓ͠ɺϓϩμΫτΛ੒௕ͤ͞Δϓϩηε
▸ ΞδϟΠϧ
▸ 1 ~ 2 िؒͷεϓϦϯτ
▸ ࡉ͔͘ϓϥϯχϯά͠ɺࡉ͔͘੒Ռ෺ΛੵΈ্͍͛ͯ͘
X

View Slide

DX Improvements
Why DX matters?
▸ มԽ΁ͷదԠ͕ٻΊΒΕଓ͚Δ
▸ ૉૣ͍ػೳ࣮૷ʢࡉ͔͘࡞Γ্͍͛ͯ͘ϓϩηεͷ܁Γฦ͠ʣ
▸ ૉૣ͍ৼΓฦΓʢࡉֶ͔͘ͼΛൃݟ͠దԠ͍ͯ͘͠ϓϩηεͷ܁Γฦ͠ʣ
▸ ͜ΕΒ͕͏·͘Ͱ͖͍ͯΔ͔Ͳ͏͔Ͱ DX ͕ܾ·Δ
5

View Slide

DX Improvements
Good DX
▸ ૉૣ͍ػೳ࣮૷Λ࣮ݱ͢Δ͜ͱ͕Β
▸ มߋʹͭΑ͍ઃܭ΍ςετͷ࢓૊Έ
▸ ໨తʹ͔ͳͬͨϑϨʔϜϫʔΫͷར༻
▸ ݟੵ΋ΓͷͨΊͷυϝΠϯ஌ࣝ
▸ ݟੵ΋ΓͷͨΊͷٕज़త஌ݟɾܦݧ
▸ ͳͲ
6

View Slide

DX Improvements
Good DX
▸ ૉૣ͍ৼΓฦΓΛ࣮ݱ͢Δ͜ͱ͕Β
▸ ఆظతͳৼΓฦΓͱ۩ମతͳΞΫγϣϯͷ࣮ߦ
▸ νʔϜ಺Ͱͷ໰୊ೝࣝͷ໨ઢ͕͍͋ͬͯΔ
▸ νʔϜ಺Ͱͷղܾࡦͷ໨ઢ͕͍͋ͬͯΔ
7

View Slide

DX Improvements
Bad DX
▸ ૉૣ͍ػೳ࣮૷Λ્֐͢Δ͜ͱ͕Β
▸ ৽ػೳ͕ଞͷطଘػೳʹӨڹΛ༩͑Δ
▸ όάमਖ਼͕ผͷόάΛݺͿ
▸ ςετ͕ॻ͖ͮΒ͍ɾॻ͍͍ͯͳ͍
▸ ଞͷมߋࠩ෼ͱͷίϯϑϦΫτ͕ଟ͍
▸ ͳͲ
8

View Slide

DX Improvements
Bad DX
▸ ૉૣ͍ৼΓฦΓΛ્֐͢Δ͜ͱ͕Β
▸ ৼΓฦΒͳ͍
▸ ௿͍৺ཧత҆શੑ
▸ ՝୊ײ͕ڞ༗Ͱ͖ͳ͍ɺվળఏҊΛ͠ͳ͍ɺͳͲ
▸ ղܾࡦ͕͏·͘ػೳ͔ͨ͠ܭଌ͠ͳ͍
▸ ͳͲ
9

View Slide

DX Improvements
Why DX matters?
▸ ѱ͍ DX ͸ϓϩμΫτͷܧଓతͳ੒௕Λ๦͛ͯ͠·͏
▸ ਎ಈ͖͕औΓͮΒ͘ͳΓٻΊΒΕΔεϐʔυͰ։ൃ͕͢͢·ͳ͘ͳΔ
▸ DX ͸์͓ͬͯ͘ͱѱ͘ͳΔ
▸ ׂΕ૭ཧ࿦
▸ ୭Ͱ΋ׂΕ૭͸࡞ͬͯ͠·͏΋ͷ
▸ ͕࣌ؒͨͭͱউखʹ૭ׂ͕ΕΔ͜ͱ΋͋Δ
10

View Slide

DX Improvements
DX (Developer Experience) Improvements
▸ ։ൃମݧΛܧଓతʹϝϯςφϯε͢Δ͜ͱɾͦͷϚωδϝϯτ
11

View Slide

View Slide

ϝϧϖΠ Android
νʔϜͰͷऔΓ૊Έ

View Slide

DX Improvements
DX (Developer Experience) Improvements in Merpay Android
▸ ϝϧϖΠ Android νʔϜͰ࣮ࢪͨ͠ DX վળͷΞΫγϣϯ
1. ݱঢ়෼ੳ
2. վળఏҊ
3. ࣮ߦ
14

View Slide

ݱঢ়෼ੳ

View Slide

DX Improvements
Analyze: ݱঢ়෼ੳ
▸ KPT
▸ ͏·͘Ͱ͖͍ͯΔͱࢥ͍ͬͯΔ͜ͱ
▸ վળ͍ͨ͠ͱࢥ͍ͬͯΔ͜ͱ
▸ վળͷ༏ઌॱҐ෇͚
▸ ՝୊ʹର͢Δશһͷ໨ઢΛ߹ΘͤΔͨΊͷଧͪख
16

View Slide

DX Improvements
▸ ͏·͘Ͱ͖͍ͯΔͱࢥ͍ͬͯΔ͜ͱ
▸ ϚϧνϞδϡʔϧͰ Feature ͝ͱʹ෼཭ͨ݁͠Ռɺେਓ਺Ͱ΋ίϯϑϦΫτ͕
গͳ͘։ൃΛਐΊΒΕ͍ͯΔ
▸ Redux Ͱঢ়ଶͷભҠͷݟ௨ཱ͕ͯ͠ΒΕ͍ͯΔɺςετ͕ॻ͖΍͍͢
▸ σʔλϨΠϠʔ͕੔උ͞Ε͍ͯͯ୯७ʹཧղͰ͖Δ
▸ ͳͲ…
17

View Slide

DX Improvements
▸ վળ͍ͨ͠ͱࢥ͍ͬͯΔ͜ͱ
▸ ςετΧόϨοδ͕௿͍ɻಛʹ View ϨΠϠʔͷςετ͕ॻ͚͍ͯͳ͍ɻ
▸ ෳࡶͰϒϥοΫϘοΫεͳφϏήʔγϣϯϑϨʔϜϫʔΫͷཧղ͕େมɻ
▸ Ϟδϡʔϧ͝ͱʹॻ͖ํͷ౷Ұײ͕ͳ͍͜ͱ͕͋Δɻ
▸ CI ʹ͕͔͔࣌ؒΓ͗ͯ͢͠·͍଴͕ͪൃੜ͍ͯ͠Δɻ
▸ ͳͲ…
18

View Slide

DX Improvements
▸ վળͷ༏ઌॱҐ෇͚: νʔϜ͕࠷΋ࠔ͍ͬͯͦ͏ͳ͜ͱ
▸ ςετΧόϨοδͷෆ଍
▸ ෳࡶͳφϏήʔγϣϯϑϨʔϜϫʔΫ
▸ ٕज़తͳཧ༝Ͱ଴ͪͷଟ͍։ൃϓϩηεɾϫʔΫϑϩʔ
▸ ஌ࣝɾ஌ݟͷଐਓԽ
19

View Slide

DX Improvements
20
ʹ ٕज़తෛ࠴

View Slide

DX Improvements
21
ʹ DevOps

View Slide

DX Improvements
22
ʹ ҉໧ͷ஌ࣝ

View Slide

DX Improvements
▸ ࠷༏ઌͰऔΓ૊Ή΂͖՝୊ྖҬ
1. ҉໧ͷ஌ࣝͷղফ
2. ٕज़తෛ࠴ͷղফ
3. DevOps ͷվળ
23

View Slide

վળఏҊ

View Slide

DX Improvements
Strategy Proposal: վળఏҊ
▸ ՝୊ྖҬ͝ͱʹऔΓ૊ΈΛϒϨΠΫμ΢ϯ͢Δ
3. DevOps ͷվળ
25

View Slide

DX Improvements
‣ Be on the same page: 
νʔϜ͕҉໧తʹ͍࣋ͬͯΔ஌ࣝΛڞ༗͠ܗࣜԽ͢Δ࡞ઓ
26

View Slide

DX Improvements
‣ Foundation Makeup: 
ςετΛॻ͖΍͘͢͢ΔͨΊͷ࢓૊ΈԽ΍ϘΠϥʔϓϨʔτͷղফͳͲ 
ػೳ։ൃΛࢧԉ͢ΔͨΊͷج൫Λͭ͘Δ࡞ઓ
‣ Foundation Refactoring: 
ෳࡶͳφϏήʔγϣϯΛ؆ૉԽ͢Δ࡞ઓ
27

View Slide

DX Improvements
3. DevOps ͷվળ
‣ CI Campaign - Make the CI great again: 
೔ʑͷ։ൃϫʔΫϑϩʔͷதͰগͳ͔Β͵࣌ؒΛ઎ΊΔ CI Λվળ͢Δ࡞ઓ
‣ United we code, United we ship: 
ϝϧϖΠͷػೳΛϝϧΧϦΞϓϦʹ౷߹͢ΔεςοϓΛվળ͢Δ࡞ઓ
28

View Slide

DX Improvements
Milestone Proposal: վળఏҊ
▸ ͦΕͧΕͷऔΓ૊Έʹ͍ͭͯυΩϡϝϯτԽ͠ڞ༗
▸ Background: औΓ૊Έʹࢸͬͨഎܠ͸ͳʹ͔
▸ Objective: Ͳ͏͍͏໨తͰऔΓ૊Ήͷ͔
▸ Goal: ԿΛͲ͜·ͰऔΓ૊Ήͷ͔
▸ Steps/Approaches: Ͳ͏΍ͬͯऔΓ૊Ήͷ͔
▸ վળͷ໨త͔Βํ๏ʹࢸΔ·ͰɺνʔϜͰͷ໨ઢΛ͋ΘͤΔ
29

View Slide

࣮ߦ

View Slide

҉໧ͷ஌ࣝͷղফ

View Slide

DX Improvements
Tacit Knowledge: ҉໧ͷ஌ࣝ
▸ νʔϜͱͯ͠ͷ՝୊
1. ϑϨʔϜϫʔΫʹ͍ͭͯ஌͍ͬͯΔਓɾ͞ΘΕΔਓ͕ݶΒΕ͍ͯΔ
2. ਓʹΑͬͯࡉ͔͍࣮૷ํ๏΋·ͪ·ͪͳࣄ͕͋Δ
‣ ஌ࣝͷଐਓԽ͕ڧ͘ɺڞ༗͢΂͖஌͕ࣝڞ༗Ͱ͖͍ͯͳ͍
32

View Slide

DX Improvements
ϝϧϖΠ Android ͷऔΓ૊Έ
▸ νʔϜ͕͍࣋ͬͯΔ҉໧ͷ஌ࣝΛܗࣜԽ͢Δ
1. ࢀߟ࣮૷ͷϝϯςφϯε
2. φϨοδγΣΞͷଅਐ
33

View Slide

DX Improvements
ࢀߟ࣮૷ (sample app) ͷϝϯςφϯε
▸ ϝϧϖΠ Android Ͱ࠾༻͍ͯ͠ΔΞʔΩςΫνϟͷࢀߟ࣮૷ΞϓϦ
▸ MVVM + Redux ͷ࣮૷ྫ͕͋ͬͨ
▸ Controller ΍ Navigation ͷ࣮૷ྫ͕ͳ͔ͬͨ: => ࡞Δ
▸ TODO
▸ ΑΓݱ࣮ʹଈ࣮ͨ͠૷ྫ: ωοτϫʔΫ I/O ͳͲ…
▸ KDoc ΍ Wiki ͸ʁ
34

View Slide

DX Improvements
φϨοδγΣΞͷଅਐ
▸ ִि༵ۚͰϥϯν݉ษڧձΛ։࠵
▸ ͜Ε·Ͱ7ճ։࠵
▸ ऴྃ࣌ʹαʔϕΠΛ࣮ࢪ
▸ ͲΜͳ͜ͱ͕஌ΕͯΑ͔͔ͬͨ
▸ ΋ͬͱ஌Γ͍ͨ͜ͱ͸ͲΜͳ͜ͱ͔
35

View Slide

DX Improvements
▸ ͜Ε·Ͱͷ಺༰
▸ ؆ૉԽͨ͠φϏήʔγϣϯͷ࢓૊Έͷ঺հ
▸ Mockk ʹΑΔςετ
▸ View ϨΠϠͷߏ੒ͱϢχοτςετ
▸ ϩάऔಘͷޮՌతͳ࣮૷ྫ
▸ ͳͲ…
36

View Slide

DX Improvements
▸ औΓ૊Έͷ݁Ռ
▸ ٕज़తෛ࠴ͷղফͷऔΓ૊Έ͕͏·͘ճ͖͍ͬͯͯΔ
▸ νʔϜ಺ͰΑΓΑ͍΍ΓํΛٞ࿦͢Δϕʔε͕Ͱ͖ͨ
37

View Slide

ٕज़తෛ࠴ͷղফ

View Slide

DX Improvements
Technical Debt: ٕज़తෛ࠴
▸ ϝϧϖΠ Android ๊͕͍ٕ͑ͯͨज़తෛ࠴
1. ݁߹౓ͷߴ͍ View ͱ௿͍ςετΧόϨοδ
2. ಠࣗφϏήʔγϣϯϑϨʔϜϫʔΫ
39

View Slide

DX Improvements
40

View Slide

DX Improvements
ϝϧϖΠ Android ͷઃܭ
▸ MVVM + Redux
41

View Slide

▸ MVVM + Redux
DX Improvements
42
DataSource
API Client
Storage
Model

View Slide

▸ MVVM + Redux
DX Improvements
43
DataSource
API Client
Storage
ViewModel
ViewModel
Reducer

View Slide

▸ MVVM + Redux
DX Improvements
44
DataSource
API Client
Storage
View
ViewModel
Reducer
Controller

View Slide

DX Improvements
ϝϧϖΠ Android ͷઃܭ: MVVM + Redux
▸ ͜ͷઃܭΛ࠾༻ͨ͠ཧ༝
▸ ෳࡶͳঢ়ଶ؅ཧΛ Redux ͷॿ͚ΛआΓͯݟ௨͠Α࣮͘૷͍ͨ͠
▸ ঢ়ଶมԽΛؔ਺ͱͯ͠ఆٛ͠ɺϢχοτςετΛ؆୯ʹͰ͖ΔΑ͏ʹ͍ͨ͠
▸ View ͷؔ৺Λঢ়ଶʹԠͨ͡ View ͷૢ࡞ͱঢ়ଶมԽͷτϦΨʔʹݶఆ͍ͨ͠
45

View Slide

DX Improvements
MVVM + Redux: ͏·͘Ͱ͖ͨ͜ͱ
▸ Model ͕ϨΠϠԽ͞Ε͍ͯΔ
▸ ঢ়ଶΛද͢ΦϒδΣΫτΛఆٛͰ͖Δ
▸ ঢ়ଶભҠͷఆ͕ٛ Reducer ʹ·ͱΊΒΕΔ
▸ ঢ়ଶͷมԽΛ Reactive Extension ͰදݱͰ͖Δ
▸ View ͸ঢ়ଶΦϒδΣΫτͷมԽΛݕ஌ͯ͠ɺඞཁͳ View ͷૢ࡞ʹूத
46

View Slide

DX Improvements
ViewModel example: ొ৔ਓ෺
▸ Input: UI ͷΠϕϯτͱ ViewModel Ͱͷ Action ͷൃՐͷڮ౉͠໾
▸ Store: Redux ͷ Storeɻঢ়ଶΛอ࣋͠มԽ͕͋ͬͨΒ௨஌͢Δ
▸ Reducer: Redux ͷ ReducerɻAction ʹԠͨ͡ঢ়ଶભҠΛఆٛ͢Δ
▸ ViewModel: Input ͔Β Action Λ࡞Γग़͠ Store ʹ఻ୡ͢Δ
47

View Slide

DX Improvements
ViewModel ͷγʔέϯε: View ͔ΒͷೖྗΛड͚औΔ
X
View ViewModel Model Reducer
Store
Trigger Input by click

View Slide

DX Improvements
ViewModel ͷγʔέϯε: Action ΛൃՐ
X
Store
Dispatch loading Action

View Slide

DX Improvements
ViewModel ͷγʔέϯε: ঢ়ଶΛม͑Δ
X
Store
Recude Action

View Slide

DX Improvements
ViewModel ͷγʔέϯε: ঢ়ଶΛอଘ
X
Store
Recude Action
Change State

View Slide

DX Improvements
ViewModel ͷγʔέϯε: ঢ়ଶมԽΛ௨஌
X
Store
Recude Action
Change State
Notify state change

View Slide

DX Improvements
ViewModel ͷγʔέϯε: API ͔ΒσʔλΛऔͬͯ͘Δ
X
Store
Recude Action
Change State
Notify state change
Fetch data
Data

View Slide

DX Improvements
ViewModel ͷγʔέϯε: Action ΛൃՐ
X
Store
Recude Action
Change State
Notify state change
Fetch data
Data
Dispatch loaded Action

View Slide

DX Improvements
ViewModel ͷγʔέϯε: ঢ়ଶΛม͑ɺ௨஌͢Δ
48
Store
Recude Action
Change State
Notify state change
Fetch data
Data
Dispatch loaded Action
Recude Action
Change State
Notify state change

View Slide

DX Improvements
ViewModel example
class SampleViewModel(
private val input: SampleInput,
private val sampleDataSource: SampleDataSource
) {
private val store = Store(SampleState(), SampleReducer())
val state: Observable = store.states
fun onCreate() {
store.dispatch(
input.loadData.flatMap {
sampleDataSource.getData()
.map(::FinishDataLoadingAction)
.toObservable()
.startWith(StartDataLoadingAction())
}
)
}
}
49

View Slide

DX Improvements
ViewModel example
) {
fun onCreate() {
store.dispatch(
.toObservable()
}
)
}
}
X

View Slide

DX Improvements
ViewModel example
) {
fun onCreate() {
store.dispatch(
.toObservable()
}
)
}
}
50
StartDataLoadingAction FinishDataLoadingAction

View Slide

DX Improvements
Reducer example
class SampleReducer : Reducer {
overrider fun reduce(
current: SampleState,
action: SampleAction
): SampleState = when (action) {
is StartDataLoadingAction -> {
current.copy(
data = Loading()
)
}
is FinishDataLoadingAction -> {
current.copy(
data = Success(action.data)
)
}
}
}
51

View Slide

DX Improvements
MVVM + Redux: ͏·͘Ͱ͖ͨ͜ͱ
▸ Reducer ͷςετ
▸ Action Λೖྗͨ͠Βɺద੾ͳঢ়ଶʹભҠ͢Δ
▸ ViewModel ͷςετ
▸ Input ͔Βద੾ͳ Action Λ (ෳ਺ճ) ൃՐ͢Δ
52

View Slide

DX Improvements
▸ MVVM + Redux Ͱୡ੒Ͱ͖͍ͯΔ͜ͱ
✔ෳࡶͳঢ়ଶ؅ཧΛ Redux ͷॿ͚ΛआΓͯݟ௨͠Α࣮͘૷͍ͨ͠
✔ঢ়ଶมԽΛؔ਺ͱͯ͠ఆٛ͠ɺϢχοτςετΛ؆୯ʹͰ͖ΔΑ͏ʹ͍ͨ͠
‣ MVVM + Redux Ͱୡ੒Ͱ͖͍ͯͳ͍͜ͱ
? View ͷؔ৺Λঢ়ଶʹԠͨ͡ View ͷૢ࡞ͱঢ়ଶมԽͷτϦΨʔʹݶఆ͍ͨ͠
53

View Slide

DX Improvements
Conductor: View ϕʔεͷը໘ߏஙϥΠϒϥϦ
▸ Navigation Architecture Component ͕·ͩͳ͍ࠒ͔Β։ൃ͕࢝·ͬͨ
▸ Single Activity Ͱը໘ભҠΛ࣮ݱ͍ͨ͠
▸ Fragment ΑΓ΋γϯϓϧʹը໘Λѻ͍͍ͨ
▸ Fragment in Fragment…?
54

View Slide

DX Improvements
Conductor: View ϕʔεͷը໘ߏஙϥΠϒϥϦ
▸ Α͘࢖͏Ϋϥε
▸ Controller: 
Fragment ʹ૬౰͢ΔΫϥε
▸ Router: 
Navigation Architecture Component ͷ NavController ʹ૬౰͢ΔΫϥε
55

View Slide

DX Improvements
Controller example
class SampleController : Controller() {
private val input = SampleInput()
private val viewModel = SampleViewModel(input, SampleRepo())
override fun onAttach(view: View) {
super.onAttach(view)
button.setOnClickListener { input.loadData.input() }
viewModel.state
.subscribe { state ->
when (state.data) {
is Loading -> {
progressBar.isVisible = true
}
is Success -> {
progressBar.isVisible = false
}
is Failure -> {
}
}
}.addTo(compositeDisposable)
}
}
56

View Slide

DX Improvements
Controller example
viewModel.state
when (state.data) {
is Loading -> {
}
is Success -> {
}
is Failure -> {
}
}
}
}
X

View Slide

DX Improvements
View ͱͯ͠ͷ Controller
▸ View ͱ ViewModel ͷڮ౉͠
▸ Input ʹΑΔ ViewModel ΁ͷೖྗ
▸ Input ͱ͍͏ܗͰந৅Խ͍ͯ͠ΔͷͰ୯७
▸ State Λߪಡͯ͠ View Λૢ࡞
▸ ϩδοΫΛϕλॻ͖͍ͯͯ͠ີ݁߹͍ͯ͠Δ
57

View Slide

DX Improvements
ີ݁߹ͰςετΧόϨοδͷͳ͍ View
▸ State ͷߋ৽͔ΒͲͷΑ͏ʹ View Λૢ࡞͢Δ͔ςετͮ͠Β͍
▸ ViewModel ͷϞοΫ͕ͳ͍ͱ State ͕ྲྀͤͳ͍
▸ Activity ͳͲͱಉ͘͡ Controller ΠϯελϯεΛૉ௚ʹ͸࡞Εͳ͍
▸ ݁ՌςετΛॻ͔ͣʹखಈͰؤுͬͯ֬ೝ͍ͯͨ͠
58

View Slide

DX Improvements
ີ݁߹ͰςετΧόϨοδͷͳ͍ View
▸ View ͷ੹຿Λ͢΂ͯෛͬͨ Controller
▸ Controller ͸ Activity ΍ Fragment ͱಉ͡ Template Method Pattern ͷ࣮૷
▸ ϥΠϑαΠΫϧ͝ͱద੾ͳॲཧΛ͢Δ৔ॴ
▸ ͋Γ͕ͪͳ Fat Activity ݱ৅
▸ ద੾ͳ Delegate Λ࡞Γɺ 
Controller ͔Β͸ϥΠϑαΠΫϧ͝ͱద੾ͳϝιουݺͼग़͠ʹཹΊΔ
59

View Slide

DX Improvements
ViewDelegate
▸ State ʹԠͨ͡ View ͷૢ࡞ʹ໊લΛ͚ͭΔ
▸ Controller ͔ΒʮState Λߪಡͯ͠ View Λૢ࡞ʯ͢Δ໾ׂΛҕৡ
▸ ςετ͔Β೚ҙͷ State Λ publish ͢Ε͹ɺ 
ରԠ͢Δ View ͷૢ࡞͕Ͱ͖͔ͨͲ͏͔ݕূͰ͖Δ
▸ Controller ͸ϥΠϑαΠΫϧʹैͬͨΦϒδΣΫτͷ؅ཧΛ͢Δ͚ͩ
60

View Slide

DX Improvements
Controller example
super.onAttach()
viewModel.state
when (state.data) {
is Loading -> {
}
is Success -> {
}
is Failure -> {
}
}
}
}
61

View Slide

DX Improvements
ViewDelegate usage
private lateinit var viewDelegate: SampleContract.ViewDelegate
viewDelegate = SampleViewDelegate.of(view, input)
viewDelegate.setupButtonClick()
viewDelegate.subscribeState(viewModel.state).addTo(compositeDisposable)
}
}
62

View Slide

DX Improvements
ViewDelegate usage
private lateinit var viewDelegate: SampleContract.ViewDelegate
viewDelegate = SampleViewDelegate.of(view, input)
viewDelegate.setupButtonClick()
viewDelegate.subscribeState(viewModel.state) 
.addTo(compositeDisposable)
}
}
63

View Slide

DX Improvements
ViewDelegate implementation
class SampleViewDelegate private constructor(
override val button: Button,
override val progressBar: ProgressBar,
override val input: SampleInput
) : SampleContract.ViewDelegate {
override fun subscribeState(states: Observable) = state.subscribe { state ->
when (state.data) {
is Loading -> {
}
is Success -> {
}
is Failure -> {
}
}
}
64

View Slide

DX Improvements
‣ ViewDelegate Λಋೖͯ͠ୡ੒Ͱ͖ͨ͜ͱ
✔View ͷؔ৺Λ"ঢ়ଶʹԠͨ͡ View ͷૢ࡞ͱঢ়ଶมԽͷτϦΨʔ”ʹݶఆ
✔Controller ͸ϥΠϑαΠΫϧ؅ཧʹूத
✔ViewDelegate ʹΑͬͯঢ়ଶʹԠͨ͡ View ͷૢ࡞ΛϢχοτςετՄೳʹ
65

View Slide

DX Improvements
66

View Slide

DX Improvements
Multi-module ͰͷφϏήʔγϣϯ
▸ ଟ਺ͷ feature ϞδϡʔϧΛ΋ͭϚϧνϞδϡʔϧߏ੒
▸ Feature A ͔Β Feature B ΁ͷφϏήʔγϣϯͷͨΊʹ࢓૊Έ͕ඞཁ
▸ ͢΂ͯͷ feature ϞδϡʔϧΛ஌͍ͬͯΔϞδϡʔϧͰφϏήʔγϣϯΛఆٛ
67

View Slide

DX Improvements
68
OriginalController DestinationController
Feature B
Feature A

View Slide

DX Improvements
69
Feature B
Feature A

View Slide

DX Improvements
70
Feature B
Feature A
❌

View Slide

DX Improvements
71
Feature B
Feature A
Navgigation
OriginalNavigator

View Slide

DX Improvements
▸ ॳظͷಠࣗφϏήʔγϣϯϑϨʔϜϫʔΫ
▸ Conductor ͷφϏήʔγϣϯ෦෼Λϥοϓͨ͠΋ͷ
▸ όοΫελοΫͳͲҰ෦ঢ়ଶΛಠࣗ؅ཧ͢Δ෦෼͕͋Δ
▸ ࣮૷
▸ Controller ʹφϏήʔγϣϯ༻ͷϥϜμΛఆٛ
▸ ରԠ͢Δ Navigator ΫϥεͰϥϜμͷ࣮૷Λࢗ͢
72

View Slide

DX Improvements
Conductor ʹ͓͚ΔφϏήʔγϣϯͷ࢓૊Έ
class OriginalController : Controller() {
fun onButtonClick() {
router.pushController(
RouterTransaction.with(DestinationController())
)
}
}
73

View Slide

DX Improvements
Conductor ʹ͓͚ΔφϏήʔγϣϯͷ࢓૊Έ
class OriginalController : Controller() {
fun onButtonClick() {
router.pushController(
RouterTransaction.with(DestinationController())
)
}
}
74
͜͜Λ͏·͘ந৅Խͭͭ͠ςετ͠΍͍͢ઃܭ͕ඞཁ

View Slide

DX Improvements
Navigation ͷ࣮ྫ: վળલ
class OriginalController : Controller {
var navigateFromOkButton: (() -> Unit)? = null
}
class OriginalNavigator : Navigator {
override fun startController() {
controller?.run {
navigateFromOkButton = {
next(DestinationController())
}
}
}
}
75

View Slide

DX Improvements
Navigation ͷ࣮ྫ: վળલ
var navigateFromOkButton: (() -> Unit)? = null
}
class OriginalNavigator : Navigator {
override fun startController() {
controller?.run {
navigateFromOkButton = {
}
}
}
}
X

View Slide

DX Improvements
Good
▸ feature Ϟδϡʔϧͷػೳ࣮૷ͱφϏήʔγϣϯϩδοΫ͕෼཭Ͱ͖͍ͯΔ
▸ ؆୯ʹφϏήʔγϣϯͷϩδοΫΛࠩ͠ସ͑ΒΕΔ
76

View Slide

DX Improvements
Needs improvement
▸ ΠϯλϑΣʔε͕ͳ͍
▸ ϥϜμͰ֤ Controller ʹఆٛ͢Δ͔͠ͳ͍
▸ φϏήʔγϣϯͷϩδοΫΛϢχοτςετ͍͕ͨ͠……
▸ ঢ়ଶΛಠࣗ؅ཧ͍ͯ͠Δ෦෼Λ͏·͘ϞοΫ͠ͳ͍ͱ͍͚ͳ͍
▸ ϞοΫϥΠϒϥϦͷ spy ػೳ͕ͳ͍ͱݫ͍͠
77

View Slide

DX Improvements
How to improve
▸ φϏήʔγϣϯΛΠϯλϑΣʔεͱͯ͠ఆ͍ٛͨ͠
▸ ΦϒδΣΫτͱͯ͠ৼΔ෣ͬͯ΄͍͠
▸ ঢ়ଶͷಠࣗ؅ཧΛ΍Ί͍ͨ
▸ Conductor ͕طʹ΍͍ͬͯΔ͜ͱΛࣗ෼͕ͨͪ΍Δඞཁ͸ͳ͍
▸ ςετΛॻ͖΍͍ͨ͘͢͠
▸ ্هͷ͜ͱ͕ୡ੒Ͱ͖ͨΒॻ͖΍͘͢ͳΔ͸ͣ
78

View Slide

DX Improvements
79
OriginalController
DestinationController
Feature B
Feature A
Navgigation
OriginalNavigator
OriginalNavigation

View Slide

DX Improvements
Navigation ͷ࣮ྫ: վળޙ
val navigator: OriginalNavigation by lazy { /* … */ }
}
abstract class OriginalNavigation(
controller: OriginalController
) : Navigation(controller) {
abstract fun navigateToDestination()
}
class OriginalNavigator(
) : OriginalNavigation(controller) {
override fun navigateToDestination() {
}
}
80

View Slide

DX Improvements
Navigation ͷ࣮ྫ: վળޙ
val navigator: OriginalNavigation by lazy { /* … */ }
}
abstract class OriginalNavigation(
) : Navigation(controller) {
abstract fun navigateToDestination()
}
class OriginalNavigator(
) : OriginalNavigation(controller) {
override fun navigateToDestination() {
}
}
X

View Slide

DX Improvements
Result: ੒Ռ
✔φϏήʔγϣϯΛΠϯλϑΣʔεͱͯ͠ఆ͍ٛͨ͠
‣ ΠϯλϑΣʔε͕ఆٛͰ͖Δ࢓૊Έʹͳͬͨ
✔ঢ়ଶͷಠࣗ؅ཧΛ΍Ί͍ͨ
‣ Conductor ʹ೚͍ͤͯΔ
✔ςετΛॻ͖΍͍ͨ͘͢͠
‣ φϏήʔγϣϯϩδοΫͷςετ͕ॻ͖΍͘͢ͳͬͨ
81

View Slide

DX Improvements
Result: ੒Ռ
✔ςετΧόϨοδͷ޲্
‣ ϢχοτςετͰݕূͰ͖ΔྖҬ͕ͻΖ͕͓͔ͬͨ͛
82

View Slide

DX Improvements
Caveat: ςετΧόϨοδͷ਺ࣈͱ͏·͘෇͖߹͏
‣ ΧόϨοδͷ਺ࣈ͕͕͋ͬͨ͜ͱͷҙຯΛߟ͑Δ
‣ ҙຯͷ͋ΔςετΛॻ͍ͨ݁Ռͳͷ͔Ͳ͏͔
‣ ΧόϨοδͷ਺ࣈ͕͕͋Ε͹Α͍Θ͚Ͱ͸ͳ͍
83

View Slide

DX Improvements
Caveat: ςετΧόϨοδͷ਺ࣈͱ͏·͘෇͖߹͏
‣ ViewDelegate
‣ State ʹԠͨ͡ View ͷૢ࡞Λݕূ͢Δ͜ͱʹҙຯ͕͋Δ
‣ Navigation
‣ ద੾ͳը໘ͷݺͼग़͠Λݕূ͢Δ͜ͱʹҙຯ͕͋Δ
84

View Slide

DevOps ͷվળ

View Slide

DX Improvements
Development Process/Workﬂow: ։ൃϓϩηεɾϫʔΫϑϩʔ
▸ ։ൃϓϩηεɾϫʔΫϑϩʔͷ՝୊
1. ࣌ؒͷ͔͔Δ CI
2. ϑΟʔυόοΫ͕ݟͮΒ͍ίʔυղੳπʔϧ
3. ࣌ؒͷ͔͔Δεςοϓ͕ෳ਺͋Δ౷߹खॱ
‣ ೔ʑͷ։ൃΠςϨʔγϣϯͷ଍͔ͤʹͳͬͯ͠·͏ཁҼΛղܾ͍ͯ͘͠
86

View Slide

DX Improvements
1. ࣌ؒͷ͔͔Δ CI
87

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ Ұճͷ git push Ͱಈ࡞͢Δ CI ͕ऴΘΔ·Ͱ
▸ ͍͍ͩͨ30෼
▸ ͢΂ͯͷεςοϓΛஞ࣮࣍ߦ͍ͯͨ͠
▸ Checkout → Environment Set up → Verify → Assemble → Save Cache
88

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ ݸʑͷεςοϓͰ΋ඞཁҎ্ʹ͕͔͔͍࣌ؒͬͯͨ
▸ Ωϟογϡͷ෮ݩ: 4෼͘Β͍
▸ SDK ͷηοτΞοϓ: 1෼൒͘Β͍
▸ Ϗϧυ: 6෼ऑ͘Β͍
▸ ੒Ռ෺ͷอଘ: 4෼൒͘Β͍
▸ Ωϟογϡͷอଘ: 8෼൒͘Β͍
89

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ εςοϓͷฒྻԽ
▸ Verify ͱ Assemble ͷಉ࣌ฒߦ
▸ ςετͷ࣮ߦํ๏ͷ޻෉
▸ ෆඞཁͳॲཧͷ Spark Joy
▸ SDK ͷΞοϓσʔτ
▸ ڊେͳΩϟογϡͷอଘͱ෮ݩ
90

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ Verify ͱ Assemble ͷಉ࣌ฒߦ
▸ ͜Ε͚ͩͰ͔ͳΓૣ͘ CI ͕ճͤΔΑ͏ʹͳͬͨ
91

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ ςετͷฒྻ࣮ߦ
▸ ςετΛॻ͖΍͍͢࡞Γʹͨ݁͠Ռɺ 
Ϣχοτςετͷςετέʔε͕രൃతʹ૿͑ͨ
▸ Gradle ͷෳ਺ϓϩηεͰͷ࣮ߦͰ΋δϦශʹͳ͖ͬͯͨ
▸ CI ͷઃఆͰίϯςφΛෳ਺ىಈ͠ɺίϯςφ͝ͱʹҟͳΔςετΛಉ࣌ʹ࣮ߦ
▸ ref: https://tech.mercari.com/entry/2019/09/03/000000
92

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ ςετͷฒྻ࣮ߦ
▸ ςετΛॻ͖΍͍͢࡞Γʹͨ݁͠Ռɺ 
Ϣχοτςετͷςετέʔε͕രൃతʹ૿͑ͨ
▸ Gradle ͷෳ਺ϓϩηεͰͷ࣮ߦͰ΋δϦශʹͳ͖ͬͯͨ
▸ CI ͷઃఆͰίϯςφΛෳ਺ىಈ͠ɺίϯςφ͝ͱʹҟͳΔςετΛಉ࣌ʹ࣮ߦ
93

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ ςετͷฒྻ࣮ߦͷઃఆ
94

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
95

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ Gradle ͰϚϧνϞδϡʔϧߏ੒ͩͱɺCircleCI ͷ CLI πʔϧ͕࢖͍ͮΒ͍
▸ ࣗ෼Ͱίϯςφ͝ͱʹͲͷςετΛ࣮ߦ͢Δ͔ܭࢉ͢Δ
96

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ ϞδϡʔϧͰ෼ࢄ
97

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ Ϗϧυ؀ڥͷίϯςφԽ
▸ Docker Λ࢖ͬͯ CI
▸ Ϗϧυʹඞཁͳ΋ͷ͸͢΂ͯΠϝʔδʹݻΊ͓ͯ͘
▸ Android SDK ΛຖճΞοϓσʔτ͠ͳͯ͘΋Α͍
▸ Πϝʔδͷόʔδϣϯ؅ཧ΋ՄೳʹͳΔ
98

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ Ωϟογϡͷ؅ཧ
▸ Gradle ͕΋͍ͬͯΔΩϟογϡ͕ͱʹ͔͘େ͖͍
▸ Ωϟογϡ͢΂͖σΟϨΫτϦ͚ͩΩϟογϡ͢Δ
▸ ~/.gradle/caches
▸ ~/.gradle/wrapper
99

View Slide

DX Improvements
࣌ؒͷ͔͔Δ CI
▸ Ұճͷ git push Ͱಈ࡞͢Δ CI ͕ऴΘΔ·Ͱ
▸ ͍͍ͩͨ10෼
100

View Slide

DX Improvements
1. ࣌ؒͷ͔͔Δ CI
101

View Slide

DX Improvements
ϑΟʔυόοΫ͕ݟͮΒ͍ίʔυղੳπʔϧ
▸ Android Lint ΍ KtLint ͳͲ
▸ CI Ͱಈ͔͍ͯ͠Δ͕ɺ݁Ռ͕ CI ͷϩάग़ྗʹ͔͠ग़ͳ͍
▸ ຖճ CI ͷը໘Λ։͍ͯϩά͔ΒࢦఠΛ୳͠ग़͍ͯͨ͠
102

View Slide

DX Improvements
▸ GitHub ͷΠϯϥΠϯίϝϯτͰίʔυղੳͷࢦఠΛݟ͑ΔԽ͢Δ
▸ danger πʔϧͷಋೖͰղܾ
▸ ݟ͑ΔԽͨ͠΋ͷ
▸ Android Lint ͱ KtLint ͷܯࠂ
▸ ࣦഊͨ͠Ϣχοτςετ
▸ apk ͷղੳ݁Ռ
103

View Slide

DX Improvements
▸ ϚϧνϞδϡʔϧߏ੒ಛ༗ͷରԠ
▸ Ϟδϡʔϧ͝ͱʹࢄΒ͹ͬͨϨϙʔτϑΝΠϧͷऩू
▸ ࣗ෼Ͱ XML Λ͔͖ूΊͯɺͻͱͭʹ߹ମͯ͠ॻ͖ग़͢
104

View Slide

DX Improvements
1. ࣌ؒͷ͔͔Δ CI
105

View Slide

DX Improvements
࣌ؒͷ͔͔Δεςοϓ͕ෳ਺͋Δ౷߹खॱ
▸ ϝϧϖΠ͸ϝϧΧϦΞϓϦͷػೳͷҰ෦
▸ ϝϧϖΠͷػೳ͕ϝϧΧϦΞϓϦʹ౷߹͞ΕΔ·Ͱ
1. ϝϧϖΠϦϙδτϦͰػೳ։ൃ
2. λάΛଧͬͯ੒Ռ෺ (aar) ΛσϓϩΠ
3. ϝϧΧϦϦϙδτϦͰ੒Ռ෺ͷόʔδϣϯΛߋ৽
4. ϝϧΧϦΞϓϦΛϏϧυ
106

View Slide

DX Improvements
▸ ϝϧϖΠ͸ϝϧΧϦΞϓϦͷػೳͷҰ෦
▸ ϝϧϖΠͷػೳ͕ϝϧΧϦΞϓϦʹ౷߹͞ΕΔ·Ͱ
1. ϝϧϖΠϦϙδτϦͰػೳ։ൃ
2. λάΛଧͬͯ੒Ռ෺ (aar) ΛσϓϩΠ
3. ϝϧΧϦϦϙδτϦͰ੒Ռ෺ͷόʔδϣϯΛߋ৽
4. ϝϧΧϦΞϓϦΛϏϧυ
107

View Slide

DX Improvements
▸ ϝϧϖΠͷػೳηοτΛϥΠϒϥϦͱͯ͠ఏڙ͍ͯ͠Δ͕……
▸ API ͳͲͷϞσϧ͚ͩͰͳ͘ɺը໘ͷ࣮૷·ͰؚΜͰ͍Δ
▸ ಠཱͨ͠ΞϓϦͰ͸ͳ͘ɺϝϧΧϦΞϓϦͰ࢖͏΋ͷ
▸ ը໘ͷ࣮૷͸ϝϧΧϦϦϙδτϦͰߦͬͨ΄͏͕खॱ͕؆ུԽͰ͖Δ
108

View Slide

DX Improvements
▸ ϦϙδτϦͷ౷߹
▸ Ongoing…
109

View Slide

Wrap up

View Slide

DX Improvements
Wrap up
▸ DX = Developer eXperience: ։ൃମݧ
▸ ೔ʑͷ։ൃ͕εϜʔζʹਐΊΒΕ͍ͯΔ͔Ͳ͏͔
▸ Կ΋͠ͳͯ͘΋ DX ͸ѱ͘ͳΔ͜ͱ͕͋Δ
▸ νʔϜͱͯ͠ DX ͷվળʹܧଓతʹऔΓ૊Έଓ͚Δ͜ͱ
▸ ৺ཧత҆શੑ
▸ ໨ઢɾೝࣝ߹Θͤ
111

View Slide

DX Improvements
Keishin Yokomaku (@KeithYokoma) / Merpay, Inc.

View Slide

DX Improvements

DX Improvements

Keishin Yokomaku

More Decks by Keishin Yokomaku

Other Decks in Technology

Featured

Transcript