happy about you are PR to Zephyr with Nuclei SDK project, our team in Nuclei are also planning to provide zephyr integeration in future, using the Nuclei SDK project is a good choice. I also see you have made some changes to Nuclei SDK, any extra requrements to be maded to support Zephyr, maybe I can provide some help to see whether the changes can be placed in Nuclei SDK project directly. Thanks Huaqi
at your implementation. It is very nice all the work that you made. I added part of your work to my branch, just to share with you my structure. https://github.com/nandojve/zephyr/tree/gigadevice I noted that there is a project dedicated to NMSIS at https://github.com/Nuclei- Software/NMSIS I think it will be better if we can use that directly, somehow. Zephyr folks can suggest best way. The #34970 is too dense. People will ask to you split. In the past, I already try add some work like you. https://github.com/zephyrproject-rtos/zephyr/pull/34970 The first thing is, reorganize the #34970 on a minimal implementation, like on my branch. You only need a hello world working. No interrupt driver, gpio, pinctrl etc. Only the minimal serial driver. I made (on my branch) a directory soc/riscv/gigadevice. Probably, the correct one is soc/riscv/nuclei/gigadevice. People from Zephyr will orientate the best place to put the gigadevice directory. On your PR, you are mixing some code. Try clean around soc. The ECLIB driver is not, in fact, necessary to introduce the nuclei. You can simple add that few lines at soc.c. Later a unique PR can be created. Drop clock, gpio and interrupt_controller drivers at first. each one need a separated PR. Use a minimal serial driver like the one on my branch. At logan board, add only the minimal necessary features to run a hello world. Above are some tips. I hope you understand I only want contribute a little of my experience with Zephyr and I rely want to see this boards soon on Zephyr. BTW, until next design cycle, people from Zephyr probably want comment anything. They are so busy preparing the 2.6 release.