Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Effective Pull Request Reviews

Bas Broek
October 08, 2021

Effective Pull Request Reviews

Pull request (and their associated reviews) are an integral part of a developer’s life. And for good reasons!

While some may love them, and others somewhat less so, there’s a good chance you’re spending quite some time on reviews as part of your project or job.

Therefore, it’s crucial to make our pull request experience great. And kind. And welcoming.

I want to share some thoughts on what I’ve learned about making the pull request experience awesome.

Bas Broek

October 08, 2021

Transcript

43 slides
  1. /// Create and return an action with the specified title

    and behavior. /// ... public convenience init( title: String? = nil, image: UIImage, isChecked: Bool = false, style: UIAlertAction.Style, handler: ((UIAlertAction) -> Void)? = nil ) { self.init(title: title, style: style, handler: handler) // Set values for specific keys, as there is no explicit API available. setValue(image, forKey: imageKey) setValue(isChecked, forKey: isCheckedKey) } @basthomas 27
  2. /// Create and return an action with the specified title

    and behavior. /// ... public convenience init( title: String? = nil, image: UIImage, isChecked: Bool = false, style: UIAlertAction.Style, handler: ((UIAlertAction) -> Void)? = nil ) { self.init(title: title, style: style, handler: handler) // Set values for specific keys, as there is no explicit API available. setValue(image, forKey: imageKey) setValue(isChecked, forKey: isCheckedKey) } @basthomas 28

More Decks by Bas Broek

Other Decks in Programming