Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Reviews

Code Reviews

Just Do It!

Janos Gyerik

October 14, 2015
Tweet

More Decks by Janos Gyerik

Other Decks in Programming

Transcript

  1. code.reviews Janos Gyerik correct clean efficient tested efficient efficient clean

    clean tested tested correct correct correct tested correc orrect correc tested efficient clean
  2. 3 commit
 commit
 commit
 review
 commit
 commit
 review
 commit
 accept

    commit
 commit
 commit
 
 NOT code reviewed code reviewed
  3. 6

  4. 12

  5. 14 big bang development too hard to control should be

    the exception, not the norm! code reviews 
 are not practical when…
  6. 15 without supporting tools tools help doing code reviews efficiently

    don’t waste your time, get them and use them! code reviews 
 are not practical…
  7. 24

  8. 29 git fetch origin master git checkout -b feature-x origin/ma

    # work work work git commit git commit git push origin feature-x # create merge request
  9. 33 readable is it clear? easy to read? easy to

    understand? FACT Code is read far more often
 than written!
  10. 44 perfect code? don’t seek perfect seek good enough better

    is good enough don’t be a pain in the ass be flexible be constructive
  11. 45

  12. 47