OnActivityResult - おまえら！もうonActivityResultでswitchとif書く時代は終わりだぞ！

OnActivityResult
おまえら！もうonActivityResultでswitchとif書く時代は終わりだぞ！

OnActivityResult
https://github.com/vanniktech/OnActivityResult

Sample Code
https://github.com/operando/OnActivityResult/tree/my_sample_code/onactivityresult-sample

Activity.RESULT_FIRST_USER
https://developer.android.com/reference/android/app/Activity.html#RESULT_FIRST_USER

kyobashi.dex #4
https://rmp-quipper.connpass.com/event/47555/

Transcript

1. OnActivityResult
   kyobashi.dex #4
   ͓·͑Βʂ΋͏onActivityResultͰswitchͱifॻ࣌͘୅͸ऴΘΓͩͧʂ
   

   View Slide

2. About Me
   Shinobu Okano
   @operandoOS
   Mercari, Inc.
   Souzoh, Inc.
   

   View Slide

3. View Slide

4. Do you know
   onActivityResult?
   

   View Slide

5. Do you know onActivityResult?
   https://developer.android.com/
   training/basics/intents/result.html
   Getting a Result from an Activity
   

   View Slide

6. Getting a Result from an Activity
   // Start the Activity
   static final int PICK_CONTACT_REQUEST = 1; // The request code
   private void pickContact() {
   Intent pickContactIntent = new Intent(Intent.ACTION_PICK, Uri.parse("content://contacts"));
   pickContactIntent.setType(Phone.CONTENT_TYPE); // Show user only contacts w/ phone numbers
   startActivityForResult(pickContactIntent, PICK_CONTACT_REQUEST);
   }
   // Receive the Result
   @Override
   protected void onActivityResult(int requestCode, int resultCode, Intent data) {
   if (requestCode == PICK_CONTACT_REQUEST) {
   if (resultCode == RESULT_OK) {
   // ...
   }
   }
   }
   

   View Slide

7. ๭ϑϦϚΞϓϦ͔Βഈआͨ͠

   onActivityResult
   ※ఆ਺໊ͱ͔ͦ͜Βล͸ม͑ͯ·͢
   

   View Slide

8. ๭ϑϦϚΞϓϦ onActivityResult
   @Override
   protected void onActivityResult(int requestCode, int resultCode, Intent data) {
   super.onActivityResult(requestCode, resultCode, data);
   switch(requestCode) {
   case LOGIN:
   if(resultCode == RESULT_OK) {
   success();
   } else {
   failed();
   }
   break;
   }
   }
   

   View Slide

9. @Override
   protected void onActivityResult(int requestCode, int resultCode, Intent data) {
   super.onActivityResult(requestCode, resultCode, data);
   if(resultCode != RESULT_OK) return;
   switch (requestCode) {
   case REQUEST_MUGAMUGA:
   successItemPost();
   break;
   }
   }
   ๭ϑϦϚΞϓϦ onActivityResult
   

   View Slide

10. @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    if (resultCode != RESULT_OK || data == null) {
    mugemuge();
    return;
    }
    if (requestCode == Request.UMUUMU) {
    umuumu();
    }
    }
    ๭ϑϦϚΞϓϦ onActivityResult
    

    View Slide

11. @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
    if (resultCode == Activity.RESULT_CANCELED) {
    cancel();
    } else if (requestCode == REQUEST_CODE_SELECT_IMAGE) {
    // ....
    } else if (requestCode == REQUEST_CODE_TRIMMING) {
    // ....
    } else {
    super.onActivityResult(requestCode, resultCode, data);
    }
    }
    ๭ϑϦϚΞϓϦ onActivityResult
    

    View Slide

12. @Override
    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    if (requestCode == REQUEST_MUGAMUGA && resultCode == Activity.RESULT_OK) {
    if (data != null) {
    mugamuga();
    }
    }
    }
    ๭ϑϦϚΞϓϦ onActivityResult
    

    View Slide

13. @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
    if (resultCode != Activity.RESULT_OK) {
    return;
    }
    switch (requestCode) {
    case REQUEST_CODE_CATEGORY:
    // ...
    break;
    case REQUEST_CODE_LOCATION:
    // ...
    break;
    case REQUEST_CODE_CONDITION:
    // ...
    break;
    default:
    super.onActivityResult(requestCode, resultCode, data);
    break;
    }
    }
    ๭ϑϦϚΞϓϦ onActivityResult
    

    View Slide

14. onActivityResultͷѱ͞
    • switchͱif͕ଟ͍
    • requestCodeͱresultCodeΛνΣοΫ͠ͳ͍ͱ͍͚ͳ͍
    • switchͱifͷॻ͖ํ͕·ͪ·ͪ
    • switch࢖Θͳ͍੎ + if else੎
    • requestCodeͱresultCodeͲͬͪʹઌʹ൑ఆ͢Δ͔໰୊
    • ਓ͕ؒॻ͘ʹ͸ͭΒ͍...
    

    View Slide

15. Do you know
    OnActivityResult?
    

    View Slide

16. OnActivityResult
    OnActivityResult annotation compiler
    for Android
    https://github.com/vanniktech/OnActivityResult
    

    View Slide

17. Ξοςͷ

    onActivityResultͷ࣮૷͸

    ͢΂ͯOnActivityResultͰ͢ʂ
    

    View Slide

18. onActivityResultͷ࣮૷͕͜Ε͚ͩʂʂ
    @Override
    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    ActivityResult.onResult(requestCode, resultCode, data).into(this);
    }
    

    View Slide

19. ͗͢ΐ͍
    

    View Slide

20. ड͚औͬͨ͋ͱͷ࣮૷͸ʁʁ
    • ͦΕͧͷͨύλʔϯʹ͋ͬͨϝιουΛఆٛͯ͠
    @OnActivityResultΛ͚ͭΔ
    • @OnActivityResultͷrequestCodeͱresultCodesͰ

    Ͳ͏͍͏݁Ռͷ৔߹ʹݺͼग़ͯ͠΄͍͔͠Λఆٛ͢Δ
    

    View Slide

21. ड͚औͬͨ͋ͱͷ࣮૷͸ʁʁ
    @OnActivityResult(requestCode = REQUEST_TAKE_PHOTO, resultCodes = RESULT_OK)
    void onTakePhoto(@ExtraString(name = CameraActivity.RESULT_TAKE_PHOTO)
    final String takePhoto) {
    Intent resultIntent = new Intent();
    resultIntent.putExtra(RESULT_TAKE_PHOTO, takePhoto);
    setResult(RESULT_CODE_TAKE_PHOTO, resultIntent);
    finish();
    }
    

    View Slide

22. ड͚औͬͨ͋ͱͷ࣮૷͸ʁʁ
    // result codeʹԿ͕ฦ͖ͬͯͯ΋ॲཧ͢Δϝιου
    @OnActivityResult(requestCode = REQUEST_SELECT_IMAGE)
    void onHumuHumu() {
    Toast.makeText(this, "onHumuHumu", Toast.LENGTH_SHORT).show();
    }
    @OnActivityResult(requestCode = REQUEST_SELECT_IMAGE, resultCodes = RESULT_CANCELED)
    void onCancel() {
    Toast.makeText(this, "cancel select image.”, Toast.LENGTH_SHORT).show();
    }
    

    View Slide

23. ͗͢ΐ͘ͳ͍ʁ
    

    View Slide

24. (ΈΜͳ)
    ͗͢ΐ͍
    

    View Slide

25. onActivityResultͷड͚औΓઌͷ
    ΦϒδΣΫτΛࢦఆ͢Δ
    • intoʹड͚औΓઌΦϒδΣΫτΛࢦఆ͢Δ
    • ActivityResult.onResult().into(obj);
    • onActivityResultͰฦͬͯ͘ΔIntentͷσʔλΛ
    ViewModelͱ͔PresenterͰड͚औΔ
    • ઃܭʹΑͬͯ͸خ͍͠
    

    View Slide

26. onActivityResultͷ݁ՌΛ

    ViewModelͰड͚औΔ
    private MySampleMainViewModel viewModel = new MySampleMainViewModel();
    @Override
    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    ActivityResult.onResult(requestCode, resultCode, data).into(viewModel);
    }
    public class MySampleMainViewModel {
    public ObservableField location = new ObservableField<>("0,0");
    @OnActivityResult(requestCode = MySampleMainActivity.REQUEST_SELECT_LOCATION,
    resultCodes = Activity.RESULT_OK)
    void onSelectedLocation(@Extra(name = LocationSelectActivity.RESULT_SELECT_LOCATION) Location location) {
    this.location.set(location.toString());
    }
    }
    

    View Slide

27. OnActivityResult sample Code
    https://github.com/operando/OnActivityResult/tree/
    my_sample_code/onactivityresult-sample
    https://github.com/operando/OnActivityResult/tree/my_sample_code/onactivityresult-sample/
    build/generated/source/apt/debug/com/vanniktech/onactivityresult/sample
    ෍ڭ׆ಈͷͨΊʹద౰ʹαϯϓϧίʔυॻ͍ͯ·͢
    annotation processorͰ࡞੒͞ΕΔίʔυ΋

    ೖΕͯ͋Γ·͢
    

    View Slide

28. Do you know Activity.RESULT_FIRST_USER?
    • Start of user-defined activity results.
    • Constant Value: 1 (0x00000001)
    • https://developer.android.com/reference/android/
    app/Activity.html#RESULT_FIRST_USER
    

    View Slide

29. Ͳ͏͍͏৔߹ʹ࢖͏͔
    • ը໘A͔Βը໘B΁RequestΛ͢Δ࣌

    ը໘B͔Βͷ໭Γ͕2ύλʔϯҎ্͋Δ
    ৔߹
    • ???
    

    View Slide

30. Ξοςͷྫ)

    ืू౤ߘը໘͔Βը૾બ୒Λ͢Δ
    • ը૾બ୒ը໘Ͱ͸ΪϟϥϦʔͷը૾Λબ୒͢Δ͔ɺΧϝϥͰࡱӨ͢Δ͔ͷ

    2ύλʔϯ͋Δ
    • ΧϝϥࡱӨ͸·ͨผը໘͕ىಈͯ͠ɺͦͷ໭ΓΛը૾બ୒ը໘͕ड͚औΔ
    • ืू౤ߘը໘΁ͷ໭Γ͕ɺΪϟϥϦʔͷը૾Λબ୒ɺΧϝϥͰࡱӨͷ2ύλʔϯ͋Δ
    • = ืू౤ߘը໘͔Βը૾બ୒ը໘ʹରͯ͠͸1Request͚ͩͲ

    2ύλʔϯͷ໭Γ(Resultύλʔϯ)͕͋Δ
    • = ಠࣗͷResult CodeΛఆ͍ٛͨ͠ = Activity.RESULT_FIRST_USERΛ࢖ͬͯఆٛ
    

    View Slide

31. ΞοςͷྫͰ...
    

    View Slide

32. ΞοςͷྫͰ...
    

    View Slide

33. OnActivityResultͰ࣮૷͢Δͱ…
    // ImageSelectActivity
    static final int RESULT_CODE_SELECT_IMAGE = Activity.RESULT_FIRST_USER;
    static final int RESULT_CODE_TAKE_PHOTO = Activity.RESULT_FIRST_USER + 1;
    @OnActivityResult(requestCode = REQUEST_SELECT_IMAGE,
    resultCodes = ImageSelectActivity.RESULT_CODE_SELECT_IMAGE)
    void onSelectImage(Intent intent) {
    ArrayList selectImages = intent.getStringArrayListExtra(RESULT_SELECT_IMAGES);
    Toast.makeText(this, "onSelectImage selectImages : " + selectImages, Toast.LENGTH_SHORT).show();
    }
    @OnActivityResult(requestCode = REQUEST_SELECT_IMAGE,
    resultCodes = ImageSelectActivity.RESULT_CODE_TAKE_PHOTO)
    void onTakePhoto(@ExtraString(name = ImageSelectActivity.RESULT_TAKE_PHOTO) final String takePhoto) {
    Toast.makeText(this, "onTakePhoto takePhoto : " + takePhoto, Toast.LENGTH_SHORT).show();
    }
    

    View Slide

34. Support user defined result code
    https://github.com/vanniktech/
    OnActivityResult/pull/86
    Զ͕ʂ
    OnActivityResultͰActivity.RESULT_FIRST_USER
    ࢖͑ΔΑ͏ʹͯ͠΍ͬͨͧʂ
    

    View Slide

35. Contributions
    

    View Slide

36. Contributions
    

    View Slide

37. Contributions
    ΠϠοοϗΥΥΥ
    ΦΦΥΦ΢ʂ
    

    View Slide

38. OnActivityResultͷؾʹೖͬͯΔͱ͜Ζ
    • onActivityResultϝιουͷ࣮૷͸γϯϓϧʹͳΔʂ
    • startActivityForResultͷݺͼग़͠͸طଘͷ··Ͱ͍͍ʂ
    • ड͚औΓޙͷॲཧ͝ͱʹϝιουఆٛ͢ΔͷͰݟ௨͕͍͍͠
    • ݁Ռड͚औΓઌͷΦϒδΣΫτΛࢦఆͰ͖Δ → into()
    • ifͱswitch͔Βͷ։์…
    

    View Slide

39. ͓·͑Βʂ
    ΋͏onActivityResultͰ

    switchͱifॻ࣌͘୅͸

    ऴΘΓͩͧʂ
    

    View Slide

40. Thanks!!
    

    View Slide