うごいてるコードレビュー

Transcript

1. ͏͍ͯ͝Δ
   ίʔυϨϏϡʔ JUPDIBO IUUQJOTJEFQJYJWOFUFOUSZ ͏͝Πϥ
   5FDI
   5BMLT

2. None

3. ͏͝Πϥഒ

4. ൃදऀʹ͍ͭͯ w ͍ͱ͓
   w !J
   w IUUQJUPDIBOKQ
   w ϐΫγϒΞϧόΠτ೥໨ʹಥೖ
   w

   ॳΊͯձࣾͰ-5͠·͢

5. ൃදऀʹ͍ͭͯ w "OESPJEΞϓϦ։ൃऀ
   w ൃදऀͷதͰ࠷΋͏͝Πϥʹؔͯ͠
 ஌ݟ͕ͳ͍Ͱ͢

6. ͏͝Πϥʹ͍ͭͯͪΐͬͱߟ͑ͯΈͨ | ΒΜͩΉ͚Μ͖Ύ͏͡ΐ! http://rndomhack.com/2014/07/04/%E3%81%86%E3%81%94%E3%82%A4%E3%83%A9%E3%81%AB %E3%81%A4%E3%81%84%E3%81%A6%E3%81%A1%E3%82%87%E3%81%A3%E3%81%A8%E8%80%83 %E3%81%88%E3%81%A6%E3%81%BF%E3%81%9F/ l࣮ࡍͷ࿩͸͏͝Πϥ
   5FDI
   5BMLTͳΜ͔ʹ ߦ͚͹͍͍͔΋͠Ε· ͤΜɻz

7. ࣮ࡍͷ࿩Λ͠·͢

8. ͏͝Πϥͱ͸ w ͏͘͝Πϥετͷུ
   w දهͷΏΕ

9. None
10. None

11. ͏͝Πϥͱ͸ w ͏͝Πϥ
    PS
    ͏͘͝Πϥετ
 PS
    6HPJSB
    PS
    "OJNBUFE
    *MMVTUSBUJPO
    w ͏͝Πϥ͕ਖ਼໊ࣜশ͔Ͳ͏͔Θ͔Βͳ͘ ͳ͖ͬͯͨ
    w ͜ͷ৔ʹ͓͍ͯ͸͏͝ΠϥͰਐߦ͠·͢

12. ίʔυϨϏϡʔ
 ʹ͍ͭͯ

13. "OESPJEΞϓϦ w ଞϓϩδΣΫτͰ͸(JU-BC͕࢖ΘΕͯ ͍Δ͕ɺΞϓϦͱ͍͔ͭ͘ͷϓϩδΣ ΫτͰ͸(JU)VC͕࢖ΘΕ͍ͯΔ
    w ݱࡏ"OESPJEΞϓϦͷίʔυΛॻ͍ͯ ͍Δͷ͸ࣾһ໊ ΞϧόΠτ໊

14. ϨϏϡʔͷྲྀΕ

15. 1VMM
    3FRVFTU
    ཱ͕ͭ

16. ϨϏϡʔͯ͠ʂ
    ཉٻߴ·Δ

17. ϨϏϡʔΛ͢Δ

18. Αͦ͞͏

19. Α͞

20. IUUQTUXJUUFSDPNUPUPUPTIJTUBUVTFT

21. -(5.
    -00,4
    (00%
    50
    .& IUUQXXXMHUNJOJ;6;

22. ಈ͖ॏཁ

23. ίʔυϨϏϡʔʹ
    ಈ͖Λ

24. ͏͍ͯ͝Δ
    ίʔυϨϏϡʔ

25. None
26. None

27. 
    DPNNFOUT

28. None

29.  
    BEEJUJPOT
    
    EFMFUJPOT

30. େྔͷมߋ
    ഭΓ͘Δίʔυ

31. ్தͰϨϏϡΞ͕
    มΘͬͨΓͨ͠

32. มߋଟ͗ͯ͢
    ݟΕͳ͍

33. ͦ͜ΛͳΜͱ͔

34. ػೳ໘ͷϨϏϡʔ͸
    લͷϨϏϡΞ͕طʹ
    ͍͍ͩͨ΍͍ͬͯͨ

35. ओʹ࡞๏ͳͲͷ
    Α͘ͳ͍ίʔυ
    ΛϨϏϡʔͨ͠

36. None

37. ίʔυͷ࿩

38. ਓͷϨϏϡΞ !@@DIPDPNFMPO !J

39. ྫ֎Λ
    QSJOU4UBDL5SBDF
    ͠ͳ͍ ✘ Bad ! 1 try { 2 //

    something code 3 } catch (SomethingException e) { 4 e.printStackTrace(); 5 }

40. ྫ֎Λ
    QSJOU4UBDL5SBDF
    ͠ͳ͍ ✔ Good ! 1 try { 2 //

    something code... 3 } catch (SomethingException e) { 4 // custom log utils 5 LogUtils.e("PixivAndroidApp", "SomethingException", e); 6 }

41. *%&͕ੜ੒͢Δ
    ίϝϯτΛফ͢ ✘ Bad ! 1 package jp.pxv.android; 2 3

    /** 4 * Created by Chobi on 2014/05/26. 5 */ 6 7 public class CreatedByComment { IUUQTUBDLPWFSqPXDPNRVFTUJPOT

42. *%&͕ੜ੒͢Δ
    ίϝϯτΛফ͢ ✔ Good ! 1 package jp.pxv.android; 2 3

    public class CreatedByComment { IUUQTUBDLPWFSqPXDPNRVFTUJPOT

43. ఆ਺͸
    TUBUJD
    pOBM
    Ͱ 1 public class Constants { 2 // ✘ Bad

    3 private final String BAD_FOO = "foo"; 4 private final String BAD_BAR = "bar"; 5 6 // ✔ Good 7 private static final String GOOD_FOO = "foo"; 8 private static final String GOOD_BAR = "bar"; 9 }

44. ม਺໊ ✘ Bad 1 @Override 2 public void onProgressChanged(float progressRate)

    { 3 final float _progressRate = progressRate; 4 uiThreadHandler.post(new Runnable() { 5 @Override 6 public void run() { 7 if (_progressRate == 1) { 8 progressBar.setVisibility(View.GONE); 9 } 10 } 11 }); 12 }

45. ม਺໊ ✔ Good 1 @Override 2 public void onProgressChanged(final float

    progressRate) { 3 uiThreadHandler.post(new Runnable() { 4 @Override 5 public void run() { 6 if (progressRate == 1) { 7 progressBar.setVisibility(View.GONE); 8 } 9 } 10 }); 11 }

46. ଞʹ͸ w ্ྲྀϒϥϯνͰ͢Ͱʹมߋ͞Ε͍ͯΔ ΋ͷ͕1VMM
    3FRVFTUͷϒϥϯνͰ΋ಉ ͡มߋͷผͷDPNNJUΛ͍ͯ͠Δ
    w ˠఆظతʹ্ྲྀϒϥϯνΛ
 git merge --no-ff
    ͰऔΓࠐΊ͹

    Α͍

47. ·ͱΊ w มߋ͕ଟ͗͢ΔͱϨϏϡʔ͠ʹ͍͘
    w ϨϏϡʔΛසൟʹߦ͏ͳͲ͢Δඞཁ͕͋Δ ˠ1VMM
    3FRVFTUͷ୯ҐΛࡉ͔͘͢Δ
    w ͏͔͝ͳ͍ίʔυΑΓ͸͏͘͝ίʔυͷ΄ ͏͕͍͍
    w

    ίʔυ͸அવ͖Ε͍ͳ΄͏͕͍͍

48. ͝ਗ਼ௌ͋Γ͕ͱ͏ ͍͟͝·ͨ͠